blk-mq: kick requeue list in blk_mq_requeue_request()
PATCH 1/1 blk-mq: kick requeue list in blk_mq_requeue_request()
blk_mq_requeue_request() should kick off the requeue list so that the request can be scheduled to queue finally.
In nvme conversion patch, blk_mq_requeue_request() is called to requeue failed request from completion handler, this patch fixes the issue and makes the block API working as expected.
--- block/blk-mq.c | 1 + 1 file changed, 1 insertion(+)
block/blk-mq.c +1 -0
@@ -462,6 +462,7 @@ void blk_mq_requeue_request(struct request *rq)BUG_ON (blk_queued_rq (rq));blk_mq_add_to_requeue_list (rq, true); +blk_mq_kick_requeue_list (rq->q); }EXPORT_SYMBOL (blk_mq_requeue_request);
Signature · 1 line
1.7.9.5
Quoted 6 lines · Ming Lei
blk_mq_requeue_request()should kick off the requeue list so that the request can be scheduled to queue finally.In nvme conversion patch,
blk_mq_requeue_request()is called to requeue failed request from completion handler, this patch fixes the issue and makes the block API working as expected.
I've intentionally kepts the two separate so that we can batch operations and just do a single kick for multiple requeued commands.
Quoted 11 lines · Christoph Hellwig
Quoted 6 lines · Ming Lei
blk_mq_requeue_request()should kick off the requeue list so that the request can be scheduled to queue finally.In nvme conversion patch,
blk_mq_requeue_request()is called to requeue failed request from completion handler, this patch fixes the issue and makes the block API working as expected.I've intentionally kepts the two separate so that we can batch operations and just do a single kick for multiple requeued commands.
OK, but the API name is a bit confusing, and that is easy to cause misuse, like in nvme.
Also requeue one request in completion handler may be a common case, so maybe it is better to let blk_mq_requeue_request() handle both adding to request list and kicking off, and introduce blk_mq_prep_requeue_req()(or better name) to batch operations.
Thanks,
Signature · 1 line
Ming Lei
Quoted 7 lines · Ming Lei
OK, but the API name is a bit confusing, and that is easy to cause misuse, like in nvme.
Also requeue one request in completion handler may be a common case, so maybe it is better to let
blk_mq_requeue_request()handle both adding to request list and kicking off, and introduce blk_mq_prep_requeue_req()(or better name) to batch operations.
For now please just add some documentation. I'm happy to revisit these once we have a few user in tree, but for now I'd like to keep blk-mq a little more stable to not impact the merges of the major users.
Quoted 9 lines · Christoph Hellwig
Quoted 7 lines · Ming Lei
OK, but the API name is a bit confusing, and that is easy to cause misuse, like in nvme.
Also requeue one request in completion handler may be a common case, so maybe it is better to let
blk_mq_requeue_request()handle both adding to request list and kicking off, and introduce blk_mq_prep_requeue_req()(or better name) to batch operations.
Quoted 4 lines
For now please just add some documentation. I'm happy to revisit these once we have a few user in tree, but for now I'd like to keep blk-mq a little more stable to not impact the merges of the major users.
There are two users: one is nvme, another is scsi-mq, and both don't need batch operations now.
Thanks,
Signature · 1 line
Ming Lei