tracing: Cleanup saved_cmdlines_size changes
PATCH 1/1 tracing: Cleanup saved_cmdlines_size changes
The recent addition of saved_cmdlines_size file had some remaining (minor - mostly coding style) issues. Fix them by passing pointer name to sizeof() and using scnprintf().
Cc Yoshihiro YUNOMAE <[email protected]>
Signed-off-by Namhyung Kim <[email protected]>
--- kernel/trace/trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/trace/trace.c +3 -3
@@ -1338,7 +1338,7 @@ static int trace_create_savedcmd(void) {int ret; - savedcmd =kmalloc (sizeof (struct saved_cmdlines_buffer ),GFP_KERNEL ); + savedcmd =kmalloc (sizeof (*savedcmd),GFP_KERNEL );if (!savedcmd)return -ENOMEM ;
@@ -3840,7 +3840,7 @@ tracing_saved_cmdlines_size_read(struct file *filp, char __user *ubuf,int r;arch_spin_lock (&trace_cmdline_lock); - r =sprintf (buf,"%u\n" , savedcmd->cmdline_num); + r =scnprintf (buf,sizeof (buf),"%u\n" , savedcmd->cmdline_num);arch_spin_unlock (&trace_cmdline_lock);return simple_read_from_buffer (ubuf, cnt, ppos, buf, r);
@@ -3857,7 +3857,7 @@ static int tracing_resize_saved_cmdlines(unsigned int val) {struct saved_cmdlines_buffer *s, *savedcmd_temp; - s =kmalloc (sizeof (struct saved_cmdlines_buffer ),GFP_KERNEL ); + s =kmalloc (sizeof (*s),GFP_KERNEL );if (!s)return -ENOMEM ;
Signature · 1 line
2.0.0