Skip to contentSkip to conversation

Fix: correct typo in kernel version number range

PATCH Antoine Busque 1 participant 1 message Jun 11, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 26 lines · Antoine Busque

A typo in an if statement verifying the range in which the current kernel's version is situated caused build failure for modules on 3.5.0 specifically, by trying to use the new api for block_rq_complete which has not been backported from the 3.15 branch to the 3.5 branch.

---
 instrumentation/events/lttng-module/block.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
instrumentation/events/lttng-module/block.h +1 -2
index dbe6c6c..ad0a363 100644
@@ -224,7 +224,7 @@ DEFINE_EVENT(block_rq_with_error, block_rq_requeue,
 #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,5)      \
        || LTTNG_KERNEL_RANGE(3,12,21, 3,13,0)          \
        || LTTNG_KERNEL_RANGE(3,10,41, 3,11,0)          \
-       || LTTNG_KERNEL_RANGE(3,4,91, 3,5,1)            \
+       || LTTNG_KERNEL_RANGE(3,4,91, 3,5,0)            \
        || LTTNG_KERNEL_RANGE(3,2,58, 3,3,0))
 
 /**
--

2.0.0

Quoted 4 lines

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

I just realised I forgot to sign off the previous patch, so I'll resend now. Please excuse the multiple emails, I'm still getting the hang of this workflow.

Regards,
Antoine.

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev