ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform.
Subsystems (2)
PATCH 1/1 ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform.
Cancel the optimization of compiler for struct snd_compr_avail which size will be 0x1c in 32bit kernel while 0x20 in 64bit kernel under the optimizer. That will make compaction between 32bit and 64bit. So add packed to fix the size of struct snd_compr_avail to 0x1c for all platform.
--- include/uapi/sound/compress_offload.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/uapi/sound/compress_offload.h +1 -1
@@ -80,7 +80,7 @@ struct snd_compr_tstamp {struct snd_compr_avail {__u64 avail;struct snd_compr_tstamp tstamp; -}; +} __attribute__((packed));enum snd_compr_direction {SND_COMPRESS_PLAYBACK =0 ,
Signature · 1 line
1.7.1
Quoted 8 lines · Xiaoming
Cancel the optimization of compiler for struct
snd_compr_availwhich size will be0x1cin 32bit kernel while0x20in 64bit kernel under the optimizer. That will make compaction between 32bit and 64bit. So add packed to fix the size of structsnd_compr_availto0x1cfor all platform.Signed-off-by Zhang Dongxing <[email protected]>Signed-off-by xiaoming wang <[email protected]>
Takashi, can we cc stable on this, would help fixing in older kernels too
Thanks
Signature · 1 line
~Vinod
Quoted 20 lines
--- include/uapi/sound/compress_offload.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/uapi/sound/compress_offload.h +1
-1@@ -80,7 +80,7 @@ struct snd_compr_tstamp {struct snd_compr_avail {__u64 avail;struct snd_compr_tstamp tstamp; -}; +} __attribute__((packed));enum snd_compr_direction {SND_COMPRESS_PLAYBACK =0 ,Signature · 1 line
1.7.1
At Thu, 12 Jun 2014 14:55:13 +0530,
Quoted 8 lines · Vinod Koul
Quoted 6 lines · Xiaoming
Cancel the optimization of compiler for struct
snd_compr_availwhich size will be0x1cin 32bit kernel while0x20in 64bit kernel under the optimizer. That will make compaction between 32bit and 64bit. So add packed to fix the size of structsnd_compr_availto0x1cfor all platform.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Zhang Dongxing <[email protected]>Signed-off-by xiaoming wang <[email protected]>Acked-by Vinod Koul <[email protected]>Takashi, can we cc stable on this, would help fixing in older kernels too
Yes, applied with Cc to stable now.
thanks,
Takashi
Quoted 27 lines
Thanks
Signature · 1 line
~VinodQuoted 20 lines
--- include/uapi/sound/compress_offload.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/uapi/sound/compress_offload.h +1
-1@@ -80,7 +80,7 @@ struct snd_compr_tstamp {struct snd_compr_avail {__u64 avail;struct snd_compr_tstamp tstamp; -}; +} __attribute__((packed));enum snd_compr_direction {SND_COMPRESS_PLAYBACK =0 ,Signature · 1 line
1.7.1