Skip to contentSkip to conversation

am335x: board.c: clang warning

U-Boot Jeroen Hofstee 2 participants 2 messages Jun 19, 2014 – Jun 20, 2014

lore
Share & tools
lore
#0 lore raw

Hello Tom,

The following clang warnings are not trivial to fix for me, And since the file in question has many contributers I am not sure who is responsible nowadays. Can you make sure this end up at someone who knows about the am335x, since this sound a bit fishy.. (but likely works somehow...)

Regards,
Jeroen

e.g. make am335x_boneblack_config

board/ti/am335x/board.c:87:44: warning: signed shift result (0x480000000) requires 36 bits to represent, but 'int' only has 32 bits [-Wshift-overflow]

        .datardsratio0 = ((MT47H128M16RT25E_RD_DQS<<30) |
                           ~~~~~~~~~~~~~~~~~~~~~~~^ ~~
board/ti/am335x/board.c:103:49: warning: signed shift result
(0x2000000000) requires 39 bits to represent, but 'int' only has 32 bits
[-Wshift-overflow]
        .datafwsratio0 = ((MT47H128M16RT25E_PHY_FIFO_WE<<30) |
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ ~~
board/ti/am335x/board.c:107:49: warning: signed shift result
(0x1000000000) requires 38 bits to represent, but 'int' only has 32 bits
[-Wshift-overflow]
        .datawrsratio0 = ((MT47H128M16RT25E_PHY_WR_DATA<<30) |
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ ~~

3 warnings generated.

#1 lore raw
Quoted 7 lines · Jeroen Hofstee

Hello Tom,

The following clang warnings are not trivial to fix for me, And since the file in question has many contributers I am not sure who is responsible nowadays. Can you make sure this end up at someone who knows about the am335x, since this sound a bit fishy.. (but likely works somehow...)

Investigating now, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140620/e01c849b/attachment.pgp>