thunderbolt: Add casts to prevent endianness warnings
Andreas Noever
maintainerPATCH 1/4 thunderbolt: Add casts to prevent endianness warnings
Thunderbolt packets are big endian. Cast pkg->buffer to __be32* when accessing the checksum.
Reported-by kbuild test robot <[email protected]>
Signed-off-by Andreas Noever <[email protected]>
--- drivers/thunderbolt/ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/thunderbolt/ctl.c +2 -2
@@ -355,7 +355,7 @@ static int tb_ctl_tx(struct tb_ctl *ctl, void *data, size_t len, pkg->frame.sof = type; pkg->frame.eof = type;cpu_to_be32_array (pkg->buffer, data, len /4 ); - *(u32 *) (pkg->buffer + len) =tb_crc (pkg->buffer, len); + *(__be32 *) (pkg->buffer + len) =tb_crc (pkg->buffer, len); res =ring_tx (ctl->tx, &pkg->frame);if (res)/* ring is stopped */
@@ -412,7 +412,7 @@ static void tb_ctl_rx_callback(struct tb_ring *ring, struct ring_frame *frame, } frame->size -=4 ;/* remove checksum */ -if (*(u32 *) (pkg->buffer + frame->size) +if (*(__be32 *) (pkg->buffer + frame->size) !=tb_crc (pkg->buffer, frame->size)) {tb_ctl_err (pkg->ctl,"RX: checksum mismatch, dropping packet\n" );
Signature · 1 line
2.0.0
Andreas Noever
maintainerPATCH 2/4 thunderbolt: Fix header declaration of tb_find_cap
tb_find_cap in cap.c takes an enum tb_cap and not an u32. Fix the declaration in tb.h.
Signed-off-by Andreas Noever <[email protected]>
--- drivers/thunderbolt/tb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/tb.h +1 -1
@@ -233,7 +233,7 @@ int tb_wait_for_port(struct tb_port *port, bool wait_if_unplugged);int tb_port_add_nfc_credits (struct tb_port *port,int credits);int tb_port_clear_counter (struct tb_port *port,int counter); -int tb_find_cap (struct tb_port *port,enum tb_cfg_space space,u32 value); +int tb_find_cap (struct tb_port *port,enum tb_cfg_space space,enum tb_cap cap);struct tb_path *tb_path_alloc (struct tb *tb,int num_hops);void tb_path_free (struct tb_path *path);
Signature · 1 line
2.0.0
Andreas Noever
maintainerPATCH 3/4 thunderbolt: Make enum tb_drom_entry_type unsigned
In reply to Andreas NoeverForce enum tb_drom_entry_type to unsigned to fix the following error:
drivers/thunderbolt/eeprom.c:202:39: error: dubious one-bit signed bitfield
Signed-off-by Andreas Noever <[email protected]>
--- drivers/thunderbolt/eeprom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/thunderbolt/eeprom.c +2 -1
@@ -191,7 +191,8 @@ struct tb_drom_header { } __packed;enum tb_drom_entry_type { -TB_DROM_ENTRY_GENERIC , +/* force unsigned to prevent "one-bit signed bitfield" warning */ +TB_DROM_ENTRY_GENERIC =0U ,TB_DROM_ENTRY_PORT , };
Signature · 1 line
2.0.0
Andreas Noever
maintainerPATCH 4/4 thunderbolt: Make tb_eeprom_get_drom_offset static
In reply to Andreas Noevertb_eeprom_get_drom_offset is local to this file.
Signed-off-by Andreas Noever <[email protected]>
--- drivers/thunderbolt/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/eeprom.c +1 -1
@@ -233,7 +233,7 @@ struct tb_drom_entry_port {/** * tb_eeprom_get_drom_offset - get drom offset within eeprom */ -int tb_eeprom_get_drom_offset (struct tb_switch *sw,u16 *offset) +static int tb_eeprom_get_drom_offset (struct tb_switch *sw,u16 *offset) {struct tb_cap_plug_events cap;int res;
Signature · 1 line
2.0.0