drm/i915: vlv_prepare_pll is only needed in case of non DSI interfaces
Subsystems (2)
PATCH 1/1 drm/i915: vlv_prepare_pll is only needed in case of non DSI interfaces
For MIPI, DSI PLL is configured separately in vlv_configure_dsi_pll during the DSI enable sequence
Causing WARN dump otherwise in dpio_reads
--- drivers/gpu/drm/i915/intel_display.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +4 -3
@@ -4629,7 +4629,10 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)if (intel_crtc->active)return ; -vlv_prepare_pll (intel_crtc); + is_dsi =intel_pipe_has_type (crtc,INTEL_OUTPUT_DSI ); + +if (!is_dsi) +vlv_prepare_pll (intel_crtc);/* Set up the display plane register */ dspcntr =DISPPLANE_GAMMA_ENABLE ;
@@ -4663,8 +4666,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)if (encoder->pre_pll_enable) encoder->pre_pll_enable (encoder); - is_dsi =intel_pipe_has_type (crtc,INTEL_OUTPUT_DSI ); -if (!is_dsi) {if (IS_CHERRYVIEW (dev))chv_enable_pll (intel_crtc);
Signature · 1 line
1.9.1
Quoted 6 lines · Shobhit Kumar
For MIPI, DSI PLL is configured separately in
vlv_configure_dsi_pllduring the DSI enable sequenceCausing WARN dump otherwise in
dpio_readsSigned-off-by Shobhit Kumar <[email protected]>
Yeah, the DPIO power wells might be down when enabling a DSI display so we shouldn't go poking at DPIO registers.
But please add a !IS_CHERRYVIEW check there also, and then you can add:
Looks like I need to split up chv_update_pll() in a similar fasion.
Quoted 36 lines
--- drivers/gpu/drm/i915/intel_display.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/intel_display.c +4
-3@@ -4629,7 +4629,10 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)if (intel_crtc->active)return ; -vlv_prepare_pll (intel_crtc); + is_dsi =intel_pipe_has_type (crtc,INTEL_OUTPUT_DSI ); + +if (!is_dsi) +vlv_prepare_pll (intel_crtc);/* Set up the display plane register */ dspcntr =DISPPLANE_GAMMA_ENABLE ;@@ -4663,8 +4666,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)if (encoder->pre_pll_enable) encoder->pre_pll_enable (encoder); - is_dsi =intel_pipe_has_type (crtc,INTEL_OUTPUT_DSI ); -if (!is_dsi) {if (IS_CHERRYVIEW (dev))chv_enable_pll (intel_crtc);Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Ville Syrjälä Intel OTC
PATCH v2 1/1 drm/i915: vlv_prepare_pll is only needed in case of non DSI interfaces
For MIPI, DSI PLL is configured separately in vlv_configure_dsi_pll during the DSI enable sequence
Causing WARN dump otherwise in dpio_reads
v2: Add IS_CHERRYVIEW check as suggested by Ville
--- drivers/gpu/drm/i915/intel_display.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +4 -3
@@ -4629,7 +4629,10 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)if (intel_crtc->active)return ; -vlv_prepare_pll (intel_crtc); + is_dsi =intel_pipe_has_type (crtc,INTEL_OUTPUT_DSI ); + +if (!is_dsi && !IS_CHERRYVIEW (dev)) +vlv_prepare_pll (intel_crtc);/* Set up the display plane register */ dspcntr =DISPPLANE_GAMMA_ENABLE ;
@@ -4663,8 +4666,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)if (encoder->pre_pll_enable) encoder->pre_pll_enable (encoder); - is_dsi =intel_pipe_has_type (crtc,INTEL_OUTPUT_DSI ); -if (!is_dsi) {if (IS_CHERRYVIEW (dev))chv_enable_pll (intel_crtc);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx