perf: fix arm64 build error
Subsystems (2)
PATCH 1/1 perf: fix arm64 build error
I'm seeing the following build error on arm64:
In file included from util/event.c:3:0:
util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
u64 cache_regs[PERF_REGS_MAX];
^This patch adds a PEFF_REGS_MAX definition for arm64.
--- tools/perf/arch/arm64/include/perf_regs.h | 2 ++ 1 file changed, 2 insertions(+)
tools/perf/arch/arm64/include/perf_regs.h +2 -0
@@ -6,6 +6,8 @@#include <asm/perf_regs.h> #define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1) +#define PERF_REGS_MAX PERF_REG_ARM64_MAX +#define PERF_REG_IP PERF_REG_ARM64_PC#define PERF_REG_SP PERF_REG_ARM64_SP
Signature · 1 line
1.9.0
Hi Mark,
Quoted 8 lines · Mark Salter
I'm seeing the following build error on arm64:
In file included from
util/event.c:3:0:
util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)u64 cache_regs[PERF_REGS_MAX]; ^This patch adds a
PEFF_REGS_MAXdefinition for arm64.
s/PEFF_REGS_MAX/PERF_REGS_MAX
Quoted 2 lines
Signed-off-by Mark Salter <[email protected]>
Thanks!
Note: Do you have any performance figure with and without the caching code in perf?
Jean
Quoted 20 lines
--- tools/perf/arch/arm64/include/perf_regs.h | 2 ++ 1 file changed, 2 insertions(+)tools/perf/arch/arm64/include/perf_regs.h +2
-1@@ -6,6 +6,8 @@#include <asm/perf_regs.h> #define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1) +#define PERF_REGS_MAX PERF_REG_ARM64_MAX +#define PERF_REG_IP PERF_REG_ARM64_PC#define PERF_REG_SP PERF_REG_ARM64_SP --1.9.0
Quoted 14 lines · Jean Pihet
Hi Mark,
Quoted 8 lines · Mark Salter
I'm seeing the following build error on arm64:
In file included from
util/event.c:3:0:
util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)u64 cache_regs[PERF_REGS_MAX]; ^This patch adds a
PEFF_REGS_MAXdefinition for arm64.s/PEFF_REGS_MAX/PERF_REGS_MAX
Quoted 1 line
Quoted 8 lines
Quoted 1 line
Signed-off-by Mark Salter <[email protected]>Acked-by Jean Pihet <[email protected]>Thanks!
Note: Do you have any performance figure with and without the caching code in perf?
Sorry, I don't.