Skip to contentSkip to conversation

m68k: Remove FIXME comment in file sun3_pgalloc.h

PATCH In review Nicholas Krause 4 participants 8 messages Jul 3, 2014 – Jul 4, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: Remove FIXME comment in file sun3_pgalloc.h

Removes a FIXME comment in this file due to it not compiling as it now compiles.

---
 arch/m68k/include/asm/sun3_pgalloc.h | 1 -
 1 file changed, 1 deletion(-)
arch/m68k/include/asm/sun3_pgalloc.h +0 -1
index f868506..1798f25 100644
@@ -12,7 +12,6 @@
 
 #include <asm/tlb.h>
 
-/* FIXME - when we get this compiling */
 /* erm, now that it's compiling, what do we do with it? */
 #define _KERNPG_TABLE 0
 
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Nicholas Krause

Removes a FIXME comment in this file due to it not compiling as it now compiles.

---
 arch/m68k/include/asm/sun3_pgalloc.h | 1 -
 1 file changed, 1 deletion(-)
arch/m68k/include/asm/sun3_pgalloc.h +0 -1
index f868506..1798f25 100644
@@ -12,7 +12,6 @@
 
 #include <asm/tlb.h>
 
-/* FIXME - when we get this compiling */
 /* erm, now that it's compiling, what do we do with it? */
 #define _KERNPG_TABLE 0
 
#2 lore raw
In reply to Nicholas Krause
Quoted 2 lines · Nicholas Krause

Removes a FIXME comment in this file due to it not compiling as it now compiles.

What got fixed?

It doesn't say "FIXME - this doesn't compile".

Quoted 19 lines
---
 arch/m68k/include/asm/sun3_pgalloc.h | 1 -
 1 file changed, 1 deletion(-)
arch/m68k/include/asm/sun3_pgalloc.h +0 -1
index f868506..1798f25 100644
@@ -12,7 +12,6 @@
 
 #include <asm/tlb.h>
 
-/* FIXME - when we get this compiling */
 /* erm, now that it's compiling, what do we do with it? */
 #define _KERNPG_TABLE 0
 
#3 lore raw

-/* FIXME - when we get this compiling */

Quoted 1 line

/* erm, now that it's compiling, what do we do with it? */

What are these two lines for them another compile issue? Cheers Nick

Quoted 31 lines · Finn Thain
Quoted 2 lines · Nicholas Krause

Removes a FIXME comment in this file due to it not compiling as it now compiles.

What got fixed?

It doesn't say "FIXME - this doesn't compile".

Quoted 12 lines
---
 arch/m68k/include/asm/sun3_pgalloc.h | 1 -
 1 file changed, 1 deletion(-)
arch/m68k/include/asm/sun3_pgalloc.h +0 -0
index f868506..1798f25 100644

arch/m68k/include/asm/sun3_pgalloc.h line 17

Quoted 7 lines
arch/m68k/include/asm/sun3_pgalloc.h +0 -1
@@ -12,7 +12,6 @@
 
 #include <asm/tlb.h>
 
-/* FIXME - when we get this compiling */
 /* erm, now that it's compiling, what do we do with it? */
 #define _KERNPG_TABLE 0
 

--

#4 lore raw
In reply to Finn Thain

-/* FIXME - when we get this compiling */

Quoted 1 line

/* erm, now that it's compiling, what do we do with it? */

What are these two lines for them another compile issue? Cheers Nick

Quoted 31 lines · Finn Thain
Quoted 2 lines · Nicholas Krause

Removes a FIXME comment in this file due to it not compiling as it now compiles.

What got fixed?

It doesn't say "FIXME - this doesn't compile".

Quoted 12 lines
---
 arch/m68k/include/asm/sun3_pgalloc.h | 1 -
 1 file changed, 1 deletion(-)
arch/m68k/include/asm/sun3_pgalloc.h +0 -0
index f868506..1798f25 100644

arch/m68k/include/asm/sun3_pgalloc.h line 17

Quoted 7 lines
arch/m68k/include/asm/sun3_pgalloc.h +0 -1
@@ -12,7 +12,6 @@
 
 #include <asm/tlb.h>
 
-/* FIXME - when we get this compiling */
 /* erm, now that it's compiling, what do we do with it? */
 #define _KERNPG_TABLE 0
 

--

#5 lore raw
Quoted 1 line · Nick Krause

What are these two lines for them another compile issue?

I don't see why those two lines are important.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

-/* FIXME - when we get this compiling */
/* erm, now that it's compiling, what do we do with it? */ #define _KERNPG_TABLE 0

Presumably it is the third line that the "FIXME" refers to.

I didn't write this code, but obviously it isn't supposed to be read as

/* FIXME - this comment needs to be deleted */

#6 lore raw

Very well then seems I should resend this patch removing the define line as it seems to have no use
in this file.
Cheers Nick

Quoted 18 lines · Finn Thain
Quoted 1 line · Nick Krause

What are these two lines for them another compile issue?

I don't see why those two lines are important.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

-/* FIXME - when we get this compiling */
/* erm, now that it's compiling, what do we do with it? */ #define _KERNPG_TABLE 0

Presumably it is the third line that the "FIXME" refers to.

I didn't write this code, but obviously it isn't supposed to be read as

/* FIXME - this comment needs to be deleted */

--

#7 lore raw
Quoted 3 lines · Nick Krause

Very well then seems I should resend this patch removing the define line as it seems to have no use
in this file.

Indeed. Thanks in advance!
FYI, the last user of _KERNPG_TABLE was removed in 2.5.18.

Quoted 19 lines

Cheers Nick

Quoted 16 lines · Finn Thain
Quoted 1 line · Nick Krause

What are these two lines for them another compile issue?

I don't see why those two lines are important.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

-/* FIXME - when we get this compiling */
/* erm, now that it's compiling, what do we do with it? */ #define _KERNPG_TABLE 0

Presumably it is the third line that the "FIXME" refers to.

I didn't write this code, but obviously it isn't supposed to be read as

/* FIXME - this comment needs to be deleted */

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds