xen: Introduce 'xen_nopv' to disable PV extensions for HVM guests.
Subsystems (3)
PATCH 1/1 xen: Introduce 'xen_nopv' to disable PV extensions for HVM guests.
From: Konrad Rzeszutek Wilk <[email protected]>
By default when CONFIG_XEN and CONFIG_XEN_PVHVM kernels are run, they will enable the PV extensions (drivers, interrupts, timers, etc) - which is the best option for the majority of
use cases.
However, in some cases (kexec not fully working, benchmarking) we want to disable Xen PV extensions. As such introduce the 'xen_nopv' parameter that will do it.
---
[v2: s/off/xen_nopv/ per Boris Ostrovsky recommendation.] [v3: Add Reviewed-by]
--- Documentation/kernel-parameters.txt | 4 ++++ arch/x86/xen/enlighten.c | 13 +++++++++++++ 2 files changed, 17 insertions(+), 0 deletions(-)
Documentation/kernel-parameters.txt +4 -0
@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]
arch/x86/xen/enlighten.c +13 -0
@@ -1826,8 +1826,19 @@ static void __init xen_hvm_guest_init(void)xen_hvm_init_mmu_ops (); } +static bool xen_nopv = false; +static __init int xen_parse_nopv (char *arg) +{ + xen_nopv = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) { +if (xen_nopv) +return 0 ; +if (xen_pv_domain ())return 0 ;
@@ -1836,6 +1847,8 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (xen_nopv) +return false;if (xen_pv_domain ())return false;if (!xen_hvm_domain ())
Signature · 1 line
1.7.7.6
H. Peter Anvin
reviewerQuoted 42 lines · On 07/11/2014 12:53 PM, [email protected] wrote:
Documentation/kernel-parameters.txt +4
-0@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]arch/x86/xen/enlighten.c +11
-0@@ -1826,8 +1826,19 @@ static void __init xen_hvm_guest_init(void)xen_hvm_init_mmu_ops (); } +static bool xen_nopv = false; +static __init int xen_parse_nopv (char *arg) +{ + xen_nopv = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) { +if (xen_nopv) +return 0 ; +if (xen_pv_domain ())return 0 ;
arch/x86/xen/enlighten.c static uint32_t __init xen_hvm_platform(void) · line 1854
Quoted 8 lines
arch/x86/xen/enlighten.c +2
-0@@ -1836,6 +1847,8 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (xen_nopv) +return false;if (xen_pv_domain ())return false;if (!xen_hvm_domain ())
Any reason to not simply let xen_pv_domain() return false here?
Also, the latter seems a bit odd?
-hpa
H. Peter Anvin
reviewerQuoted 42 lines · On 07/11/2014 12:53 PM, [email protected] wrote:
Documentation/kernel-parameters.txt +4
-0@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]arch/x86/xen/enlighten.c +11
-0@@ -1826,8 +1826,19 @@ static void __init xen_hvm_guest_init(void)xen_hvm_init_mmu_ops (); } +static bool xen_nopv = false; +static __init int xen_parse_nopv (char *arg) +{ + xen_nopv = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) { +if (xen_nopv) +return 0 ; +if (xen_pv_domain ())return 0 ;
arch/x86/xen/enlighten.c static uint32_t __init xen_hvm_platform(void) · line 1854
Quoted 8 lines
arch/x86/xen/enlighten.c +2
-0@@ -1836,6 +1847,8 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (xen_nopv) +return false;if (xen_pv_domain ())return false;if (!xen_hvm_domain ())
Any reason to not simply let xen_pv_domain() return false here?
Also, the latter seems a bit odd?
-hpa