Skip to contentSkip to conversation

staging: iio: adc: ad7192: fix coding style

PATCH In review Marcus Folkesson 2 participants 2 messages Jul 12, 2014 – Jul 13, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: iio: adc: ad7192: fix coding style

Line over 80 characters. This is for Eudyptula Challenge.

---
 drivers/staging/iio/adc/ad7192.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +2 -1
index 83bb44b..c25c9ab 100644
@@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
 	id &= AD7192_ID_MASK;
 
 	if (id != st->devid)
-		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
+		dev_warn(&st->sd.spi->dev,
+			"device ID query failed (0x%X)\n", id);
 
 	switch (pdata->clock_source_sel) {
 	case AD7192_CLK_EXT_MCLK1_2:
Signature · 1 line
2.0.0.rc0
maintainer
#1 lore raw
Quoted 3 lines · Marcus Folkesson

Line over 80 characters. This is for Eudyptula Challenge.

Sorry Marcus,

There is a level of trivial cleanup below which it's not worth taking patches. The 80 character limit is not a hard and fast rule. Here, if this had been picked up during review of the original patch, or was fixed as a part of a more substantial series, I'd have no objection taking it. On it's own it's just too small.

Jonathan

Quoted 19 lines
---
  drivers/staging/iio/adc/ad7192.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +2 -1
index 83bb44b..c25c9ab 100644
@@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
  	id &= AD7192_ID_MASK;
 
  	if (id != st->devid)
-		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
+		dev_warn(&st->sd.spi->dev,
+			"device ID query failed (0x%X)\n", id);
 
  	switch (pdata->clock_source_sel) {
  	case AD7192_CLK_EXT_MCLK1_2: