drm/i915: Fix printing proper min/min/rpe values in debugfs
Subsystems (2)
PATCH 1/1 drm/i915: Fix printing proper min/min/rpe values in debugfs
From: Deepak S <[email protected]>
This was fumbled while trying to use the cached min/min/rpe values in the vlv debugfs code.
This is a regression from
commit 03af20458a57a50735b12c1e3c23abc7ff70c6fa
Author: Ville Syrjälä <[email protected]>
Date: Sat Jun 28 02:03:53 2014 +0300
drm/i915: Use the cached min/min/rpe values in the vlv debugfs code
--- drivers/gpu/drm/i915/i915_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +3 -3
@@ -1116,13 +1116,13 @@ static int i915_frequency_info(struct seq_file *m, void *unused)seq_printf (m,"DDR freq: %d MHz\n" , dev_priv->mem_freq);seq_printf (m,"max GPU freq: %d MHz\n" , - dev_priv->rps.max_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.max_freq));seq_printf (m,"min GPU freq: %d MHz\n" , - dev_priv->rps.min_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.min_freq));seq_printf (m,"efficient (RPe) frequency: %d MHz\n" , - dev_priv->rps.efficient_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.efficient_freq));seq_printf (m,"current GPU freq: %d MHz\n" ,vlv_gpu_freq (dev_priv, (freq_sts >>8 ) &0xff ));
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 7 lines · On Thu, Jul 17, 2014 at 02:21:14PM +0530, [email protected] wrote:
From: Deepak S <[email protected]>
This was fumbled while trying to use the cached min/min/rpe values in the vlv debugfs code.
This is a regression from
Quoted 7 lines
commit
03af20458a57a50735b12c1e3c23abc7ff70c6fa
Author: Ville Syrjälä <[email protected]>
Date: Sat Jun 28 02:03:53 2014 +0300drm/i915: Use the cached min/min/rpe values in the vlv debugfs code
Signed-off-by Deepak S <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 28 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +3
-3@@ -1116,13 +1116,13 @@ static int i915_frequency_info(struct seq_file *m, void *unused)seq_printf (m,"DDR freq: %d MHz\n" , dev_priv->mem_freq);seq_printf (m,"max GPU freq: %d MHz\n" , - dev_priv->rps.max_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.max_freq));seq_printf (m,"min GPU freq: %d MHz\n" , - dev_priv->rps.min_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.min_freq));seq_printf (m,"efficient (RPe) frequency: %d MHz\n" , - dev_priv->rps.efficient_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.efficient_freq));seq_printf (m,"current GPU freq: %d MHz\n" ,vlv_gpu_freq (dev_priv, (freq_sts >>8 ) &0xff ));Signature · 1 line
1.9.1
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Oops, meant to reply-to-all
Quoted 68 lines · Ben Widawsky
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · On Thu, Jul 17, 2014 at 02:21:14PM +0530, [email protected] wrote:
From: Deepak S <[email protected]>
This was fumbled while trying to use the cached min/min/rpe values in the vlv debugfs code.
This is a regression from
commit
03af20458a57a50735b12c1e3c23abc7ff70c6fa
Author: Ville Syrjälä <[email protected]>
Date: Sat Jun 28 02:03:53 2014 +0300Quoted 6 lines
Quoted 3 lines
drm/i915: Use the cached min/min/rpe values in the vlv debugfs code
Signed-off-by Deepak S <[email protected]>Queued for -next, thanks for the patch.
-DanielPatch looks fine to me, and merge is fine, though I'd really prefer we stop improving the debugfs interfaces when the sysfs interface now exists for many releases, and are stable.
If something here is not in sysfs, it should be.
</rant>Quoted 38 lines
Quoted 29 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +3
-3@@ -1116,13 +1116,13 @@ static int i915_frequency_info(struct seq_file *m, void *unused)seq_printf (m,"DDR freq: %d MHz\n" , dev_priv->mem_freq);seq_printf (m,"max GPU freq: %d MHz\n" , - dev_priv->rps.max_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.max_freq));seq_printf (m,"min GPU freq: %d MHz\n" , - dev_priv->rps.min_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.min_freq));seq_printf (m,"efficient (RPe) frequency: %d MHz\n" , - dev_priv->rps.efficient_freq); +vlv_gpu_freq (dev_priv, dev_priv->rps.efficient_freq));seq_printf (m,"current GPU freq: %d MHz\n" ,vlv_gpu_freq (dev_priv, (freq_sts >>8 ) &0xff ));Signature · 1 line
1.9.1Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 1 line
Ben Widawsky, Intel Open Source Technology Center
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx