Staging: vt6655: apply kernel coding style to wCommandTimerWait function
PATCH 1/1 Staging: vt6655: apply kernel coding style to wCommandTimerWait function
Since there is a lot of stuff that need to be changed in order to meet the kernel coding style in wcmd.c file, I've decided to fix function-per-patch. The following changes were made in vCommandTimerWait function:
- Camel case change:
- MSecond ---> msec
- hDdeviceContext ---> private
- pDevice ---> priv
- Removed redundant return
- Removed redndant comment
In future patches, I will also change the function name itself.
--- drivers/staging/vt6655/wcmd.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-)
drivers/staging/vt6655/wcmd.c +7 -13
@@ -281,21 +281,15 @@ s_MgrMakeProbeRequest(return pTxPacket; } -void -vCommandTimerWait ( -void *hDeviceContext, -unsigned int MSecond -) +void vCommandTimerWait (void *private,unsigned int msec) { -PSDevice pDevice = (PSDevice )hDeviceContext; +PSDevice priv = (PSDevice )private; -init_timer (&pDevice->sTimerCommand); - pDevice->sTimerCommand.data = (unsigned long ) pDevice; - pDevice->sTimerCommand.function = (TimerFunction )vCommandTimer; -// RUN_AT :1 msec ~= (HZ/1024) - pDevice->sTimerCommand.expires = (unsigned int )RUN_AT ((MSecond *HZ ) >>10 ); -add_timer (&pDevice->sTimerCommand); -return ; +init_timer (&priv->sTimerCommand); + priv->sTimerCommand.data = (unsigned long )priv; + priv->sTimerCommand.function = (TimerFunction )vCommandTimer; + priv->sTimerCommand.expires = (unsigned int )RUN_AT ((msec *HZ ) >>10 ); +add_timer (&priv->sTimerCommand); }void
Signature · 1 line
1.7.9.5
Greg KH
maintainerQuoted 4 lines · Igor Bezukh
Since there is a lot of stuff that need to be changed in order to meet the kernel coding style in
wcmd.cfile, I've decided to fix function-per-patch. The following changes were made in vCommandTimerWait function:
Quoted 8 lines
- Camel case change:
- MSecond ---> msec
- hDdeviceContext ---> private
- pDevice ---> priv
- Removed redundant return
- Removed redndant commentIn future patches, I will also change the function name itself.
A better way to do this, that is easier to review, is to do, on a per-file basis, one thing, like "remove redundant return", or "remove unneeded comments".
Having to review all of these changes at once, even for something as "small" as a single function, is much harder than making sure you only do one thing, and do it all at once.
So, can you break it up in this way instead?
thanks,
greg k-h