Skip to contentSkip to conversation

pcm: route: Use get/put labels for all 3 byte formats

PATCH New Takashi Iwai 1 participant 1 message Jul 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcm: route: Use get/put labels for all 3 byte formats

So far, use_getput flag is set only when the src or dest format is 24bit physical width. But, also 18 and 20 bit physical width formats should set the flag, too. This patch makes the check broader to cover all 3 bytes formats.

---
 src/pcm/pcm_route.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
src/pcm/pcm_route.c +4 -2
index 2f0be38b1906..72c198cb25d2 100644
@@ -644,8 +644,10 @@ static int snd_pcm_route_hw_params(snd_pcm_t *pcm, snd_pcm_hw_params_t * params)
 	}
 	if (err < 0)
 		return err;
-	route->params.use_getput = snd_pcm_format_physical_width(src_format) == 24 ||
-		snd_pcm_format_physical_width(dst_format) == 24;
+	/* 3 bytes formats? */
+	route->params.use_getput =
+		(snd_pcm_format_physical_width(src_format) + 7) / 3 == 3 ||
+		(snd_pcm_format_physical_width(dst_format) + 7) / 3 == 3;
 	route->params.get_idx = snd_pcm_linear_get_index(src_format, SND_PCM_FORMAT_S16);
 	route->params.put_idx = snd_pcm_linear_put32_index(SND_PCM_FORMAT_S32, dst_format);
 	route->params.conv_idx = snd_pcm_linear_convert_index(src_format, dst_format);
Signature · 1 line
2.0.1