Skip to contentSkip to conversation

ALSA: hda - add PCI IDs for Intel Braswell

PATCH In review [email protected] 2 participants 7 messages Jul 23, 2014 – Jul 25, 2014 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ALSA: hda - add PCI IDs for Intel Braswell

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +3 -0
index 387fc73..f758729 100644
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
Signature · 1 line
1.9.1
#1 lore raw

PATCH 2/2 ALSA: hda - add codec ID for Braswell display audio codec

From: Libin Yang <[email protected]>

This patch adds codec ID (0x80862883) and module alias for Braswell display codec.

---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
index a21090b..36badba 100644
@@ -3356,6 +3356,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x80862808, .name = "Broadwell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862882, .name = "Valleyview2 HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x80862883, .name = "Braswell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
@@ -3415,6 +3416,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862807");
 MODULE_ALIAS("snd-hda-codec-id:80862808");
 MODULE_ALIAS("snd-hda-codec-id:80862880");
 MODULE_ALIAS("snd-hda-codec-id:80862882");
+MODULE_ALIAS("snd-hda-codec-id:80862883");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
 
 MODULE_LICENSE("GPL");
Signature · 1 line
1.9.1
#2 lore raw
In reply to [email protected]

At Wed, 23 Jul 2014 08:55:37 +0800,

Quoted 15 lines · [email protected] wrote:

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +0 -0
index 387fc73..f758729 100644

sound/pci/hda/hda_intel.c static const struct pci_device_id azx_ids[] = { · line 2022

Quoted 6 lines
sound/pci/hda/hda_intel.c +3 -0
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },

Doesn't really this new chip support runtime PM?

Takashi

Quoted 6 lines
sound/pci/hda/hda_intel.c +0 -0
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
Signature · 1 line
1.9.1
#3 lore raw

Hi Takashi,

Quoted 28 lines

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Wednesday, July 23, 2014 6:08 PM
To: Yang, Libin
Cc: [email protected]; Lin, Mengdong
Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell

At Wed, 23 Jul 2014 08:55:37 +0800,

Quoted 15 lines · [email protected] wrote:

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +0 -0
index 387fc73..f758729 100644

sound/pci/hda/hda_intel.c static const struct pci_device_id azx_ids[] = { · line 2019

Quoted 3 lines
sound/pci/hda/hda_intel.c +0 -0
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH |

AZX_DCAPS_INTEL_PCH_NOPM },

Quoted 6 lines

sound/pci/hda/hda_intel.c static const struct pci_device_id azx_ids[] = {

Quoted 3 lines
sound/pci/hda/hda_intel.c +3 -0
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH |

AZX_DCAPS_INTEL_PCH_NOPM },

Doesn't really this new chip support runtime PM?

Braswell is more like Baytrail, which doesn't support runtime PM.

Anyway, I will test the pm-runtime on braswell and update the result later.

Quoted 10 lines

Takashi

Quoted 6 lines
sound/pci/hda/hda_intel.c +0 -1
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
--

1.9.1

Regards,
Libin

#4 lore raw

Hi Takashi,

After checking the HW, the HDMI audio codec doesn't support EPSS. If we force it to support runtime PM, there is risk. Besides, as the codec doesn't support EPSS, if we want to support runtime PM, simply add the AZX_DCAPS_PM_RUNTIME flag doesn't help. We must think out a method to ensure the driver enter pm runtime even the codec doesn't support.

What do you think whether we can merge the patch firstly, and on the meantime, I will ask our QA team to do a full test with pm runtime enabled and decide the next step?

Regards,
Libin

Quoted 61 lines

-----Original Message-----
From: Yang, Libin
Sent: Thursday, July 24, 2014 11:57 AM
To: Takashi Iwai
Cc: [email protected]; Lin, Mengdong
Subject: RE: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell

Hi Takashi,

Quoted 28 lines

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Wednesday, July 23, 2014 6:08 PM
To: Yang, Libin
Cc: [email protected]; Lin, Mengdong
Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell

At Wed, 23 Jul 2014 08:55:37 +0800,

Quoted 15 lines · [email protected] wrote:

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +0 -0
index 387fc73..f758729 100644

sound/pci/hda/hda_intel.c static const struct pci_device_id azx_ids[] = { · line 2019

Quoted 3 lines
sound/pci/hda/hda_intel.c +0 -0
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH |

AZX_DCAPS_INTEL_PCH_NOPM },

Quoted 6 lines

sound/pci/hda/hda_intel.c static const struct pci_device_id azx_ids[] = {

Quoted 3 lines
sound/pci/hda/hda_intel.c +3 -0
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH |

AZX_DCAPS_INTEL_PCH_NOPM },

Doesn't really this new chip support runtime PM?

Braswell is more like Baytrail, which doesn't support runtime PM.

Anyway, I will test the pm-runtime on braswell and update the result later.

Quoted 10 lines

Takashi

Quoted 6 lines
sound/pci/hda/hda_intel.c +0 -1
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
--

1.9.1

Regards,
Libin

#5 lore raw

At Thu, 24 Jul 2014 12:59:55 +0000,

Quoted 4 lines · Libin

Hi Takashi,

After checking the HW, the HDMI audio codec doesn't support EPSS. If we force it to support runtime PM, there is risk. Besides, as the codec doesn't support EPSS, if we want to support runtime PM, simply add the AZX_DCAPS_PM_RUNTIME flag doesn't help. We must think out a method to ensure the driver enter pm runtime even the codec doesn't support.

Wait, is the controller for the generic codecs or dedicated to the embedded HDMI? In the latter case, AZX_DCAPS_INTEL_PCM_NOPM is anyway wrong. For HDMI, we use different flags.

Takashi

#6 lore raw

Hi Takashi,

Quoted 13 lines

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Thursday, July 24, 2014 9:21 PM
To: Yang, Libin
Cc: '[email protected]'; Lin, Mengdong
Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell

At Thu, 24 Jul 2014 12:59:55 +0000,

Quoted 4 lines · Libin

Hi Takashi,

After checking the HW, the HDMI audio codec doesn't support EPSS. If we

Quoted 8 lines

force it to support runtime PM, there is risk. Besides, as the codec doesn't support EPSS, if we want to support runtime PM, simply add the AZX_DCAPS_PM_RUNTIME flag doesn't help. We must think out a method to ensure the driver enter pm runtime even the codec doesn't support.

Wait, is the controller for the generic codecs or dedicated to the embedded HDMI? In the latter case, AZX_DCAPS_INTEL_PCM_NOPM is anyway wrong. For HDMI, we use different flags.

OK, I see. I will add the flags and have a test.

Quoted 3 lines

Takashi