microblaze: Add comment for defines
PATCH 1/1 microblaze: Add comment for defines
This adds a comment for and removes a fix me by labeling these defines as memory cache definitions.
Signed-off-by Nicholas Krause <[email protected]>
--- arch/microblaze/include/asm/pvr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/microblaze/include/asm/pvr.h +1 -1
@@ -186,7 +186,7 @@ struct pvr_s {#define PVR_DCACHE_USE_FSL (_pvr) (_pvr.pvr[5] & PVR5_DCACHE_USE_FSL_MASK)#define PVR_DCACHE_ALLOW_WR (_pvr) \ (_pvr.pvr[5] & PVR5_DCACHE_ALLOW_WR_MASK) -/* FIXME two shifts on one line needs any comment */ +/* memory caches */ #define PVR_DCACHE_LINE_LEN (_pvr) \ (1 << ((_pvr.pvr[5] & PVR5_DCACHE_LINE_LEN_MASK) >> 21))#define PVR_DCACHE_BYTE_SIZE (_pvr) \
Signature · 1 line
1.9.1
Quoted 13 lines · Nicholas Krause
This adds a comment for and removes a fix me by labeling these defines as memory cache definitions.
Signed-off-by Nicholas Krause <[email protected]>--- arch/microblaze/include/asm/pvr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/microblaze/include/asm/pvr.h +0
-0
arch/microblaze/include/asm/pvr.h struct pvr_s { · line 189
Quoted 5 lines
arch/microblaze/include/asm/pvr.h +1
-1@@ -186,7 +186,7 @@ struct pvr_s {#define PVR_DCACHE_USE_FSL (_pvr) (_pvr.pvr[5] & PVR5_DCACHE_USE_FSL_MASK)#define PVR_DCACHE_ALLOW_WR (_pvr) \ (_pvr.pvr[5] & PVR5_DCACHE_ALLOW_WR_MASK) -/* FIXME two shifts on one line needs any comment */ +/* memory caches */
"two shifts on one line needs any comment"
You are not providing the comment asked for. The FIXME requests a comment explaining why the double shift is needed, not just a random comment like the one you provided that doesn't explain anything.
Guenter
Quoted 4 lines
arch/microblaze/include/asm/pvr.h +0
-0#define PVR_DCACHE_LINE_LEN (_pvr) \ (1 << ((_pvr.pvr[5] & PVR5_DCACHE_LINE_LEN_MASK) >> 21))#define PVR_DCACHE_BYTE_SIZE (_pvr) \