Skip to contentSkip to conversation

staging: dgnc: remove commented code

PATCH In review Seunghun Lee 2 participants 2 messages Jul 25, 2014 – Jul 29, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgnc: remove commented code

This patch removes commented code in dgnc driver.

CC Lidza Louina <[email protected]>
CC Mark Hounschell <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c   |    5 +-
 drivers/staging/dgnc/dgnc_trace.c |  123 -------------------------------------
 drivers/staging/dgnc/dgnc_trace.h |   10 ---
 drivers/staging/dgnc/dgnc_tty.c   |   18 ------
 drivers/staging/dgnc/digi.h       |    1 -
 5 files changed, 1 insertion(+), 156 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +1 -4
index 8e265c2..4b65306 100644
@@ -1046,10 +1046,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
 	 * I believe this is a BUG in this UART.
 	 * So for now, we will leave the code #ifdef'ed out...
 	 */
-#if 0
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR),
-					 &ch->ch_cls_uart->isr_fcr);
-#endif
+
 	udelay(10);
 }
 
drivers/staging/dgnc/dgnc_trace.c +0 -123

129 lines not on this page · raw message

drivers/staging/dgnc/dgnc_trace.h +0 -10
index efed88a..4f4e2b9 100644
@@ -28,16 +28,6 @@
 
 #include "dgnc_driver.h"
 
-#if 0
-
-# if !defined(TRC_TO_KMEM) && !defined(TRC_TO_CONSOLE)
-   void dgnc_tracef(const char *fmt, ...);
-# else
-   void dgnc_tracef(const char *fmt, ...);
-# endif
-
-#endif
-
 void dgnc_tracer_free(void);
 
 #endif
drivers/staging/dgnc/dgnc_tty.c +0 -18
index 714a069..453efce 100644
@@ -2107,24 +2107,6 @@ static int dgnc_tty_write(struct tty_struct *tty,
 		ch->ch_w_head = head;
 	}
 
-#if 0
-	/*
-	 * If this is the print device, and the
-	 * printer is still on, we need to turn it
-	 * off before going idle.
-	 */
-	if (count == orig_count) {
-		if ((un->un_type == DGNC_PRINT) && (ch->ch_flags & CH_PRON)) {
-			head &= tmask;
-			ch->ch_w_head = head;
-			dgnc_wmove(ch, ch->ch_digi.digi_offstr,
-				(int) ch->ch_digi.digi_offlen);
-			head = (ch->ch_w_head) & tmask;
-			ch->ch_flags &= ~CH_PRON;
-		}
-	}
-#endif
-
 	/* Update printer buffer empty time. */
 	if ((un->un_type == DGNC_PRINT) && (ch->ch_digi.digi_maxcps > 0)
 	    && (ch->ch_digi.digi_bufsize > 0)) {
drivers/staging/dgnc/digi.h +0 -1
index 282908f..2527918 100644
@@ -402,7 +402,6 @@ struct digi_getcounter {
 
 #define EV_IPU		0x0010		/* !<Input paused unconditionally by user */
 #define EV_IPS		0x0020		/* !<Input paused by high/low water marks */
-/* #define EV_IPH	0x0040		//!<Input paused w/ hardware */
 #define EV_IPA		0x0400		/* !<Input paused by pattern alarm module */
 
 #define EV_TXB		0x0040		/* !<Transmit break pending */
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 18 lines · Seunghun Lee

This patch removes commented code in dgnc driver.

CC Lidza Louina <[email protected]>
CC Mark Hounschell <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c   |    5 +-
 drivers/staging/dgnc/dgnc_trace.c |  123 -------------------------------------
 drivers/staging/dgnc/dgnc_trace.h |   10 ---
 drivers/staging/dgnc/dgnc_tty.c   |   18 ------
 drivers/staging/dgnc/digi.h       |    1 -
 5 files changed, 1 insertion(+), 156 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -0
index 8e265c2..4b65306 100644

drivers/staging/dgnc/dgnc_cls.c static void cls_flush_uart_read(struct channel_t *ch) · line 1048

Quoted 3 lines
drivers/staging/dgnc/dgnc_cls.c +0 -0
@@ -1046,10 +1046,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
 	 * I believe this is a BUG in this UART.
 	 * So for now, we will leave the code #ifdef'ed out...
 	 */

The comment above relates to the deleted code, so it should be updated accordingly.

Quoted 7 lines
drivers/staging/dgnc/dgnc_cls.c +1 -4
-#if 0
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR),
-					 &ch->ch_cls_uart->isr_fcr);
-#endif
+
 	udelay(10);
 }