Skip to contentSkip to conversation

pulseaudio: Customize pulseaudio configuration for i.MX platforms

PATCH Superseded Jun Zhu 5 participants 13 messages Jul 29, 2014 – Jul 31, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
author
#3 lore raw

PATCH 3/3 pulseaudio: Fix no sound issue after plugin/out headphone

In reply to Jun Zhu

This issue found on the i.MX6 testing: when switch audio output between headphone and speaker, sometimes it found no sound when plugin headphone.
Root cause is the the core-subscribe.c has a defer queue for audio sink's switch event and stores the status in database. Because it is a defer queue, sometimes the stored status is changed not as user expected.

---
 ...here-is-no-sound-after-plugin-plugout-hea.patch |  127 ++++++++++++++++++++
 .../pulseaudio/pulseaudio_5.0.bbappend             |    1 +
 2 files changed, 128 insertions(+)
 create mode 100644 recipes-multimedia/pulseaudio/pulseaudio/0002-Fix-issue-there-is-no-sound-after-plugin-plugout-hea.patch
recipes-multimedia/pulseaudio/pulseaudio/0002-Fix-issue-there-is-no-sound-after-plugin-plugout-hea.patch new file +127 -0
new file mode 100644
index 0000000..0d4d73a
@@ -0,0 +1,127 @@
+From 7dfff7e62296779dca9831598af082ee72bfed41 Mon Sep 17 00:00:00 2001
+From: Shengjiu Wang <[email protected]>
+Date: Mon, 5 May 2014 14:21:16 +0800
+Subject: [PATCH] Fix issue: there is no sound after plugin/plugout headphone
+
+In default config, when switching headphone with speaker, the unused one will
+be switch off. And pulseaudio will store the setting in the database for
+restore later, when switch back to the output path.
+But the core-subscribe.c has a defer queue for these events, like sink|new,
+sink|change, which will read the current switch status and store it in
+the database. Because it is a defer queue, sometimes the stored status is
+changed not as user's requirement. below is the call flow.
+
+init:
+        store on for speaker to database.
+        store on for headphone to database.
+---Activating analog-output-speaker
+	switch on speaker
+	switch off headphone
+----headphone plugin
+   ---analog-output-speaker status no
+   ---Activating analog-output
+      Queued event (SINK|CHANGE|0)
+      switch off speaker
+      switch off headphone
+   ---analog-output-headphone status yes
+   ---Activating analog-output-headphone
+      switch off speaker
+      switch off headphone
+      Dispatched event (SINK|CHANGE|0)
+       store off for headphone to database.
+
+Meantime the root cause is not found, a workaround is used by changing the
+configure file.
+
+Another change is remain the volume same as the asound.state.
+
+Upstream Status: N/A
+  - It is i.Mx specific 
+
+Signed-off-by: Shengjiu Wang <[email protected]>
+---
+ .../alsa/mixer/paths/analog-output-headphones.conf |    8 ++++----
+ .../alsa/mixer/paths/analog-output-speaker.conf    |    8 ++++----
+ src/modules/alsa/mixer/paths/analog-output.conf    |    8 ++++----
+ 3 files changed, 12 insertions(+), 12 deletions(-)
+
+diff --git a/src/modules/alsa/mixer/paths/analog-output-headphones.conf b/src/modules/alsa/mixer/paths/analog-output-headphones.conf
+index b1a349a..7bfa79e 100644
+--- a/src/modules/alsa/mixer/paths/analog-output-headphones.conf
++++ b/src/modules/alsa/mixer/paths/analog-output-headphones.conf
+@@ -63,8 +63,8 @@ volume = off
+ 
+ [Element Headphone]
+ required-any = any
+-switch = mute
+-volume = merge
++switch = on
++volume = ignore
+ override-map.1 = all
+ override-map.2 = all-left,all-right
+ 
+@@ -86,8 +86,8 @@ switch = mute
+ volume = zero
+ 
+ [Element Speaker]
+-switch = off
+-volume = off
++switch = on
++volume = ignore
+ 
+ [Element Desktop Speaker]
+ switch = off
+diff --git a/src/modules/alsa/mixer/paths/analog-output-speaker.conf b/src/modules/alsa/mixer/paths/analog-output-speaker.conf
+index d79fad1..eae40a0 100644
+--- a/src/modules/alsa/mixer/paths/analog-output-speaker.conf
++++ b/src/modules/alsa/mixer/paths/analog-output-speaker.conf
+@@ -62,8 +62,8 @@ volume = off
+ ; This profile path is intended to control the speaker, let's mute headphones
+ ; else there will be a spike when plugging in headphones
+ [Element Headphone]
+-switch = off
+-volume = off
++switch = on
++volume = ignore
+ 
+ [Element Headphone2]
+ switch = off
+@@ -71,8 +71,8 @@ volume = off
+ 
+ [Element Speaker]
+ required-any = any
+-switch = mute
+-volume = merge
++switch = on
++volume = ignore
+ override-map.1 = all
+ override-map.2 = all-left,all-right
+ 
+diff --git a/src/modules/alsa/mixer/paths/analog-output.conf b/src/modules/alsa/mixer/paths/analog-output.conf
+index 3a552c9..bd5c12b 100644
+--- a/src/modules/alsa/mixer/paths/analog-output.conf
++++ b/src/modules/alsa/mixer/paths/analog-output.conf
+@@ -53,16 +53,16 @@ switch = off
+ ; headphones. But it should not hurt if we leave the headphone jack
+ ; enabled nonetheless.
+ [Element Headphone]
+-switch = mute
+-volume = zero
++switch = on
++volume = ignore
+ 
+ [Element Headphone2]
+ switch = mute
+ volume = zero
+ 
+ [Element Speaker]
+-switch = mute
+-volume = off
++switch = on
++volume = ignore
+ 
+ [Element Desktop Speaker]
+ switch = mute
+-- 
+1.7.9.5
+
recipes-multimedia/pulseaudio/pulseaudio_5.0.bbappend +1 -0
index 4ea4921..5b2b1a9 100644
@@ -6,6 +6,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 SRC_URI_append = " file://daemon.conf \
         file://default.pa \
         file://0001-Fix-pulseaudio-mutex-issue-when-do-pause-in-gstreame.patch \
+        file://0002-Fix-issue-there-is-no-sound-after-plugin-plugout-hea.patch \
 "
 
 do_install_append() {
Signature · 1 line
1.7.9.5

Jun Zhu

author
#0 lore raw

PATCH 1/3 pulseaudio: Customize pulseaudio configuration for i.MX platforms

on i.MX seriese boards, some pulseaudio defualt setting should be modified to improve the user experience:
- Daemon's exit_idle_time: set value as -1 to make pulseaudio service
never be terminated by any user-space app.
- Resample mothed: switch to the build-in ffmpeg to improve the
sound quality.
- Flat_Volumes: set value as "no" to align with the normal use case.

These customized configuration would be installed to overwrite the original version.

---
 .../pulseaudio/pulseaudio/daemon.conf              |   87 ++++++++++
 .../pulseaudio/pulseaudio/default.pa               |  170 ++++++++++++++++++++
 .../pulseaudio/pulseaudio_5.0.bbappend             |   23 +++
 3 files changed, 280 insertions(+)
 create mode 100644 recipes-multimedia/pulseaudio/pulseaudio/daemon.conf
 create mode 100644 recipes-multimedia/pulseaudio/pulseaudio/default.pa
 create mode 100644 recipes-multimedia/pulseaudio/pulseaudio_5.0.bbappend
recipes-multimedia/pulseaudio/pulseaudio/daemon.conf new file +87 -0
new file mode 100644
index 0000000..54854eb
@@ -0,0 +1,87 @@
+# This file is part of PulseAudio.
+#
+# PulseAudio is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# PulseAudio is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with PulseAudio; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
+# USA.
+
+## Configuration file for the PulseAudio daemon. See pulse-daemon.conf(5) for
+## more information. Default values are commented out.  Use either ; or # for
+## commenting.
+
+; daemonize = no
+; fail = yes
+; allow-module-loading = yes
+; allow-exit = yes
+; use-pid-file = yes
+; system-instance = no
+; local-server-type = user
+; enable-shm = yes
+; shm-size-bytes = 0 # setting this 0 will use the system-default, usually 64 MiB
+; lock-memory = no
+; cpu-limit = no
+
+; high-priority = yes
+; nice-level = -11
+
+; realtime-scheduling = yes
+; realtime-priority = 5
+
+exit-idle-time = -1
+; scache-idle-time = 20
+
+; dl-search-path = (depends on architecture)
+
+; load-default-script-file = yes
+; default-script-file = /etc/pulse/default.pa
+
+; log-target = auto
+; log-level = notice
+; log-meta = no
+; log-time = no
+; log-backtrace = 0
+
+resample-method = ffmpeg
+; enable-remixing = yes
+; enable-lfe-remixing = no
+
+flat-volumes = no
+
+; rlimit-fsize = -1
+; rlimit-data = -1
+; rlimit-stack = -1
+; rlimit-core = -1
+; rlimit-as = -1
+; rlimit-rss = -1
+; rlimit-nproc = -1
+; rlimit-nofile = 256
+; rlimit-memlock = -1
+; rlimit-locks = -1
+; rlimit-sigpending = -1
+; rlimit-msgqueue = -1
+; rlimit-nice = 31
+; rlimit-rtprio = 9
+; rlimit-rttime = 1000000
+
+; default-sample-format = s16le
+; default-sample-rate = 44100
+; alternate-sample-rate = 48000
+; default-sample-channels = 2
+; default-channel-map = front-left,front-right
+
+; default-fragments = 4
+; default-fragment-size-msec = 25
+
+; enable-deferred-volume = yes
+; deferred-volume-safety-margin-usec = 8000
+; deferred-volume-extra-delay-usec = 0
recipes-multimedia/pulseaudio/pulseaudio/default.pa new file +170 -0

170 lines not on this page · raw message

recipes-multimedia/pulseaudio/pulseaudio_5.0.bbappend new file +23 -0
new file mode 100644
index 0000000..993c340
@@ -0,0 +1,23 @@
+# As it can not overwrite the version in the layer meta-fsl-arm, we have to use
+#   another file extension for new patch to the append in the meta-fsl-arm
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+SRC_URI_append = " file://daemon.conf \
+        file://default.pa \
+"
+
+do_install_append() {
+    # FIXME: Install the customized pulseaudio damon setting to overwrite the default one
+    install -m 0644 ${WORKDIR}/daemon.conf ${D}${sysconfdir}/pulse/daemon.conf
+    install -m 0644 ${WORKDIR}/default.pa ${D}${sysconfdir}/pulse/default.pa
+
+    #FIXME: Remove the kde desktop, because there are two destop in default
+    #        (pulseaudio-kde.destop, pulseaudio.destop), then the pulseaudio server
+    #        will be started twice, pulseaudio will have issue to switch to default input/output.
+    if [ -e ${D}${sysconfdir}/xdg/autostart/pulseaudio-kde.desktop ]
+    then
+        rm ${D}${sysconfdir}/xdg/autostart/pulseaudio-kde.desktop
+    fi
+}
+
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/3 pulseaudio: Fix mutext issue when do pause in gstreamer

Pulseaudio crashes when other program using sound:
Assertion 'pthread_mutex_unlock(&m->mutex) == 0' failed at pulsecore/mutex-posix.c:106, function pa_mutex_unlock().

Disable PTHREAD priority inheritance feature is the easiest workaround solutions for this issue.

---
 ...dio-mutex-issue-when-do-pause-in-gstreame.patch |   34 ++++++++++++++++++++
 .../pulseaudio/pulseaudio_5.0.bbappend             |    1 +
 2 files changed, 35 insertions(+)
 create mode 100644 recipes-multimedia/pulseaudio/pulseaudio/0001-Fix-pulseaudio-mutex-issue-when-do-pause-in-gstreame.patch
recipes-multimedia/pulseaudio/pulseaudio/0001-Fix-pulseaudio-mutex-issue-when-do-pause-in-gstreame.patch new file +34 -0
new file mode 100644
index 0000000..67bc46f
@@ -0,0 +1,34 @@
+From c21e24f5c53e81fc715905c54a6c82b69e397e63 Mon Sep 17 00:00:00 2001
+From: "shengjiu.wang" <[email protected]>
+Date: Thu, 3 Apr 2014 14:22:02 +0800
+Subject: [PATCH] Fix pulseaudio mutex issue when do pause in gstreamer
+
+The error log is "Assertion 'pthread_mutex_unlock(&m->mutex) == 0'
+failed at pulsecore/mutex-posix.c:106, function pa_mutex_unlock(). Aborting"
+
+This fix is a workaround base on the solution from this link "
+https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/932096"
+
+Upstream status: N/A
+  - It is i.MX specific
+
+Signed-off-by: shengjiu.wang <[email protected]>
+---
+ src/pulsecore/mutex-posix.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/pulsecore/mutex-posix.c b/src/pulsecore/mutex-posix.c
+index 36c2787..d592501 100644
+--- a/src/pulsecore/mutex-posix.c
++++ b/src/pulsecore/mutex-posix.c
+@@ -30,6 +30,7 @@
+ #include <pulsecore/macro.h>
+ 
+ #include "mutex.h"
++#undef HAVE_PTHREAD_PRIO_INHERIT
+ 
+ struct pa_mutex {
+     pthread_mutex_t mutex;
+-- 
+1.7.9.5
+
recipes-multimedia/pulseaudio/pulseaudio_5.0.bbappend +1 -0
index 993c340..4ea4921 100644
@@ -5,6 +5,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
 SRC_URI_append = " file://daemon.conf \
         file://default.pa \
+        file://0001-Fix-pulseaudio-mutex-issue-when-do-pause-in-gstreame.patch \
 "
 
 do_install_append() {
Signature · 1 line
1.7.9.5
#5 lore raw
In reply to Jun Zhu

Hello Jun,

Quoted 8 lines · Jun Zhu

on i.MX seriese boards, some pulseaudio defualt setting should be modified to improve the user experience:
- Daemon's exit_idle_time: set value as -1 to make pulseaudio service
never be terminated by any user-space app.
- Resample mothed: switch to the build-in ffmpeg to improve the
sound quality.
- Flat_Volumes: set value as "no" to align with the normal use case.

Quoted 4 lines

These customized configuration would be installed to overwrite the original version.

Your subject say's i.MX. Does it imply you tested it in all i.MX platforms? Or this has been tested in i.MX6 only?

You seem to rely in ffmpeg, I fear this has license implications, does it not?

You patch needs to be adjusted to not include this files for other machines. Please rework it.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw

Re: [meta-fsl-arm][PATCH 2/3] pulseaudio: Fix mutext issue when do pause in gstreamer

In reply to Jun Zhu
Quoted 8 lines · Jun Zhu

Pulseaudio crashes when other program using sound:
Assertion 'pthread_mutex_unlock(&m->mutex) == 0' failed at pulsecore/mutex-posix.c:106, function pa_mutex_unlock().

Disable PTHREAD priority inheritance feature is the easiest workaround solutions for this issue.

I think you can accomplish the same using:

pulseaudio_cv_PTHREAD_PRIO_INHERIT=no

in CACHED_CONFIGUREVARS as:

CACHED_CONFIGUREVARS_append_mx6 = "
pulseaudio_cv_PTHREAD_PRIO_INHERIT=no"

Can you give it a try?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#4 lore raw

Re: [meta-fsl-arm][PATCH 3/3] pulseaudio: Fix no sound issue after plugin/out headphone

In reply to Jun Zhu
Quoted 9 lines · Jun Zhu

This issue found on the i.MX6 testing: when switch audio output between headphone and speaker, sometimes it found no sound when plugin headphone.
Root cause is the the core-subscribe.c has a defer queue for audio sink's switch event and stores the status in database. Because it is a defer queue, sometimes the stored status is changed not as user expected.

The patch needs to be included only for i.MX6.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#12 lore raw
In reply to Jun Zhu
Quoted 1 line · Jun Zhu

on i.MX seriese boards, some pulseaudio defualt setting should be

when you send v2, please not the typo "seriese"

Quoted 4 lines

modified to improve the user experience:
- Daemon's exit_idle_time: set value as -1 to make pulseaudio service
never be terminated by any user-space app.
- Resample mothed: switch to the build-in ffmpeg to improve the

typo "mothed"

Daiane

#6 lore raw
In reply to Otavio Salvador

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Otavio Salvador
Sent: Tuesday, July 29, 2014 9:38 PM
To: Zhu Jun-R01007
Cc: [email protected]
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 1/3] pulseaudio: Customize pulseaudio configuration for i.MX platforms

Hello Jun,

Quoted 8 lines · Jun Zhu

on i.MX seriese boards, some pulseaudio defualt setting should be modified to improve the user experience:
- Daemon's exit_idle_time: set value as -1 to make pulseaudio service
never be terminated by any user-space app.
- Resample mothed: switch to the build-in ffmpeg to improve the sound
quality.
- Flat_Volumes: set value as "no" to align with the normal use case.

Quoted 4 lines

These customized configuration would be installed to overwrite the original version.

Your subject say's i.MX. Does it imply you tested it in all i.MX platforms? Or this has been tested in i.MX6 only? [Zhu Jun-R01007] It is only tested on i.Mx6, so I will adjust it in Patch v2

You seem to rely in ffmpeg, I fear this has license implications, does it not?
[Zhu Jun-R01007] PulseAudio has a built-in resample library from ffmpeg and code can be found under pulseaudio-5.0/src/pulsecore/ffmpeg. So it may not causes the license problem.

You patch needs to be adjusted to not include this files for other machines. Please rework it.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#7 lore raw

On Wed, Jul 30, 2014 at 5:08 AM, [email protected] <[email protected]> wrote:
...

Quoted 2 lines

Your subject say's i.MX. Does it imply you tested it in all i.MX platforms? Or this has been tested in i.MX6 only? [Zhu Jun-R01007] It is only tested on i.Mx6, so I will adjust it in Patch v2

Ok. Please rework it so it applies /only/ for the referred platform and not all others.

Quoted 2 lines

You seem to rely in ffmpeg, I fear this has license implications, does it not?
[Zhu Jun-R01007] PulseAudio has a built-in resample library from ffmpeg and code can be found under pulseaudio-5.0/src/pulsecore/ffmpeg. So it may not causes the license problem.

Please give it a test without ffmpeg compiled to be sure of that. Does the sound works in a system without ffmpeg?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#8 lore raw

Hi, Otavio,

PulseAudio's core contains the several algorithms for the resampler, and ffmpeg resample algorithm is one of them. So it can choose the algorithm by the Daemon configuration file

There is no configure option to disable ffmpeg resample when do the pulseaudio build. So we have to modify the source code to disable it. And the source code for ffmpeg resamplpe (src/pulsecore/ffmpeg) has the GNU Lesser General License.

Regards,
Jun Zhu

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Otavio Salvador
Sent: Wednesday, July 30, 2014 8:45 PM
To: Zhu Jun-R01007
Cc: [email protected]
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 1/3] pulseaudio: Customize pulseaudio configuration for i.MX platforms

On Wed, Jul 30, 2014 at 5:08 AM, [email protected] <[email protected]> wrote:
...

Quoted 3 lines

Your subject say's i.MX. Does it imply you tested it in all i.MX platforms? Or this has been tested in i.MX6 only? [Zhu Jun-R01007] It is only tested on i.Mx6, so I will adjust it in
Patch v2

Ok. Please rework it so it applies /only/ for the referred platform and not all others.

Quoted 2 lines

You seem to rely in ffmpeg, I fear this has license implications, does it not?
[Zhu Jun-R01007] PulseAudio has a built-in resample library from ffmpeg and code can be found under pulseaudio-5.0/src/pulsecore/ffmpeg. So it may not causes the license problem.

Please give it a test without ffmpeg compiled to be sure of that. Does the sound works in a system without ffmpeg?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#9 lore raw
Quoted 1 line · On Thu, Jul 31, 2014 at 6:42 AM, [email protected] <[email protected]>…

PulseAudio's core contains the several algorithms for the resampler, and ffmpeg resample algorithm is one of them. So it can choose the algorithm by the Daemon configuration file

Yes, I got this.

My question is if the audio works

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#10 lore raw
Quoted 7 lines · Otavio Salvador
Quoted 1 line · On Thu, Jul 31, 2014 at 6:42 AM, [email protected] <[email protected]>…

PulseAudio's core contains the several algorithms for the resampler, and ffmpeg resample algorithm is one of them. So it can choose the algorithm by the Daemon configuration file

Yes, I got this.

My question is if the audio works

(oops, send button too soon) ... works in case the system does not have ffmpeg support? Does it uses a fallback mechanism? This needs testing.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#11 lore raw

Otavio,

We build two images for testing, one is without ffmpeg. That is what our prebuilts have. Second image is internal only is one with ffmpeg (we use it to test license restricted component combinations like chromium). Both images use same pulse audio configuration.

So pulseaudio can be configured with a pulse audio ffmpeg block that works with and without ffmpeg. It does not require ffmpeg to work.

So to answer your question, pulse audio works with this configuration without having ffmpeg in the image.

Lauren

Quoted 8 lines
Quoted 3 lines · <[email protected]> wrote:

PulseAudio's core contains the several algorithms for the resampler, and ffmpeg resample algorithm is one of them. So it can choose the algorithm by the Daemon configuration file

Yes, I got this.

My question is if the audio works

(oops, send button too soon) ... works in case the system does not have ffmpeg support? Does it uses a fallback mechanism? This needs testing.