: TCWG Bisect tcwg_kernel/llvm-release-arm-stable-allyesconfig - Build # 4 - Successful!

Successfully identified regression in *linux* in CI configuration tcwg_kernel/llvm-release-arm-stable-allyesconfig. So far, this commit has regressed CI configurations:
- tcwg_kernel/llvm-release-arm-stable-allyesconfig

Culprit:
<cut>
commit 341db343768bc44f3512facc464021730d64071c

Author: Linus Walleij <[email protected]>
Date:   Sun May 23 00:50:39 2021 +0200

power: supply: ab8500: Move to componentized binding

[ Upstream commit 1c1f13a006ed0d71bb5664c8b7e3e77a28da3beb ]

The driver has problems with the different components of the charging code racing with each other to probe().

This results in all four subdrivers populating battery information to ascertain that it is populated for their own needs for example.

Fix this by using component probing and thus expressing to the kernel that these are dependent components. The probes can happen in any order and will only acquire resources such as state container, regulators and interrupts and initialize the data structures, but no execution happens until the .bind() callback is called.

The charging driver is the main component and binds first, then bind in order the three subcomponents:
ab8500-fg, ab8500-btemp and ab8500-chargalg.

Do some housekeeping while we are moving the code around. Like use devm_* for IRQs so as to cut down on some boilerplate.

Signed-off-by Linus Walleij <[email protected]>

Signed-off-by Sebastian Reichel <[email protected]>

Signed-off-by Sasha Levin <[email protected]>

</cut>

Results regressed to (for first_bad == 341db343768bc44f3512facc464021730d64071c) # reset_artifacts:
-10

# build_abe binutils:
-9
# build_llvm:
-5
# build_abe qemu:
-2
# linux_n_obj:
19634
# First few build errors in logs:
# 00:03:07 drivers/power/supply/ab8500_fg.c:3061:32: error: use of undeclared identifier 'np'
# 00:03:08 make[3]: *** [drivers/power/supply/ab8500_fg.o] Error 1
# 00:03:10 make[2]: *** [drivers/power/supply] Error 2
# 00:03:10 make[1]: *** [drivers/power] Error 2
# 00:04:05 make: *** [drivers] Error 2

Quoted 36 lines · On 8/2/2021 7:43 AM, [email protected] wrote:

Successfully identified regression in *linux* in CI configuration tcwg_kernel/llvm-release-arm-stable-allyesconfig. So far, this commit has regressed CI configurations:
- tcwg_kernel/llvm-release-arm-stable-allyesconfig

Culprit:
<cut>
commit 341db343768bc44f3512facc464021730d64071c

Author: Linus Walleij <[email protected]>
Date:   Sun May 23 00:50:39 2021 +0200

power: supply: ab8500: Move to componentized binding [ Upstream commit 1c1f13a006ed0d71bb5664c8b7e3e77a28da3beb ] The driver has problems with the different components of the charging code racing with each other to probe(). This results in all four subdrivers populating battery information to ascertain that it is populated for their own needs for example.
Fix this by using component probing and thus expressing to the kernel that these are dependent components. The probes can happen in any order and will only acquire resources such as state container, regulators and interrupts and initialize the data structures, but no execution happens until the .bind() callback is called. The charging driver is the main component and binds first, then bind in order the three subcomponents:
ab8500-fg, ab8500-btemp and ab8500-chargalg.
Do some housekeeping while we are moving the code around. Like use devm_* for IRQs so as to cut down on some boilerplate.

Signed-off-by Linus Walleij <[email protected]>

Signed-off-by Sebastian Reichel <[email protected]>

Signed-off-by Sasha Levin <[email protected]>

</cut>

Results regressed to (for first_bad == 341db343768bc44f3512facc464021730d64071c) # reset_artifacts:
-10

Quoted 14 lines

# build_abe binutils:
-9
# build_llvm:
-5
# build_abe qemu:
-2
# linux_n_obj:
19634
# First few build errors in logs:
# 00:03:07 drivers/power/supply/ab8500_fg.c:3061:32: error: use of undeclared identifier 'np'
# 00:03:08 make[3]: *** [drivers/power/supply/ab8500_fg.o] Error 1
# 00:03:10 make[2]: *** [drivers/power/supply] Error 2
# 00:03:10 make[1]: *** [drivers/power] Error 2
# 00:04:05 make: *** [drivers] Error 2

Greg and Sasha,

Please cherry pick upstream commit 7e2bb83c617f ("power: supply: ab8500: Call battery population once") to resolve this build error on 5.13.

Quoted 7 lines · Nathan Chancellor

On 8/2/2021 7:43 AM, [email protected] wrote:

Greg and Sasha,

Please cherry pick upstream commit 7e2bb83c617f ("power: supply:
ab8500: Call battery population once") to resolve this build error on 5.13.

Queued up, thanks!