Skip to contentSkip to conversation

ASoC: ssm2518: Convert to params_width()

PATCH In review Mark Brown 2 participants 4 messages Jul 31, 2014

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/2 ASoC: ssm2518: Convert to params_width()

From: Mark Brown <[email protected]>

The CODEC doesn't care how data is laid out in memory.

---
 sound/soc/codecs/ssm2518.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/ssm2518.c +3 -3
index 56adb3e2def9..e8680bea5f86 100644
@@ -361,11 +361,11 @@ static int ssm2518_hw_params(struct snd_pcm_substream *substream,
 		return -EINVAL;
 
 	if (ssm2518->right_j) {
-		switch (params_format(params)) {
-		case SNDRV_PCM_FORMAT_S16_LE:
+		switch (params_width(params)) {
+		case 16:
 			ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_16BIT;
 			break;
-		case SNDRV_PCM_FORMAT_S24_LE:
+		case 24:
 			ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_24BIT;
 			break;
 		default:
Signature · 1 line
2.0.1
author maintainer
#1 lore raw

PATCH 2/2 ASoC: ssm2602: Convert to params_width()

From: Mark Brown <[email protected]>

The CODEC doesn't care how data is laid out in memory.

---
 sound/soc/codecs/ssm2602.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
sound/soc/codecs/ssm2602.c +5 -5
index 97b0454eb346..484b3bbe8624 100644
@@ -275,17 +275,17 @@ static int ssm2602_hw_params(struct snd_pcm_substream *substream,
 	regmap_write(ssm2602->regmap, SSM2602_SRATE, srate);
 
 	/* bit size */
-	switch (params_format(params)) {
-	case SNDRV_PCM_FORMAT_S16_LE:
+	switch (params_width(params)) {
+	case 16:
 		iface = 0x0;
 		break;
-	case SNDRV_PCM_FORMAT_S20_3LE:
+	case 20:
 		iface = 0x4;
 		break;
-	case SNDRV_PCM_FORMAT_S24_LE:
+	case 24:
 		iface = 0x8;
 		break;
-	case SNDRV_PCM_FORMAT_S32_LE:
+	case 32:
 		iface = 0xc;
 		break;
 	default:
Signature · 1 line
2.0.1
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] ASoC: ssm2602: Convert to params_width()

Quoted 5 lines · Mark Brown

From: Mark Brown <[email protected]>

The CODEC doesn't care how data is laid out in memory.

Thanks.

Quoted 32 lines
---
  sound/soc/codecs/ssm2602.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
sound/soc/codecs/ssm2602.c +5 -5
index 97b0454eb346..484b3bbe8624 100644
@@ -275,17 +275,17 @@ static int ssm2602_hw_params(struct snd_pcm_substream *substream,
  	regmap_write(ssm2602->regmap, SSM2602_SRATE, srate);
 
  	/* bit size */
-	switch (params_format(params)) {
-	case SNDRV_PCM_FORMAT_S16_LE:
+	switch (params_width(params)) {
+	case 16:
  		iface = 0x0;
  		break;
-	case SNDRV_PCM_FORMAT_S20_3LE:
+	case 20:
  		iface = 0x4;
  		break;
-	case SNDRV_PCM_FORMAT_S24_LE:
+	case 24:
  		iface = 0x8;
  		break;
-	case SNDRV_PCM_FORMAT_S32_LE:
+	case 32:
  		iface = 0xc;
  		break;
  	default:
maintainer Acked-by on v1 1/2
#3 lore raw
In reply to Mark Brown
Quoted 5 lines · Mark Brown

From: Mark Brown <[email protected]>

The CODEC doesn't care how data is laid out in memory.

Thanks.

Quoted 24 lines
---
  sound/soc/codecs/ssm2518.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/ssm2518.c +3 -3
index 56adb3e2def9..e8680bea5f86 100644
@@ -361,11 +361,11 @@ static int ssm2518_hw_params(struct snd_pcm_substream *substream,
  		return -EINVAL;
 
  	if (ssm2518->right_j) {
-		switch (params_format(params)) {
-		case SNDRV_PCM_FORMAT_S16_LE:
+		switch (params_width(params)) {
+		case 16:
  			ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_16BIT;
  			break;
-		case SNDRV_PCM_FORMAT_S24_LE:
+		case 24:
  			ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_24BIT;
  			break;
  		default: