Skip to contentSkip to conversation

useradd: Add setscene dep on pseudo-native

PATCH In review Jate Sujjavanich 2 participants 4 messages Aug 10, 2014 – Aug 30, 2014

lore
Share & tools
lore

Jate Sujjavanich

author
#0 lore raw

PATCH 1/1 useradd: Add setscene dep on pseudo-native

A recipe will sometimes be rebuilt unnecessarily if it adds users via useradd and the pseudo-native task has not been populated.

This patch adds the correct dependency.

Signed-off-by Jate Sujjavanich <[email protected]>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/useradd.bbclass +1 -1
index ea15dab..3b70e80 100644
@@ -126,7 +126,7 @@ SYSROOTPOSTFUNC_class-cross = ""
 SYSROOTPOSTFUNC_class-native = ""
 SYSROOTPOSTFUNC_class-nativesdk = ""
 
-USERADDSETSCENEDEPS = "${MLPREFIX}base-passwd:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
+USERADDSETSCENEDEPS = "${MLPREFIX}base-passwd:do_populate_sysroot_setscene pseudo-native:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
 USERADDSETSCENEDEPS_class-cross = ""
 USERADDSETSCENEDEPS_class-native = ""
 USERADDSETSCENEDEPS_class-nativesdk = ""
Signature · 1 line
1.7.9.5
author
#1 lore raw

Ping

Quoted 34 lines · Jate Sujjavanich

A recipe will sometimes be rebuilt unnecessarily if it adds users via useradd and the pseudo-native task has not been populated.

This patch adds the correct dependency.

Signed-off-by Jate Sujjavanich <[email protected]>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/useradd.bbclass +0 -1
index ea15dab..3b70e80 100644
@@ -126,7 +126,7 @@ SYSROOTPOSTFUNC_class-cross = ""
 SYSROOTPOSTFUNC_class-native = ""
 SYSROOTPOSTFUNC_class-nativesdk = ""
 
-USERADDSETSCENEDEPS =

"${MLPREFIX}base-passwd:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene" +USERADDSETSCENEDEPS = "${MLPREFIX}base-passwd:do_populate_sysroot_setscene pseudo-native:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
USERADDSETSCENEDEPS_class-cross = "" USERADDSETSCENEDEPS_class-native = "" USERADDSETSCENEDEPS_class-nativesdk = ""
--
1.7.9.5

author
#2 lore raw
In reply to Jate Sujjavanich

There's a commit in poky's master-next with the message "bitbake: runqueue:
Fix setscene tasks not running".

Should it fix the problem fixed by my patch?

Thanks,

- Jate S.

Quoted 34 lines · Jate Sujjavanich

A recipe will sometimes be rebuilt unnecessarily if it adds users via useradd and the pseudo-native task has not been populated.

This patch adds the correct dependency.

Signed-off-by Jate Sujjavanich <[email protected]>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/useradd.bbclass +0 -1
index ea15dab..3b70e80 100644
@@ -126,7 +126,7 @@ SYSROOTPOSTFUNC_class-cross = ""
 SYSROOTPOSTFUNC_class-native = ""
 SYSROOTPOSTFUNC_class-nativesdk = ""
 
-USERADDSETSCENEDEPS =

"${MLPREFIX}base-passwd:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene" +USERADDSETSCENEDEPS = "${MLPREFIX}base-passwd:do_populate_sysroot_setscene pseudo-native:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
USERADDSETSCENEDEPS_class-cross = "" USERADDSETSCENEDEPS_class-native = "" USERADDSETSCENEDEPS_class-nativesdk = ""
--
1.7.9.5

#3 lore raw
Quoted 4 lines · Jate Sujjavanich

There's a commit in poky's master-next with the message "bitbake:
runqueue: Fix setscene tasks not running".

Should it fix the problem fixed by my patch?

No, your patch does need to merge, I've done that.

Cheers,

Richard