Skip to contentSkip to conversation

curl: add zlib PACKAGECONFIG and remove hardcoded DEPENDS

PATCH New Andre McCurdy 1 participant 3 messages Aug 13, 2014

lore
Share & tools
lore

Andre McCurdy

author
#0 lore raw

PATCH 1/3 curl: add zlib PACKAGECONFIG and remove hardcoded DEPENDS

Add a zlib PACKAGECONFIG control and update PACKAGECONFIG[ssl] to include the openssl dependency. Older hardcoded DEPENDS can then be removed.

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-support/curl/curl_7.37.1.bb | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)
meta/recipes-support/curl/curl_7.37.1.bb +9 -12
index dc1d6a6..e51e06d 100644
@@ -5,10 +5,6 @@ SECTION = "console/network"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;beginline=7;md5=3a34942f4ae3fbf1a303160714e664ac"
 
-DEPENDS = "zlib gnutls"
-DEPENDS_class-native = "zlib-native openssl-native"
-DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-openssl"
-
 SRC_URI = "http://curl.haxx.se/download/curl-${PV}.tar.bz2 \
            file://pkgconfig_fix.patch \
 "

@@ -23,22 +19,23 @@ SRC_URI[sha256sum] = "c3ef3cd148f3778ddbefb344117d7829db60656efe1031f9e3065fc0fa
 
 inherit autotools pkgconfig binconfig multilib_header
 
-PACKAGECONFIG ??= "gnutls ${@bb.utils.contains("DISTRO_FEATURES", "ipv6", "ipv6", "", d)}"
-PACKAGECONFIG_class-native = "ipv6 ssl"
-PACKAGECONFIG_class-nativesdk = "ipv6 ssl"
+PACKAGECONFIG ??= "${@bb.utils.contains("DISTRO_FEATURES", "ipv6", "ipv6", "", d)} gnutls zlib"
+PACKAGECONFIG_class-native = "ipv6 ssl zlib"
+PACKAGECONFIG_class-nativesdk = "ipv6 ssl zlib"
+
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
-PACKAGECONFIG[ssl] =  "--with-ssl, --without-ssl, ,"
-PACKAGECONFIG[gnutls] =  "--with-gnutls=${STAGING_LIBDIR}/../, --without-gnutls, gnutls,"
+PACKAGECONFIG[ssl] = "--with-ssl,--without-ssl,openssl"
+PACKAGECONFIG[gnutls] = "--with-gnutls=${STAGING_LIBDIR}/../,--without-gnutls,gnutls"
+PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
-EXTRA_OECONF = "--with-zlib=${STAGING_LIBDIR}/../ \
-                --without-libssh2 \
+EXTRA_OECONF = "--without-libssh2 \
                 --with-random=/dev/urandom \
                 --without-libidn \
                 --enable-crypto-auth \
                 --disable-ldap \
                 --disable-ldaps \
                 --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
-                "
+"
 
 do_configure_prepend() {
 	sed -i s:OPT_GNUTLS/bin:OPT_GNUTLS:g ${S}/configure.ac
Signature · 1 line
1.8.3.2
author
#1 lore raw

PATCH 2/3 curl: let configure find gnutls via pkg-config

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-support/curl/curl_7.37.1.bb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
meta/recipes-support/curl/curl_7.37.1.bb +1 -5
index e51e06d..4b7f9ec 100644
@@ -25,7 +25,7 @@ PACKAGECONFIG_class-nativesdk = "ipv6 ssl zlib"
 
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
 PACKAGECONFIG[ssl] = "--with-ssl,--without-ssl,openssl"
-PACKAGECONFIG[gnutls] = "--with-gnutls=${STAGING_LIBDIR}/../,--without-gnutls,gnutls"
+PACKAGECONFIG[gnutls] = "--with-gnutls,--without-gnutls,gnutls"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = "--without-libssh2 \

@@ -37,10 +37,6 @@ EXTRA_OECONF = "--without-libssh2 \
                 --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
 "
 
-do_configure_prepend() {
-	sed -i s:OPT_GNUTLS/bin:OPT_GNUTLS:g ${S}/configure.ac
-}
-
 do_install_append() {
 	oe_multilib_header curl/curlbuild.h
 }
Signature · 1 line
1.8.3.2
author
#2 lore raw

PATCH 3/3 curl: --with-random is only applicable with openssl

In reply to Andre McCurdy
Signed-off-by Andre McCurdy <[email protected]>
---
 meta/recipes-support/curl/curl_7.37.1.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-support/curl/curl_7.37.1.bb +1 -2
index 4b7f9ec..8bcd9ba 100644
@@ -24,12 +24,11 @@ PACKAGECONFIG_class-native = "ipv6 ssl zlib"
 PACKAGECONFIG_class-nativesdk = "ipv6 ssl zlib"
 
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
-PACKAGECONFIG[ssl] = "--with-ssl,--without-ssl,openssl"
+PACKAGECONFIG[ssl] = "--with-ssl --with-random=/dev/urandom,--without-ssl,openssl"
 PACKAGECONFIG[gnutls] = "--with-gnutls,--without-gnutls,gnutls"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
 
 EXTRA_OECONF = "--without-libssh2 \
-                --with-random=/dev/urandom \
                 --without-libidn \
                 --enable-crypto-auth \
                 --disable-ldap \
Signature · 1 line
1.8.3.2