Skip to contentSkip to conversation

not adding modules range to kcore if it's equal to vmcore range

PATCH New Baoquan He 1 participant 1 message Aug 27, 2014

Subsystems (2)
lore
Share & tools
lore

Baoquan He

author
#0 lore raw

PATCH v4 1/1 not adding modules range to kcore if it's equal to vmcore range

On some ARCHs modules range is eauql to vmalloc range. E.g on i686
"#define MODULES_VADDR VMALLOC_START"
"#define MODULES_END VMALLOC_END"
This will cause 2 duplicate program segments in /proc/kcore, and no any flag to indicate both of them are different. This is confusing. And usually people who need check the elf header or read the content of kcore will check memory ranges. Two program segments which are the same completely are unnecessary.

So in this patch a judgment added to check if modules range is equal to vmalloc range completely. If yes, just skip adding the modules range.

---
 fs/proc/kcore.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
fs/proc/kcore.c +4 -1
index 6df8d07..69cb67b 100644
@@ -610,8 +610,11 @@ static void __init proc_kcore_text_init(void)
 struct kcore_list kcore_modules;
 static void __init add_modules_range(void)
 {
-	kclist_add(&kcore_modules, (void *)MODULES_VADDR,
+	if ( (MODULES_VADDR != VMALLOC_START) &&
+		(MODULES_END != VMALLOC_END) ) {
+		kclist_add(&kcore_modules, (void *)MODULES_VADDR,
 			MODULES_END - MODULES_VADDR, KCORE_VMALLOC);
+	}
 }
 #else
 static void __init add_modules_range(void)
Signature · 1 line
1.9.0