Skip to contentSkip to conversation

ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH

PATCH In review Rob Clark 2 participants 2 messages Aug 27, 2014 Library code

lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH

We really don't want distro's enabling this in their kernels. Try and make that more clear.

---
 lib/Kconfig.debug | 4 ++++
 1 file changed, 4 insertions(+)
lib/Kconfig.debug +4 -0
index 07c2832..1b233fc 100644
@@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
 	 the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
 	 will test all possible w/w mutex interface abuse with the
 	 exception of simply not acquiring all the required locks.
+	 Note that this feature can introduce significant overhead, so
+	 it really should not be enabled in a production or distro kernel,
+	 even a debug kernel.  If you are a driver writer, enable it.  If
+	 you are a distro, do not.
 
 config DEBUG_LOCK_ALLOC
 	bool "Lock debugging: detect incorrect freeing of live locks"
Signature · 1 line
1.9.3
Acked-by on v1 1/1
#1 lore raw
Quoted 24 lines · Rob Clark

We really don't want distro's enabling this in their kernels. Try and make that more clear.

---
 lib/Kconfig.debug | 4 ++++
 1 file changed, 4 insertions(+)
lib/Kconfig.debug +4 -0
index 07c2832..1b233fc 100644
@@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
 	 the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
 	 will test all possible w/w mutex interface abuse with the
 	 exception of simply not acquiring all the required locks.
+	 Note that this feature can introduce significant overhead, so
+	 it really should not be enabled in a production or distro kernel,
+	 even a debug kernel.  If you are a driver writer, enable it.  If
+	 you are a distro, do not.
 
 config DEBUG_LOCK_ALLOC
 	bool "Lock debugging: detect incorrect freeing of live locks"