Skip to contentSkip to conversation

drm/vmwgfx: select FB when DRM_VMWGFX is selected

PATCH In review Max Filippov 2 participants 3 messages Aug 31, 2014 – Sep 1, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/vmwgfx: select FB when DRM_VMWGFX is selected

Otherwise, if FB is not selected build fails at linking step:
vmwgfx_fb.c:(.text+0x4098b): undefined reference to register_framebuffer' vmwgfx_fb.c:(.text+0x409c0): undefined reference to framebuffer_release' vmwgfx_fb.c:(.text+0x409f4): undefined reference to unregister_framebuffer' vmwgfx_fb.c:(.text+0x40a0e): undefined reference to framebuffer_release'

Patch ae6445ac7475ff05 drm/vmwgfx: depends on FB added dependency on FB that was subsequently removed in patch 04381b987292256d drm: Move plane helpers into drm_kms_helper.ko

---
 drivers/gpu/drm/vmwgfx/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/vmwgfx/Kconfig +1 -0
index 67720f7..4fba548 100644
@@ -1,6 +1,7 @@
 config DRM_VMWGFX
 	tristate "DRM driver for VMware Virtual GPU"
 	depends on DRM && PCI
+	select FB
 	select FB_DEFERRED_IO
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 21 lines · Max Filippov

Otherwise, if FB is not selected build fails at linking step:
vmwgfx_fb.c:(.text+0x4098b): undefined reference to register_framebuffer' vmwgfx_fb.c:(.text+0x409c0): undefined reference to framebuffer_release' vmwgfx_fb.c:(.text+0x409f4): undefined reference to unregister_framebuffer' vmwgfx_fb.c:(.text+0x40a0e): undefined reference to framebuffer_release'

Patch ae6445ac7475ff05 drm/vmwgfx: depends on FB added dependency on FB that was subsequently removed in patch 04381b987292256d drm: Move plane helpers into drm_kms_helper.ko

---
 drivers/gpu/drm/vmwgfx/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/vmwgfx/Kconfig +0 -0
index 67720f7..4fba548 100644

drivers/gpu/drm/vmwgfx/Kconfig line 7

Quoted 7 lines
drivers/gpu/drm/vmwgfx/Kconfig +1 -0
@@ -1,6 +1,7 @@
 config DRM_VMWGFX
 	tristate "DRM driver for VMware Virtual GPU"
 	depends on DRM && PCI
+	select FB
 	select FB_DEFERRED_IO
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA

My experience with these "select FB_*" things is that this symbol (DRM_VMWGFX) should still depend on FB. Has something changed recently to negate that?

Signature · 1 line
~Randy
#2 lore raw
Quoted 16 lines · Randy Dunlap
Quoted 15 lines · Max Filippov

Otherwise, if FB is not selected build fails at linking step:
vmwgfx_fb.c:(.text+0x4098b): undefined reference to register_framebuffer' vmwgfx_fb.c:(.text+0x409c0): undefined reference to framebuffer_release' vmwgfx_fb.c:(.text+0x409f4): undefined reference to unregister_framebuffer' vmwgfx_fb.c:(.text+0x40a0e): undefined reference to framebuffer_release'

Patch ae6445ac7475ff05 drm/vmwgfx: depends on FB added dependency on FB that was subsequently removed in patch 04381b987292256d drm: Move plane helpers into drm_kms_helper.ko

---
 drivers/gpu/drm/vmwgfx/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 16 lines

drivers/gpu/drm/vmwgfx/Kconfig line 7

Quoted 13 lines
drivers/gpu/drm/vmwgfx/Kconfig +1 -0
index 67720f7..4fba548 100644
@@ -1,6 +1,7 @@
 config DRM_VMWGFX
      tristate "DRM driver for VMware Virtual GPU"
      depends on DRM && PCI
+     select FB
      select FB_DEFERRED_IO
      select FB_CFB_FILLRECT
      select FB_CFB_COPYAREA

My experience with these "select FB_*" things is that this symbol (DRM_VMWGFX) should still depend on FB. Has something changed recently to negate that?

I see the following if I replace 'select FB' with 'depends on FB':

drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39: symbol DRM_KMS_FB_HELPER depends on
DRM_KMS_HELPER
drivers/gpu/drm/Kconfig:33: symbol DRM_KMS_HELPER is selected by DRM_VMWGFX
drivers/gpu/drm/vmwgfx/Kconfig:1: symbol DRM_VMWGFX depends on FB

Signature · 2 lines
Thanks.
-- Max