Skip to contentSkip to conversation

2.4.19-pre8 non-kernel files in wan/8253x

DISCUSSION Keith Owens 1 participant 1 message May 16, 2002 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 19 lines · On Thu, 16 May 2002 11:07:15 EDT, [email protected] wrote:

In a message dated 5/16/2002 3:57:52 AM Eastern Daylight Time,

Quoted 17 lines · [email protected] writes:

drivers/net/wan/8253x/Makefile contains these lines

8253xcfg: 8253xcfg.c

        $(CC)  -o 8253xcfg $(EXTRA_CFLAGS) -U__KERNEL__ 8253xcfg.c

8253xmac: 8253xmac.c

        $(CC)  -o 8253xmac $(EXTRA_CFLAGS) -U__KERNEL__ 8253xmac.c

8253xspeed: 8253xspeed.c

        $(CC)  -o 8253xspeed $(EXTRA_CFLAGS) -U__KERNEL__ 8253xspeed.c

8253xpeer: 8253xpeer.c

        $(CC)  -o 8253xpeer $(EXTRA_CFLAGS) -U__KERNEL__ 8253xpeer.c

eprom9050: eprom9050.c

        $(CC)  -o eprom9050 $(EXTRA_CFLAGS) -U__KERNEL__ eprom9050.c
Quoted 6 lines
Quoted 3 lines

All of those .c files are user space utilities, they do not fit the kernel build system and do not belong in the kernel. Please move these files to a separate user space package and delete from 2.4.19-pre*.

I think there needs to be some way to guarantee that these last two programs are available whenever the driver is included with a kernel.

User space programs do not belong in the kernel. They belong in a user space package, like all the other device tuning programs. The kernel documentation for your driver points to the user space package.