Skip to contentSkip to conversation

GenWQE: Add return code checking and cleanup (v3)

PATCH Frank Haverkamp 1 participant 2 messages Sep 12, 2014 – Sep 22, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Greg,

Am Mittwoch, den 10.09.2014, 16:37 +0200 schrieb Frank Haverkamp:

Quoted 13 lines

We tested "misc/GenWQE: fix pci_enable_msi usage" from Sebastian Ott successfully on our machine. The modification of the return code is now fixed too. The driver version as sysfs entry was removed. The driver version itself we kept and made it the same like other drivers do it. The information can be retrieved by using modinfo genwqe_card. Furthermore we added checking for return codes, where we found it missing. Finally I fixed the checkpatch.pl complaints and replaced an invalid email address of a co-author by a working one.
The last patch reduces the load if the queue is full.

Eberhard S. Amann (1):
GenWQE: Fix problem when reading HSI and Retc

Quoted 8 lines

Frank Haverkamp (7):
GenWQE: Check pci_get_totalvfs return code
GenWQE: Remove sysfs entry for driver version
GenWQE: Update author information
GenWQE: Do not modify return code of genwqe_set_interrupt_capability
GenWQE: Check return code of pci_sriov_enable
GenWQE: Fix checkpatch complaints
GenWQE: Support blocking when DDCB queue is busy

I hope you are not too busy these days and will find the time to review and hopefully integrate our patches if they are fine. Can you give me an outlook when you might find the time to have a look at them?

Thanks

Frank

#2 lore raw

Hi Greg,

Am Freitag, den 12.09.2014, 08:39 +0200 schrieb Frank Haverkamp:

Quoted 25 lines

Hi Greg,

Am Mittwoch, den 10.09.2014, 16:37 +0200 schrieb Frank Haverkamp:

Quoted 13 lines

We tested "misc/GenWQE: fix pci_enable_msi usage" from Sebastian Ott successfully on our machine. The modification of the return code is now fixed too. The driver version as sysfs entry was removed. The driver version itself we kept and made it the same like other drivers do it. The information can be retrieved by using modinfo genwqe_card. Furthermore we added checking for return codes, where we found it missing. Finally I fixed the checkpatch.pl complaints and replaced an invalid email address of a co-author by a working one.
The last patch reduces the load if the queue is full.

Eberhard S. Amann (1):
GenWQE: Fix problem when reading HSI and Retc

Quoted 8 lines

Frank Haverkamp (7):
GenWQE: Check pci_get_totalvfs return code
GenWQE: Remove sysfs entry for driver version
GenWQE: Update author information
GenWQE: Do not modify return code of genwqe_set_interrupt_capability
GenWQE: Check return code of pci_sriov_enable
GenWQE: Fix checkpatch complaints
GenWQE: Support blocking when DDCB queue is busy

Quoted 7 lines

I hope you are not too busy these days and will find the time to review and hopefully integrate our patches if they are fine. Can you give me an outlook when you might find the time to have a look at them?

Thanks

Frank

ping

Regards

Frank