batman-adv: avoid NULL dereferences and clarify if check
PATCH 1/1 batman-adv: avoid NULL dereferences and clarify if check
Due to a typ0 in an if-condition used in the gateway-client code it is possible to run in a NULL pointer dereference.
At the same type the same if-condition is not clear.
Fix this by rewriting the if-condition properly.
Introduced by 0853ec7fafe0a195754454832993c6b35e22b842 ("batman-adv: tvlv - gateway download/upload bandwidth container")
Signed-off-by Antonio Quartulli <[email protected]>
Reported-by David Binderman <[email protected]>
--- gateway_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
gateway_client.c +1 -1
@@ -811,7 +811,7 @@ bool batadv_gw_out_of_range(struct batadv_priv *bat_priv, goto out; gw_node =batadv_gw_node_get (bat_priv, orig_dst_node); -if (!gw_node->bandwidth_down ==0 ) +if (!gw_node || (gw_node->bandwidth_down ==0 )) goto out;switch (atomic_read (&bat_priv->gw_mode)) {
Signature · 1 line
1.8.5.5
Hi all,
gateway_client.c bool batadv_gw_out_of_range(struct batadv_priv *bat_priv, · line 814
Quoted 3 lines · Antonio Quartulli
gateway_client.c +1
-1gw_node =batadv_gw_node_get (bat_priv, orig_dst_node); -if (!gw_node->bandwidth_down ==0 ) +if (!gw_node || (gw_node->bandwidth_down ==0 ))
This is not the right way to fix this condition. A new patch is coming.
Cheers,
Signature · 1 line
Antonio Quartulli