i2c-core.ko renamed to i2ccore.ko
Hi guys,
Sorry for jumping in a bit late, but given that I did not get involved in the discussions that led to this decision, better late than never.
I almost had an heart attack when noticing that module i2c-core.ko has suddenly been renamed to i2ccore.ko without an hyphen.
Renaming kernel modules is almost always wrong, in particular subsystem core modules. Such renames have an impact at various levels. We just had to change a configuration file in the openSUSE Factory kernel to adjust that change, and this is how I noticed it. But there can be several other issues, including mkinitrd or equivalent tools, as well as documentation. The extra work and confusion is a high price to pay, and it can easily be avoided.
So I am kindly asking that you revert this name change before kernel v3.17 final. Rename source files if you really have to, git makes it easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or whatever. Just don't rename i2c-core.ko, please.
Thanks,
Signature · 2 lines
Jean Delvare SUSE L3 Support
A message that is not in the archive (sent off-list or not yet received): 1411042678.7338.20.camel-H7Kp9ZFCxt/[email protected]
Quoted 8 lines · Jean Delvare
Hi guys,
Sorry for jumping in a bit late, but given that I did not get involved in the discussions that led to this decision, better late than never.
I almost had an heart attack when noticing that module i2c-core.ko has suddenly been renamed to i2ccore.ko without an hyphen.
Quoted 7 lines
Renaming kernel modules is almost always wrong, in particular subsystem core modules. Such renames have an impact at various levels. We just had to change a configuration file in the openSUSE Factory kernel to adjust that change, and this is how I noticed it. But there can be several other issues, including mkinitrd or equivalent tools, as well as documentation. The extra work and confusion is a high price to pay, and it can easily be avoided.
I understand completely your point and I guess this was rather inadvertent change.
Quoted 4 lines
So I am kindly asking that you revert this name change before kernel v3.17 final. Rename source files if you really have to, git makes it easy. Or merge the
i2c-acpi.ccode intoi2c-core.cwith ifdefs. Or whatever. Just don't rename i2c-core.ko, please.
My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs.
Tianyu, Wolfram, comments?
A message that is not in the archive (sent off-list or not yet received): 20140918125825.GR10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org
Quoted 17 lines · Mika Westerberg
Quoted 8 lines · Jean Delvare
Hi guys,
Sorry for jumping in a bit late, but given that I did not get involved in the discussions that led to this decision, better late than never.
I almost had an heart attack when noticing that module i2c-core.ko has suddenly been renamed to i2ccore.ko without an hyphen.
Quoted 7 lines
Renaming kernel modules is almost always wrong, in particular subsystem core modules. Such renames have an impact at various levels. We just had to change a configuration file in the openSUSE Factory kernel to adjust that change, and this is how I noticed it. But there can be several other issues, including mkinitrd or equivalent tools, as well as documentation. The extra work and confusion is a high price to pay, and it can easily be avoided.
Quoted 2 lines
I understand completely your point and I guess this was rather inadvertent change.
Yes. Thanks for pointing out, Jean!
Quoted 9 lines
Quoted 5 lines
So I am kindly asking that you revert this name change before kernel v3.17 final. Rename source files if you really have to, git makes it easy. Or merge the
i2c-acpi.ccode intoi2c-core.cwith ifdefs. Or whatever. Just don't rename i2c-core.ko, please.My vote goes for merging
i2c-acpi.cback toi2c-core.cwith #ifdefs.Tianyu, Wolfram, comments?
Agreed.
Quoted 29 lines · Wolfram Sang
Quoted 17 lines · Mika Westerberg
Quoted 8 lines · Jean Delvare
Hi guys,
Sorry for jumping in a bit late, but given that I did not get involved in the discussions that led to this decision, better late than never.
I almost had an heart attack when noticing that module i2c-core.ko has suddenly been renamed to i2ccore.ko without an hyphen.
Quoted 7 lines
Renaming kernel modules is almost always wrong, in particular subsystem core modules. Such renames have an impact at various levels. We just had to change a configuration file in the openSUSE Factory kernel to adjust that change, and this is how I noticed it. But there can be several other issues, including mkinitrd or equivalent tools, as well as documentation. The extra work and confusion is a high price to pay, and it can easily be avoided.
Quoted 2 lines
I understand completely your point and I guess this was rather inadvertent change.
Yes. Thanks for pointing out, Jean!
Quoted 6 lines
Quoted 5 lines
So I am kindly asking that you revert this name change before kernel v3.17 final. Rename source files if you really have to, git makes it easy. Or merge the
i2c-acpi.ccode intoi2c-core.cwith ifdefs. Or whatever. Just don't rename i2c-core.ko, please.
Quoted 6 lines
Quoted 3 lines
My vote goes for merging
i2c-acpi.cback toi2c-core.cwith #ifdefs.Tianyu, Wolfram, comments?
Agreed.
How about including i2c-acpi.c in the i2c-core.c directly if ACPI is selected?
Signature · 2 lines
Best regards Tianyu Lan
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 2 lines · Lan Tianyu
How about including
i2c-acpi.cin thei2c-core.cdirectly if ACPI is selected?
I would rather see it merged there.
A message that is not in the archive (sent off-list or not yet received): 20140919085328.GC10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org
Quoted 5 lines · Mika Westerberg
Quoted 2 lines · Lan Tianyu
How about including
i2c-acpi.cin thei2c-core.cdirectly if ACPI is selected?I would rather see it merged there.
+1