Skip to contentSkip to conversation

socfpga: Enable DWMMC for SOCFPGA

PATCH New Chin Liang See 2 participants 2 messages Sep 19, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 socfpga: Enable DWMMC for SOCFPGA

To enable the DesignWare MMC controller driver support for SOCFPGA Cyclone5 dev kit

Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Wolfgang Denk <[email protected]>
---
 include/configs/socfpga_cyclone5.h |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
include/configs/socfpga_cyclone5.h +18 -0
index 32175b7..f9fafac 100644
@@ -252,6 +252,24 @@
 /* Clocks source frequency to watchdog timer */
 #define CONFIG_DW_WDT_CLOCK_KHZ		25000
 
+/*
+ * MMC support
+ */
+#define CONFIG_MMC
+#ifdef CONFIG_MMC
+#define CONFIG_CMD_MMC
+#define CONFIG_SDMMC_BASE		(SOCFPGA_SDMMC_ADDRESS)
+#define CONFIG_SDMMC_HOST_HS
+#define CONFIG_GENERIC_MMC		1
+#define CONFIG_DWMMC
+#define CONFIG_SOCFPGA_DWMMC
+#define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH	1024
+#define CONFIG_SOCFPGA_DWMMC_DRVSEL	3
+#define CONFIG_SOCFPGA_DWMMC_SMPSEL	0
+#define CONFIG_BOUNCE_BUFFER
+/* using smaller max blk cnt to avoid flooding the limited stack we have */
+#define CONFIG_SYS_MMC_MAX_BLK_COUNT     256
+#endif	/* CONFIG_MMC */
 
 /*
  * SPL "Second Program Loader" aka Initial Software
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 socfpga: Enable DWMMC for SOCFPGA

Quoted 19 lines · Chin Liang See

To enable the DesignWare MMC controller driver support for SOCFPGA Cyclone5 dev kit

Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Wolfgang Denk <[email protected]>
---
 include/configs/socfpga_cyclone5.h |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
(quoted diff) +0 -0

b/include/configs/socfpga_cyclone5.h index 32175b7..f9fafac 100644

include/configs/socfpga_cyclone5.h line 261

Quoted 10 lines
include/configs/socfpga_cyclone5.h +7 -0
@@ -252,6 +252,24 @@
 /* Clocks source frequency to watchdog timer */
 #define CONFIG_DW_WDT_CLOCK_KHZ		25000
 
+/*
+ * MMC support
+ */
+#define CONFIG_MMC
+#ifdef CONFIG_MMC
+#define CONFIG_CMD_MMC
+#define CONFIG_SDMMC_BASE		(SOCFPGA_SDMMC_ADDRESS)

This symbol doesn't exist.

include/configs/socfpga_cyclone5.h line 262

Quoted 1 line
include/configs/socfpga_cyclone5.h +1 -0
+#define CONFIG_SDMMC_HOST_HS

This symbol doesn't exist.

include/configs/socfpga_cyclone5.h line 263

Quoted 1 line
include/configs/socfpga_cyclone5.h +1 -0
+#define CONFIG_GENERIC_MMC		1

You don't actually need to define this to have a value.

include/configs/socfpga_cyclone5.h

Quoted 8 lines
include/configs/socfpga_cyclone5.h +7 -0
+#define CONFIG_DWMMC
+#define CONFIG_SOCFPGA_DWMMC
+#define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH	1024
+#define CONFIG_SOCFPGA_DWMMC_DRVSEL	3
+#define CONFIG_SOCFPGA_DWMMC_SMPSEL	0
+#define CONFIG_BOUNCE_BUFFER
+/* using smaller max blk cnt to avoid flooding the limited stack we have
 */ +#define CONFIG_SYS_MMC_MAX_BLK_COUNT     256

This is something I am wondering about (btw. you might have seen a FIXME tag in my repository right next to this code). Do we really need this in U-Boot or is this portion SPL specific ? Or do we even need this limit at all ? [...]

Anyway, I will pick them in my tree and add a bit more magic sause to them , then re-post the whole series.

Best regards,
Marek Vasut