Skip to contentSkip to conversation

Use the gssproxy damon for GSSAPI credentials

PATCH In review Steve Dickson 3 participants 9 messages Sep 19, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Use the gssproxy damon for GSSAPI credentials

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

For now I'm leaving the source files... Just in case... ;-)

Steve Dickson (2):
nfs-server: Replace rpc.svcgssd with gssproxy
svcgssd: Remove rules from the Makefile.am

 systemd/nfs-server.service  |  4 ++--
 systemd/rpc-svcgssd.service | 19 -------------------
 utils/gssd/Makefile.am      | 25 ++-----------------------
 3 files changed, 4 insertions(+), 44 deletions(-)
 delete mode 100644 systemd/rpc-svcgssd.service
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/2 nfs-server: Replace rpc.svcgssd with gssproxy

Make the nfs-server depend on the gssproxy
daemon running instead of svcgssd to manage
GSSAPI credentials

---
 systemd/nfs-server.service  |  4 ++--
 systemd/rpc-svcgssd.service | 19 -------------------
 2 files changed, 2 insertions(+), 21 deletions(-)
 delete mode 100644 systemd/rpc-svcgssd.service
systemd/nfs-server.service +2 -2
index 2fa7387..3b04f84 100644
@@ -2,12 +2,12 @@
 Description=NFS server and services
 Requires= network.target proc-fs-nfsd.mount rpcbind.target
 Requires= nfs-mountd.service
-Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service rpc-svcgssd.service
+Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service gssproxy.service
 Wants=rpc-statd-notify.service
 
 After= network.target proc-fs-nfsd.mount rpcbind.target nfs-mountd.service
 After= nfs-idmapd.service rpc-statd.service
-After= rpc-gssd.service rpc-svcgssd.service
+After= rpc-gssd.service gssproxy.service
 Before= rpc-statd-notify.service
 
 Wants=nfs-config.service
systemd/rpc-svcgssd.service deleted +0 -19
deleted file mode 100644
index f7424b0..0000000
@@ -1,19 +0,0 @@
-[Unit]
-Description=RPC security service for NFS server
-Requires=var-lib-nfs-rpc_pipefs.mount
-After=var-lib-nfs-rpc_pipefs.mount
-PartOf=nfs-server.service
-PartOf=nfs-utils.service
-
-After=gssproxy.service
-ConditionPathExists=|!/run/gssproxy.pid
-ConditionPathExists=|!/proc/net/rpc/use-gss-proxy
-ConditionPathExists=/etc/krb5.keytab
-
-Wants=nfs-config.service
-After=nfs-config.service
-
-[Service]
-EnvironmentFile=-/run/sysconfig/nfs-utils
-Type=forking
-ExecStart=/usr/sbin/rpc.svcgssd $SVCGSSDARGS
Signature · 1 line
1.9.3
#2 lore raw

PATCH 2/2 svcgssd: Remove rules from the Makefile.am

In reply to Steve Dickson

The managing of GSSAPI credentials is now done
with the gssproxy(8) daemon so svcgssd no longer
needs to be build or installed.

---
 utils/gssd/Makefile.am | 25 ++-----------------------
 1 file changed, 2 insertions(+), 23 deletions(-)
utils/gssd/Makefile.am +2 -23
index af59791..716dd0b 100644
@@ -1,10 +1,10 @@
 ## Process this file with automake to produce Makefile.in
 
-man8_MANS	= gssd.man svcgssd.man
+man8_MANS	= gssd.man
 
 RPCPREFIX	= rpc.
 KPREFIX		= @kprefix@
-sbin_PREFIXED	= gssd svcgssd
+sbin_PREFIXED	= gssd
 sbin_PROGRAMS	= $(sbin_PREFIXED)
 
 EXTRA_DIST = \
@@ -45,27 +45,6 @@ gssd_LDFLAGS = $(KRBLDFLAGS) $(LIBTIRPC)
 gssd_CFLAGS = $(AM_CFLAGS) $(CFLAGS) \
 	      $(RPCSECGSS_CFLAGS) $(KRBCFLAGS) $(GSSAPI_CFLAGS)
 
-svcgssd_SOURCES = \
-	$(COMMON_SRCS) \
-	svcgssd.c \
-	svcgssd_main_loop.c \
-	svcgssd_mech2file.c \
-	svcgssd_proc.c \
-	svcgssd_krb5.c \
-	\
-	svcgssd_krb5.h \
-	svcgssd.h
-
-svcgssd_LDADD = \
-	../../support/nfs/libnfs.a \
-	$(RPCSECGSS_LIBS) $(LIBNFSIDMAP) \
-	$(KRBLIBS) $(GSSAPI_LIBS) $(LIBTIRPC)
-
-svcgssd_LDFLAGS = $(KRBLDFLAGS)
-
-svcgssd_CFLAGS = $(AM_CFLAGS) $(CFLAGS) \
-		 $(RPCSECGSS_CFLAGS) $(KRBCFLAGS) $(GSSAPI_CFLAGS)
-
 MAINTAINERCLEANFILES = Makefile.in
 
 #######################################################################
Signature · 1 line
1.9.3
#3 lore raw
In reply to Steve Dickson
Quoted 8 lines · Steve Dickson

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

For now I'm leaving the source files... Just in case... ;-)

If nothing else, we'd like to keep support for older kernels for a while.

--b.

Quoted 18 lines

Steve Dickson (2):
nfs-server: Replace rpc.svcgssd with gssproxy
svcgssd: Remove rules from the Makefile.am

 systemd/nfs-server.service  |  4 ++--
 systemd/rpc-svcgssd.service | 19 -------------------
 utils/gssd/Makefile.am      | 25 ++-----------------------
 3 files changed, 4 insertions(+), 44 deletions(-)
 delete mode 100644 systemd/rpc-svcgssd.service
Signature · 6 lines
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
Quoted 4 lines · J. Bruce Fields
Quoted 3 lines · Steve Dickson

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

Quoted 8 lines
Quoted 5 lines

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

For now I'm leaving the source files... Just in case... ;-)

If nothing else, we'd like to keep support for older kernels for a while.

Good point... I should probably make this a configurable... something like --enable_svcgssd and have it off by default...

steved.

Quoted 21 lines

--b.

Quoted 18 lines

Steve Dickson (2):
nfs-server: Replace rpc.svcgssd with gssproxy
svcgssd: Remove rules from the Makefile.am

 systemd/nfs-server.service  |  4 ++--
 systemd/rpc-svcgssd.service | 19 -------------------
 utils/gssd/Makefile.am      | 25 ++-----------------------
 3 files changed, 4 insertions(+), 44 deletions(-)
 delete mode 100644 systemd/rpc-svcgssd.service
Signature · 6 lines
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#5 lore raw
Quoted 11 lines · Steve Dickson
Quoted 8 lines · J. Bruce Fields
Quoted 7 lines · Steve Dickson

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

For now I'm leaving the source files... Just in case... ;-)

If nothing else, we'd like to keep support for older kernels for a while.

Good point... I should probably make this a configurable... something like --enable_svcgssd and have it off by default...

Sounds fine.

--b.

#6 lore raw
Quoted 12 lines · On Fri, 19 Sep 2014 12:36:17 -0400 "J. Bruce Fields" <[email protected]>…
Quoted 11 lines · Steve Dickson
Quoted 8 lines · J. Bruce Fields
Quoted 7 lines · Steve Dickson

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

For now I'm leaving the source files... Just in case... ;-)

If nothing else, we'd like to keep support for older kernels for a while.

Good point... I should probably make this a configurable... something like --enable_svcgssd and have it off by default...

Sounds fine.

+1, it will be very useful for transitions in distributions, not all of them will align identically I guess.

Simo.

Signature · 1 line
Simo Sorce * Red Hat, Inc * New York
#7 lore raw
Quoted 19 lines · Simo Sorce
Quoted 16 lines · On Fri, 19 Sep 2014 12:36:17 -0400 "J. Bruce Fields" <[email protected]>…
Quoted 15 lines · Steve Dickson
Quoted 12 lines · J. Bruce Fields
Quoted 8 lines · Steve Dickson

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

For now I'm leaving the source files... Just in case... ;-)

If nothing else, we'd like to keep support for older kernels for a while.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Good point... I should probably make this a configurable... something like --enable_svcgssd and have it off by default...

Sounds fine.

+1, it will be very useful for transitions in distributions, not all of them will align identically I guess.

If we wanted to be *very* nice, we could try to detect and run one or the other at run-time. It's nice for people trying to boot old kernels to track down (probably unrelated) regressions. But I think it would be too complicated.

It might be simple enough for gss-proxy to log some kind of warning when it starts up on an old kernel.

--b.

#8 lore raw
Quoted 28 lines · On Fri, 19 Sep 2014 14:11:22 -0400 "J. Bruce Fields" <[email protected]>…
Quoted 19 lines · Simo Sorce
Quoted 16 lines · On Fri, 19 Sep 2014 12:36:17 -0400 "J. Bruce Fields" <[email protected]>…
Quoted 15 lines · Steve Dickson
Quoted 12 lines · J. Bruce Fields
Quoted 8 lines · Steve Dickson

The gssproxy(8) daemon is now how the managing of GSSAPI credentials should be done.

These to patches has the nfs-server systemd script start gssproxy instead of rpc.svcgssd and removes the building and installation of rpc.svcgssd.

For now I'm leaving the source files... Just in case... ;-)

If nothing else, we'd like to keep support for older kernels for a while.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Good point... I should probably make this a configurable... something like --enable_svcgssd and have it off by default...

Sounds fine.

+1, it will be very useful for transitions in distributions, not all of them will align identically I guess.

Quoted 7 lines

If we wanted to be *very* nice, we could try to detect and run one or the other at run-time. It's nice for people trying to boot old kernels to track down (probably unrelated) regressions. But I think it would be too complicated.

It might be simple enough for gss-proxy to log some kind of warning when it starts up on an old kernel.

Excellent idea, I opened a ticket to track that:
https://fedorahosted.org/gss-proxy/ticket/126

Simo.

Signature · 1 line
Simo Sorce * Red Hat, Inc * New York