Docs: this_cpu_ops: remove redundant add forms
PATCH 1/1 Docs: this_cpu_ops: remove redundant add forms
Hi,
I spotted the below while trying to figure out how to use this_cpu ops, and it left me confused for a short while.
I guess that this is a refactoring fallout rather than there being a special this_cpu_add variant?
Mark.
---->8----
Commit ac490f4dca94 (Documentation: this_cpu_ops.txt: Update description of this_cpu_ops) added lists of {__,}this_cpu operations, but these have duplicate, parameter-less entries for {__,}this_cpu_add which don't correspond to any implementation. No other operations have such duplicate entries.
Given both are also listed with their full complement of arguments, the empty forms are redundant and can be removed. This patch performs said removal.
--- Documentation/this_cpu_ops.txt | 2 -- 1 file changed, 2 deletions(-)
Documentation/this_cpu_ops.txt +0 -2
@@ -41,7 +41,6 @@ The following this_cpu() operations with implied preemption protection are defined. These operations can be used without worrying about preemption and interrupts. - this_cpu_add() this_cpu_read(pcp) this_cpu_write(pcp, val) this_cpu_add(pcp, val)
@@ -225,7 +224,6 @@ still occur while an operation is in progress and if the interrupt too modifies the variable, then RMW actions can not be guaranteed to be safe. - __this_cpu_add() __this_cpu_read(pcp) __this_cpu_write(pcp, val) __this_cpu_add(pcp, val)
Signature · 1 line
1.9.1
Quoted 5 lines · Mark Rutland
I spotted the below while trying to figure out how to use
this_cpuops, and it left me confused for a short while.I guess that this is a refactoring fallout rather than there being a special
this_cpu_addvariant?
Thanks for fixing it.
Quoted 21 lines · Mark Rutland
Hi,
I spotted the below while trying to figure out how to use
this_cpuops, and it left me confused for a short while.I guess that this is a refactoring fallout rather than there being a special
this_cpu_addvariant?Mark.
---->8----
Commitac490f4dca94(Documentation: this_cpu_ops.txt: Update description ofthis_cpu_ops) added lists of {__,}this_cpu operations, but these have duplicate, parameter-less entries for {__,}this_cpu_add which don't correspond to any implementation. No other operations have such duplicate entries.Given both are also listed with their full complement of arguments, the empty forms are redundant and can be removed. This patch performs said removal.
Quoted 7 lines
Signed-off-by Mark Rutland <[email protected]>Cc Pranith Kumar <[email protected]>Cc Christoph Lameter <[email protected]>Cc Randy Dunlap <[email protected]>--- Documentation/this_cpu_ops.txt | 2 -- 1 file changed, 2 deletions(-)
Applied, thanks.
Quoted 21 lines
Documentation/this_cpu_ops.txt +0
-2@@ -41,7 +41,6 @@ The following this_cpu() operations with implied preemption protection are defined. These operations can be used without worrying about preemption and interrupts. - this_cpu_add() this_cpu_read(pcp) this_cpu_write(pcp, val) this_cpu_add(pcp, val)@@ -225,7 +224,6 @@ still occur while an operation is in progress and if the interrupt too modifies the variable, then RMW actions can not be guaranteed to be safe. - __this_cpu_add() __this_cpu_read(pcp) __this_cpu_write(pcp, val) __this_cpu_add(pcp, val)
Signature · 1 line
~Randy