Skip to contentSkip to conversation

drm/i915: intel_backlight scale() math WA v2

PATCH In review Joe Konno 7 participants 14 messages Sep 24, 2014 – Nov 10, 2014

Subsystems (2)
lore
Share & tools
lore

Joe Konno

author
#0 lore raw

PATCH 1/1 drm/i915: intel_backlight scale() math WA v2

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
 	return target_val;
Signature · 1 line
2.1.0
#1 lore raw

Hi,

Quoted 11 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

Quoted 6 lines

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Regards,

Hans

Quoted 20 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
 	return target_val;
maintainer
#2 lore raw
Quoted 16 lines · Hans de Goede

Hi,

Quoted 13 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

Quoted 8 lines
Quoted 4 lines

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Mostly in preparation for a future where we expose an arbitrary range, say 0..100 or 0..255 to the userspace.

BR,
Jani.

Quoted 30 lines

Regards,

Hans

Quoted 12 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..dcdfbb3 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 427

Quoted 8 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
 	return target_val;

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
#3 lore raw
Quoted 28 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Wednesday, September 24, 2014 10:08 AM
To: Hans de Goede; Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 21 lines · Hans de Goede

Hi,

Quoted 17 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

Quoted 7 lines
Quoted 3 lines

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Mostly in preparation for a future where we expose an arbitrary range, say 0..100 or 0..255 to the userspace.

The problem with this scaling method is that scaling from user level to hw level and back to user level is ambiguous since there isn't a 1:1 mapping between the user range and the hw range.

On the other hand, this patch does fix a bug in the currently used method (scaling). That, at least, is an improvement nonetheless.

U. Artie

Quoted 41 lines

BR,
Jani.

Quoted 24 lines

Regards,

Hans

Quoted 18 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
Quoted 6 lines

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 427

Quoted 2 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	return target_val;

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 33 lines · Ullysses A
Quoted 25 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Wednesday, September 24, 2014 10:08 AM
To: Hans de Goede; Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 18 lines · Hans de Goede

Hi,

Quoted 15 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Mostly in preparation for a future where we expose an arbitrary range, say 0..100 or 0..255 to the userspace.

Quoted 8 lines

The problem with this scaling method is that scaling from user level to hw level and back to user level is ambiguous since there isn't a 1:1 mapping between the user range and the hw range.

On the other hand, this patch does fix a bug in the currently used method (scaling). That, at least, is an improvement nonetheless.

U. Artie

Apologies for resurrecting an old thread. But I think we still need to address
this issue about not having a 1:1 mapping between user and hw levels.

Right now, the problem is that the user range is larger than the hw range which
results in one or more user levels mapping to the same hw level. And when userspace requests one of those levels, the result that is reported back to userspace might not be the same as what was requested. Take for example, on my system the hw range is [398, 7812] and the user range is [0, 7812]. Suppose
userspace requests level 7017. This maps to hw level 7058. And when userspace requests the current level, 7018 is reported back (+1 from what was originally requested). In fact, with these particular ranges, there are exactly
398 values that this occurs.

This problem will be compounded the larger the difference in length of the discrete ranges; so long as user range > hw range.

Hans' solution would fix this problem, giving 1:1 mapping from hw to user levels.

Jani's [future] solution would work too, since exposing a smaller range to userspace than the hw range would isolate the non 1:1 mapping inside the driver.

U. Artie

Quoted 38 lines
Quoted 32 lines

BR,
Jani.

Quoted 22 lines

Regards,

Hans

Quoted 17 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
Quoted 6 lines

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 427

Quoted 2 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	return target_val;

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 5 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#5 lore raw
Quoted 62 lines · Ullysses A
Quoted 33 lines · Ullysses A
Quoted 25 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Wednesday, September 24, 2014 10:08 AM
To: Hans de Goede; Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 18 lines · Hans de Goede

Hi,

Quoted 15 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Mostly in preparation for a future where we expose an arbitrary range, say 0..100 or 0..255 to the userspace.

Quoted 8 lines

The problem with this scaling method is that scaling from user level to hw level and back to user level is ambiguous since there isn't a 1:1 mapping between the user range and the hw range.

On the other hand, this patch does fix a bug in the currently used method (scaling). That, at least, is an improvement nonetheless.

U. Artie

Apologies for resurrecting an old thread. But I think we still need to address
this issue about not having a 1:1 mapping between user and hw levels.

Right now, the problem is that the user range is larger than the hw range which
results in one or more user levels mapping to the same hw level. And when userspace requests one of those levels, the result that is reported back to userspace might not be the same as what was requested. Take for example, on my system the hw range is [398, 7812] and the user range is [0, 7812]. Suppose
userspace requests level 7017. This maps to hw level 7058. And when userspace requests the current level, 7018 is reported back (+1 from what was originally requested). In fact, with these particular ranges, there are exactly
398 values that this occurs.

This problem will be compounded the larger the difference in length of the discrete ranges; so long as user range > hw range.

Quoted 6 lines

Hans' solution would fix this problem, giving 1:1 mapping from hw to user levels.

Jani's [future] solution would work too, since exposing a smaller range to userspace than the hw range would isolate the non 1:1 mapping inside the driver.

I think we should just pick an arbitrary range, say 0..100, and be done with it. It's not like you'd be able to get much more than 100 distinct brightness levels out of the backlight anyway, no matter what the PWM settings.

BR,
Jani.

Quoted 46 lines

U. Artie

Quoted 43 lines
Quoted 32 lines

BR,
Jani.

Quoted 22 lines

Regards,

Hans

Quoted 17 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
Quoted 6 lines

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 427

Quoted 2 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	return target_val;

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#6 lore raw
Quoted 70 lines · Jani Nikula
Quoted 62 lines · Ullysses A
Quoted 33 lines · Ullysses A
Quoted 25 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Wednesday, September 24, 2014 10:08 AM
To: Hans de Goede; Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 18 lines · Hans de Goede

Hi,

Quoted 15 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Mostly in preparation for a future where we expose an arbitrary range, say 0..100 or 0..255 to the userspace.

Quoted 8 lines

The problem with this scaling method is that scaling from user level to hw level and back to user level is ambiguous since there isn't a 1:1 mapping between the user range and the hw range.

On the other hand, this patch does fix a bug in the currently used method (scaling). That, at least, is an improvement nonetheless.

U. Artie

Apologies for resurrecting an old thread. But I think we still need to address
this issue about not having a 1:1 mapping between user and hw levels.

Right now, the problem is that the user range is larger than the hw range which
results in one or more user levels mapping to the same hw level. And when userspace requests one of those levels, the result that is reported back to userspace might not be the same as what was requested. Take for example, on my system the hw range is [398, 7812] and the user range is [0, 7812]. Suppose
userspace requests level 7017. This maps to hw level 7058. And when userspace requests the current level, 7018 is reported back (+1 from what was originally requested). In fact, with these particular ranges, there are exactly
398 values that this occurs.

This problem will be compounded the larger the difference in length of the discrete ranges; so long as user range > hw range.

Quoted 6 lines

Hans' solution would fix this problem, giving 1:1 mapping from hw to user levels.

Jani's [future] solution would work too, since exposing a smaller range to userspace than the hw range would isolate the non 1:1 mapping inside the driver.

Quoted 7 lines

I think we should just pick an arbitrary range, say 0..100, and be done with it. It's not like you'd be able to get much more than 100 distinct brightness levels out of the backlight anyway, no matter what the PWM settings.

BR,
Jani.

PS. This (totally untested) patch should do it:

drivers/gpu/drm/i915/intel_panel.c +1 -1
index b001c90312e7..a6680081415b 100644
@@ -1035,7 +1035,7 @@ static int intel_backlight_device_register(struct intel_connector *connector)
 	 * Note: Everything should work even if the backlight device max
 	 * presented to the userspace is arbitrarily chosen.
 	 */
-	props.max_brightness = panel->backlight.max;
+	props.max_brightness = 100;
 	props.brightness = scale_hw_to_user(connector,
 					    panel->backlight.level,
 					    props.max_brightness);
Quoted 57 lines
Quoted 50 lines

U. Artie

Quoted 43 lines
Quoted 32 lines

BR,
Jani.

Quoted 22 lines

Regards,

Hans

Quoted 17 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
Quoted 6 lines

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 427

Quoted 2 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	return target_val;

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw
Quoted 95 lines · On Mon, 10 Nov 2014 16:15:57 +0200 Jani Nikula <[email protected]>…
Quoted 76 lines · Jani Nikula
Quoted 67 lines · Ullysses A
Quoted 40 lines · Ullysses A
Quoted 28 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula Sent: Wednesday, September 24, 2014 10:08 AM To: Hans de Goede; Joe Konno; [email protected] Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 20 lines · Hans de Goede

Hi,

Quoted 17 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight
brightness

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

I wonder why do scaling at all, why not simply shift hw_min - hw_max range to 0 - (hw_max - hw_min) range and set max_brightness as seen by userspace to (hw_max - hw_min) ?

Mostly in preparation for a future where we expose an arbitrary range, say 0..100 or 0..255 to the userspace.

The problem with this scaling method is that scaling from user level to hw level and back to user level is ambiguous since there isn't a 1:1 mapping between the user range and the hw range.

Quoted 5 lines

On the other hand, this patch does fix a bug in the currently used method (scaling). That, at least, is an improvement nonetheless.

U. Artie

Apologies for resurrecting an old thread. But I think we still need to address
this issue about not having a 1:1 mapping between user and hw levels.

Right now, the problem is that the user range is larger than the hw range which
results in one or more user levels mapping to the same hw level. And when userspace requests one of those levels, the result that is reported back to userspace might not be the same as what was requested. Take for example, on my system the hw range is [398, 7812] and the user range is [0, 7812]. Suppose
userspace requests level 7017. This maps to hw level 7058. And when userspace requests the current level, 7018 is reported back (+1 from what was originally requested). In fact, with these particular ranges, there are exactly
398 values that this occurs.

This problem will be compounded the larger the difference in length of the discrete ranges; so long as user range > hw range.

Quoted 6 lines

Hans' solution would fix this problem, giving 1:1 mapping from hw to user levels.

Jani's [future] solution would work too, since exposing a smaller range to userspace than the hw range would isolate the non 1:1 mapping inside the driver.

Quoted 7 lines

I think we should just pick an arbitrary range, say 0..100, and be done with it. It's not like you'd be able to get much more than 100 distinct brightness levels out of the backlight anyway, no matter what the PWM settings.

BR,
Jani.

PS. This (totally untested) patch should do it:

(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_panel.c index b001c90312e7..a6680081415b 100644 --- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c

(quoted diff) +0 -0
@@ -1035,7 +1035,7 @@ static int
 intel_backlight_device_register(struct intel_connector *connector)
 	 * Note: Everything should work even if the backlight device

max

drivers/gpu/drm/i915/intel_panel.c static int intel_backlight_device_register(struct intel_connector *connector) · line 1041

Quoted 7 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
 	 * presented to the userspace is arbitrarily chosen.
 	 */
-	props.max_brightness = panel->backlight.max;
+	props.max_brightness = 100;
 	props.brightness = scale_hw_to_user(connector,
 					    panel->backlight.level,
 					    props.max_brightness);

100% agreed on exposing a fixed range. But iirc Keith did some playing around with fading in and out of backlights and found that we needed about 1000 levels to make it smooth (definitely possible on some platforms, though not all). So my only nitpick would be that we have a range that allows a bit more precision.

Thanks,
Jesse
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#8 lore raw
In reply to Joe Konno
Quoted 17 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Joe Konno
Sent: Wednesday, September 24, 2014 8:55 AM
To: [email protected]
Subject: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

Quoted 7 lines

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

Quoted 25 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -2
index f17ada3..dcdfbb3 100644
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);
 	target_val += target_min;
 
 	return target_val;
--

2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#9 lore raw
In reply to Joe Konno
Quoted 28 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..dcdfbb3 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 424

Quoted 5 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

This fails to build with CONFIG_X86_32=y:

drivers/built-in.o: In function `scale':
intel_panel.c:(.text+0x12ab38): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1

BR,
Jani.

Quoted 10 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	target_val += target_min;
 
 	return target_val;
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
#10 lore raw
Quoted 43 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Monday, September 29, 2014 6:07 AM
To: Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 28 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..dcdfbb3 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 424

Quoted 5 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

This fails to build with CONFIG_X86_32=y:

Quoted 5 lines

drivers/built-in.o: In function `scale':
intel_panel.c:(.text+0x12ab38): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1

Do you have a recommended workaround? Should we just use the v1 technique instead?

U. Artie

Quoted 21 lines

BR,
Jani.

Quoted 10 lines
drivers/gpu/drm/i915/intel_panel.c +0 -1
 	target_val += target_min;
 
 	return target_val;
--

2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw
Quoted 43 lines · Ullysses A
Quoted 43 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Monday, September 29, 2014 6:07 AM
To: Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 28 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..dcdfbb3 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 424

Quoted 5 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

This fails to build with CONFIG_X86_32=y:

Quoted 8 lines
Quoted 5 lines

drivers/built-in.o: In function `scale':
intel_panel.c:(.text+0x12ab38): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1

Do you have a recommended workaround? Should we just use the v1 technique instead?

Compromise and write DIV_ROUND_CLOSEST_ULL(). :|
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#12 lore raw
In reply to Eoff, Ullysses A
Quoted 43 lines · Ullysses A
Quoted 43 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Monday, September 29, 2014 6:07 AM
To: Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 28 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..dcdfbb3 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 424

Quoted 5 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

This fails to build with CONFIG_X86_32=y:

Quoted 8 lines
Quoted 5 lines

drivers/built-in.o: In function `scale':
intel_panel.c:(.text+0x12ab38): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1

Do you have a recommended workaround? Should we just use the v1 technique instead?

The problem is target_val is 64 bits and we're trying to do a 64 bits division with the 32bits instruction set. That is usually handled by __udivdi3 in libgcc (in userspace). We already have a DIV_ROUND_CLOSEST_ULL() that uses do_div() in intel_display.c.

Signature · 1 line
Damien
#13 lore raw
Quoted 50 lines · Damien Lespiau
Quoted 49 lines · Ullysses A
Quoted 48 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Monday, September 29, 2014 6:07 AM
To: Joe Konno; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

Quoted 28 lines · Joe Konno

From: Joe Konno <[email protected]>

Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution.

TODO: Determine how best to scale "user" values to "hw" values, and vice-versa, when the ranges are of different sizes. That would be a buggy scenario even with this work-around.

The issue was introduced in the following (v3.17-rc1) commit:

6dda730 drm/i915: respect the VBT minimum backlight brightness

v2: (thanks to Chris Wilson) clarify commit message, use rounded division macro

---
 drivers/gpu/drm/i915/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index f17ada3..dcdfbb3 100644

drivers/gpu/drm/i915/intel_panel.c static uint32_t scale(uint32_t source_val, · line 424

Quoted 5 lines
drivers/gpu/drm/i915/intel_panel.c +1 -1
@@ -421,7 +421,7 @@ static uint32_t scale(uint32_t source_val,
 	/* avoid overflows */
 	target_val = (uint64_t)(source_val - source_min) *
 		(target_max - target_min);
-	do_div(target_val, source_max - source_min);
+	target_val = DIV_ROUND_CLOSEST(target_val, source_max - source_min);

This fails to build with CONFIG_X86_32=y:

drivers/built-in.o: In function `scale':
intel_panel.c:(.text+0x12ab38): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1

Quoted 8 lines
Quoted 2 lines

Do you have a recommended workaround? Should we just use the v1 technique instead?

The problem is target_val is 64 bits and we're trying to do a 64 bits division with the 32bits instruction set. That is usually handled by __udivdi3 in libgcc (in userspace). We already have a DIV_ROUND_CLOSEST_ULL() that uses do_div() in intel_display.c.

Ok, DIV_ROUND_CLOSEST_ULL() would be the one we want I take it. Would intel_drv.h be the appropriate header to move DIV_ROUND_CLOSEST_ULL() into so that we can use it in intel_panel.c, too?

U. Artie