perf: Fixed perf trace, 32bit return values to 64bit
PATCH 1/1 perf: Fixed perf trace, 32bit return values to 64bit
perf trace for syscalls resulted in mmap return values being stripped of the top 32 bits, and actually printing only the lower 32 bits. This was because the ret value was of an 'int' type and not a 'long' type.
The Problem:
991258501.244 ( 0.004 ms): mmap(len: 40001536, prot: READ|WRITE, flags:
PRIVATE|ANONYMOUS, fd: -1) = 0x56691000 991258501.257 ( 0.000 ms): minfault [_int_malloc+0x1038] => //anon@0x7fa056691008 //(d.)
The first line shows an mmap, which succeeds and returns 0x56691000. However the next line shows a memory access to that virtual memory area, specifically to 0x7fa056691008. The upper 32 bit is lost due to the problem mentioned above, and thus mmap's return value didn't have the upper 0x7fa0.
Tested on 3.17-rc5 from the linus's tree, and the HEAD of tip/master
--- tools/perf/builtin-trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-trace.c +3 -3
@@ -1669,7 +1669,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel,union perf_event *event__maybe_unused , struct perf_sample *sample) { - int ret; + long ret;u64 duration =0 ;struct thread *thread;int id =perf_evsel__sc_tp_uint (evsel, id, sample);
@@ -1722,7 +1722,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel,if (sc->fmt ==NULL ) { signed_print: -fprintf (trace->output,") = %d" , ret); +fprintf (trace->output,") = %ld" , ret); }else if (ret <0 && sc->fmt->errmsg) {char bf[256 ]; const char *emsg = strerror_r(-ret, bf, sizeof(bf)),
@@ -1732,7 +1732,7 @@ signed_print: }else if (ret ==0 && sc->fmt->timeout)fprintf (trace->output,") = 0 Timeout" );else if (sc->fmt->hexret) -fprintf (trace->output,") = %#x" , ret); +fprintf (trace->output,") = %#lx" , ret);else goto signed_print;
Signature · 1 line
1.9.1
Em Fri, Sep 26, 2014 at 09:54:01PM +0900, Chang Hyun Park escreveu:
Quoted 10 lines
perf trace for syscalls resulted in mmap return values being stripped of the top 32 bits, and actually printing only the lower 32 bits. This was because the ret value was of an 'int' type and not a 'long' type.
The Problem:
991258501.244 ( 0.004 ms): mmap(len: 40001536, prot: READ|WRITE, flags:PRIVATE|ANONYMOUS, fd: -1) = 0x56691000 991258501.257 ( 0.000 ms): minfault [_int_malloc+0x1038] => //anon@0x7fa056691008 //(d.)
Quoted 5 lines
The first line shows an mmap, which succeeds and returns
0x56691000. However the next line shows a memory access to that virtual memory area, specifically to0x7fa056691008. The upper 32 bit is lost due to the problem mentioned above, and thus mmap's return value didn't have the upper0x7fa0.
Thanks, applied to my perf/core branch.
- Arnaldo
tip-bot for Chang Hyun Park
merge bot[tip:perf/core] perf trace: Fix mmap return address truncation to 32-bit
In reply to Chang Hyun Parkperf trace: Fix mmap return address truncation to 32-bit
Commit-ID: 2c82c3ad56921c47f28af9eb8ed96b6d99b47623 Gitweb: http://git.kernel.org/tip/2c82c3ad56921c47f28af9eb8ed96b6d99b47623 Author: Chang Hyun Park <[email protected]> AuthorDate: Fri, 26 Sep 2014 21:54:01 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 29 Sep 2014 15:25:36 -0300
perf trace: Fix mmap return address truncation to 32-bit
Using 'perf trace' for mmap is truncating return values by stripping the top 32 bits, actually printing only the lower 32 bits.
This was because the ret value was of an 'int' type and not a 'long' type.
The Problem:
991258501.244 ( 0.004 ms): mmap(len: 40001536, prot: READ|WRITE, flags: PRIVATE|ANONYMOUS, fd: -1) = 0x56691000 991258501.257 ( 0.000 ms): minfault [_int_malloc+0x1038] => //anon@0x7fa056691008 //(d.)
The first line shows an mmap, which succeeds and returns 0x56691000.
However the next line shows a memory access to that virtual memory area, specifically to 0x7fa056691008. The upper 32 bit is lost due to the problem mentioned above, and thus mmap's return value didn't have the upper 0x7fa0.
Tested on 3.17-rc5 from the linus's tree, and the HEAD of tip/master
--- tools/perf/builtin-trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/builtin-trace.c +3 -3
@@ -1695,7 +1695,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel,union perf_event *event__maybe_unused , struct perf_sample *sample) { - int ret; + long ret;u64 duration =0 ;struct thread *thread;int id =perf_evsel__sc_tp_uint (evsel, id, sample);
@@ -1748,7 +1748,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel,if (sc->fmt ==NULL ) { signed_print: -fprintf (trace->output,") = %d" , ret); +fprintf (trace->output,") = %ld" , ret); }else if (ret <0 && sc->fmt->errmsg) {char bf[STRERR_BUFSIZE ]; const char *emsg = strerror_r(-ret, bf, sizeof(bf)),
@@ -1758,7 +1758,7 @@ signed_print: }else if (ret ==0 && sc->fmt->timeout)fprintf (trace->output,") = 0 Timeout" );else if (sc->fmt->hexret) -fprintf (trace->output,") = %#x" , ret); +fprintf (trace->output,") = %#lx" , ret);else goto signed_print;