Skip to contentSkip to conversation

staging: et131x: remove unneccessary 'out of memory' message

PATCH In review Karthik Nayak 2 participants 3 messages Sep 30, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: et131x: remove unneccessary 'out of memory' message

Removes the 'out of memory' warning issues by checkpatch

---
 drivers/staging/et131x/et131x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/et131x/et131x.c +0 -1
index 41fcaa0..f1a9296 100644
@@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
 
 	skb = dev_alloc_skb(rfd->len + 2);
 	if (!skb) {
-		dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
 		return NULL;
 	}
 
Signature · 1 line
2.1.0
#1 lore raw
Quoted 12 lines · Karthik Nayak

Removes the 'out of memory' warning issues by checkpatch

---
 drivers/staging/et131x/et131x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/et131x/et131x.c +0 -0
index 41fcaa0..f1a9296 100644

drivers/staging/et131x/et131x.c static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter) · line 2427

Quoted 6 lines
drivers/staging/et131x/et131x.c +0 -1
@@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
 
        skb = dev_alloc_skb(rfd->len + 2);
        if (!skb) {
-               dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
                return NULL;
        }

Then you could also remove the braces:

if (!skb)

      return NULL;
#2 lore raw

Oops, i sent the old commit again, sorry!
Regards,
Karthik Nayak

Quoted 24 lines · Fabio Estevam
Quoted 12 lines · Karthik Nayak

Removes the 'out of memory' warning issues by checkpatch

---
 drivers/staging/et131x/et131x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/et131x/et131x.c +0 -0
index 41fcaa0..f1a9296 100644

drivers/staging/et131x/et131x.c static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter) · line 2427

Quoted 6 lines
drivers/staging/et131x/et131x.c +0 -1
@@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
 
        skb = dev_alloc_skb(rfd->len + 2);
        if (!skb) {
-               dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
                return NULL;
        }

Then you could also remove the braces:

if (!skb)

      return NULL;