cmpxchg: Discard unnecessary cast to volatile
PATCH 1/1 cmpxchg: Discard unnecessary cast to volatile
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm.
This commit removes the unnecessary volatile pointer being created.
--- arch/x86/include/asm/cmpxchg.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
arch/x86/include/asm/cmpxchg.h +4 -8
@@ -90,36 +90,32 @@ extern void __add_wrong_size(void)switch (size) { \case __X86_CASE_B: \ { \ -volatile u8 *__ptr = (volatile u8 *)(ptr); \ asmvolatile (lock"cmpxchgb %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"q" (__new),"0" (__old) \ :"memory" ); \break ; \ } \case __X86_CASE_W: \ { \ -volatile u16 *__ptr = (volatile u16 *)(ptr); \ asmvolatile (lock"cmpxchgw %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"r" (__new),"0" (__old) \ :"memory" ); \break ; \ } \case __X86_CASE_L: \ { \ -volatile u32 *__ptr = (volatile u32 *)(ptr); \ asmvolatile (lock"cmpxchgl %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"r" (__new),"0" (__old) \ :"memory" ); \break ; \ } \case __X86_CASE_Q: \ { \ -volatile u64 *__ptr = (volatile u64 *)(ptr); \ asmvolatile (lock"cmpxchgq %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"r" (__new),"0" (__old) \ :"memory" ); \break ; \
Signature · 1 line
1.9.1
ping.
Quoted 58 lines · Pranith Kumar
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm.
This commit removes the unnecessary volatile pointer being created.
Signed-off-by Pranith Kumar <[email protected]>--- arch/x86/include/asm/cmpxchg.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)arch/x86/include/asm/cmpxchg.h +4
-9@@ -90,36 +90,32 @@ extern void __add_wrong_size(void)switch (size) { \case __X86_CASE_B: \ { \ -volatile u8 *__ptr = (volatile u8 *)(ptr); \ asmvolatile (lock"cmpxchgb %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"q" (__new),"0" (__old) \ :"memory" ); \break ; \ } \case __X86_CASE_W: \ { \ -volatile u16 *__ptr = (volatile u16 *)(ptr); \ asmvolatile (lock"cmpxchgw %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"r" (__new),"0" (__old) \ :"memory" ); \break ; \ } \case __X86_CASE_L: \ { \ -volatile u32 *__ptr = (volatile u32 *)(ptr); \ asmvolatile (lock"cmpxchgl %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"r" (__new),"0" (__old) \ :"memory" ); \break ; \ } \case __X86_CASE_Q: \ { \ -volatile u64 *__ptr = (volatile u64 *)(ptr); \ asmvolatile (lock"cmpxchgq %2,%1" \ - :"=a" (__ret),"+m" (*__ptr) \ + :"=a" (__ret),"+m" (*ptr) \ :"r" (__new),"0" (__old) \ :"memory" ); \break ; \ --1.9.1
Signature · 1 line
Pranith
Quoted 6 lines · Pranith Kumar
Quoted 6 lines
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm.
This commit removes the unnecessary volatile pointer being created.
Signed-off-by Pranith Kumar <[email protected]>
Seems sane enough to me.
H. Peter Anvin
reviewerQuoted 10 lines · Peter Zijlstra
Quoted 6 lines · Pranith Kumar
Quoted 6 lines
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm.
This commit removes the unnecessary volatile pointer being created.
Signed-off-by Pranith Kumar <[email protected]>Seems sane enough to me.
However, it seems like unnecessary churn. Does the volatile hurt in any way?
-hpa
Quoted 7 lines · H. Peter Anvin
Quoted 6 lines · Peter Zijlstra
Quoted 5 lines · Pranith Kumar
Quoted 5 lines
Generating a volatile pointer is really not necessary here. This is the only location where a volatile pointer is being generated for use in asm.
This commit removes the unnecessary volatile pointer being created.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Pranith Kumar <[email protected]>Seems sane enough to me.
However, it seems like unnecessary churn. Does the volatile hurt in any way?
Removing 4 lines of unnecessary code seems to be worthwhile to me. Also, we reduce the unnecessary use of 'volatile' data types which IMHO makes this a good little clean up.
I am not sure if the use of volatile actually causes any loss of chances of optimization. I've tried to come up with cases where this happens and was unsuccessful.
Signature · 1 line
Pranith