perf top: Add a visual cue for toggle zeroing of samples
PATCH RESEND 1/1 perf top: Add a visual cue for toggle zeroing of samples
When 'perf top' is run, one can't easily find a difference between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.
Output is as below.
Before:
$ perf top
Samples: 61K of event 'cycles', Event count (approx.): 3908136933
Overhead Shared Object Symbol
1.42% firefox [.] 0x0000000000011e76
1.32% libpthread-2.17.so [.] pthread_mutex_lockIf you press key 'z' or run with zero option like '$ perf top --zero', it is as below.
After:
Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z]
Overhead Shared Object Symbol
1.42% firefox [.] 0x0000000000011e76
1.32% libpthread-2.17.so [.] pthread_mutex_lock--- tools/perf/ui/browsers/hists.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-)
tools/perf/ui/browsers/hists.c +22 -10
@@ -35,7 +35,9 @@ struct hist_browser {extern void hist_browser__init_hpp (void ); -static int hists__browser_title (struct hists *hists,char *bf,size_t size); +static int hists__browser_title (struct hists *hists, +struct hist_browser_timer *hbt, +char *bf,size_t size);static void hist_browser__update_nr_entries (struct hist_browser *hb); static struct rb_node *hists__filter_entries(struct rb_node *nd,
@@ -390,7 +392,7 @@ static int hist_browser__run(struct hist_browser *browser, browser->b.entries = &browser->hists->entries; browser->b.nr_entries =hist_browser__nr_entries (browser); -hists__browser_title (browser->hists, title,sizeof (title)); +hists__browser_title (browser->hists, hbt, title,sizeof (title));if (ui_browser__show (&browser->b, title,"Press '?' for help on key bindings" ) <0 )
@@ -417,7 +419,8 @@ static int hist_browser__run(struct hist_browser *browser,ui_browser__warn_lost_events (&browser->b); } -hists__browser_title (browser->hists, title,sizeof (title)); +hists__browser_title (browser->hists, + hbt, title,sizeof (title));ui_browser__show_title (&browser->b, title);continue ; }
@@ -1204,7 +1207,15 @@ static struct thread *hist_browser__selected_thread(struct hist_browser *browserreturn browser->he_selection->thread; } -static int hists__browser_title (struct hists *hists,char *bf,size_t size) +/* Check whether the browser is for 'top' or 'report' */ +static inline bool is_report_browser (void *timer) +{ +return timer ==NULL ; +} + +static int hists__browser_title (struct hists *hists, +struct hist_browser_timer *hbt, +char *bf,size_t size) {char unit;int printed;
@@ -1256,6 +1267,13 @@ static int hists__browser_title(struct hists *hists, char *bf, size_t size)if (dso) printed +=scnprintf (bf + printed, size - printed,", DSO: %s" , dso->short_name); +if (!is_report_browser (hbt)) { +struct perf_top *top = hbt->arg; + +if (top->zero) + printed +=scnprintf (bf + printed, size - printed," [z]" ); + } +return printed; }
@@ -1267,12 +1285,6 @@ static inline void free_popup_options(char **options, int n)zfree (&options[i]); } -/* Check whether the browser is for 'top' or 'report' */ -static inline bool is_report_browser (void *timer) -{ -return timer ==NULL ; -} -/* * Only runtime switching of perf data file will make "input_name" point * to a malloced buffer. So add "is_input_name_malloced" flag to decide
Signature · 1 line
1.8.3.2
Hi Taeung,
Quoted 16 lines · Taeung Song
When 'perf top' is run, one can't easily find a difference between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.Output is as below.
Before:
$ perf topSamples: 61K of event 'cycles', Event count (approx.): 3908136933
Overhead Shared Object Symbol 1.42% firefox [.] 0x0000000000011e76 1.32% libpthread-2.17.so [.] pthread_mutex_lockIf you press key 'z' or run with zero option like '$ perf top --zero', it is as below.
Quoted 7 lines
After:
Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z]Overhead Shared Object Symbol 1.42% firefox [.] 0x0000000000011e76 1.32% libpthread-2.17.so [.] pthread_mutex_lockSigned-off-by Taeung Song <[email protected]>
Thanks,
Namhyung
Quoted 82 lines
--- tools/perf/ui/browsers/hists.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-)tools/perf/ui/browsers/hists.c +22
-10@@ -35,7 +35,9 @@ struct hist_browser {extern void hist_browser__init_hpp (void ); -static int hists__browser_title (struct hists *hists,char *bf,size_t size); +static int hists__browser_title (struct hists *hists, +struct hist_browser_timer *hbt, +char *bf,size_t size);static void hist_browser__update_nr_entries (struct hist_browser *hb); static struct rb_node *hists__filter_entries(struct rb_node *nd,@@ -390,7 +392,7 @@ static int hist_browser__run(struct hist_browser *browser, browser->b.entries = &browser->hists->entries; browser->b.nr_entries =hist_browser__nr_entries (browser); -hists__browser_title (browser->hists, title,sizeof (title)); +hists__browser_title (browser->hists, hbt, title,sizeof (title));if (ui_browser__show (&browser->b, title,"Press '?' for help on key bindings" ) <0 )@@ -417,7 +419,8 @@ static int hist_browser__run(struct hist_browser *browser,ui_browser__warn_lost_events (&browser->b); } -hists__browser_title (browser->hists, title,sizeof (title)); +hists__browser_title (browser->hists, + hbt, title,sizeof (title));ui_browser__show_title (&browser->b, title);continue ; }@@ -1204,7 +1207,15 @@ static struct thread *hist_browser__selected_thread(struct hist_browser *browserreturn browser->he_selection->thread; } -static int hists__browser_title (struct hists *hists,char *bf,size_t size) +/* Check whether the browser is for 'top' or 'report' */ +static inline bool is_report_browser (void *timer) +{ +return timer ==NULL ; +} + +static int hists__browser_title (struct hists *hists, +struct hist_browser_timer *hbt, +char *bf,size_t size) {char unit;int printed;@@ -1256,6 +1267,13 @@ static int hists__browser_title(struct hists *hists, char *bf, size_t size)if (dso) printed +=scnprintf (bf + printed, size - printed,", DSO: %s" , dso->short_name); +if (!is_report_browser (hbt)) { +struct perf_top *top = hbt->arg; + +if (top->zero) + printed +=scnprintf (bf + printed, size - printed," [z]" ); + } +return printed; }@@ -1267,12 +1285,6 @@ static inline void free_popup_options(char **options, int n)zfree (&options[i]); } -/* Check whether the browser is for 'top' or 'report' */ -static inline bool is_report_browser (void *timer) -{ -return timer ==NULL ; -} -/* * Only runtime switching of perf data file will make "input_name" point * to a malloced buffer. So add "is_input_name_malloced" flag to decide
Em Wed, Oct 08, 2014 at 09:48:48AM +0900, Namhyung Kim escreveu:
Quoted 25 lines
Hi Taeung,
Quoted 22 lines · Taeung Song
When 'perf top' is run, one can't easily find a difference between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.Output is as below.
Before:
$ perf topSamples: 61K of event 'cycles', Event count (approx.): 3908136933
Overhead Shared Object Symbol 1.42% firefox [.] 0x0000000000011e76 1.32% libpthread-2.17.so [.] pthread_mutex_lockIf you press key 'z' or run with zero option like '$ perf top --zero', it is as below.
After:
Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z]Overhead Shared Object Symbol 1.42% firefox [.] 0x0000000000011e76 1.32% libpthread-2.17.so [.] pthread_mutex_lock
Quoted 3 lines
Quoted 1 line
Signed-off-by Taeung Song <[email protected]>Acked-by Namhyung Kim <[email protected]>
Thanks, applied.
- Arnaldo
tip-bot for Taeung Song
merge botperf top: Add a visual cue for toggle zeroing of samples
Commit-ID: 1e378ebd117d1828b9d5dbe0538887478fcb9d84 Gitweb: http://git.kernel.org/tip/1e378ebd117d1828b9d5dbe0538887478fcb9d84 Author: Taeung Song <[email protected]> AuthorDate: Tue, 7 Oct 2014 16:13:15 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 15 Oct 2014 15:47:48 -0300
perf top: Add a visual cue for toggle zeroing of samples
When 'perf top' is run, one can't easily find a difference between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.
Output is as below.
Before:
$ perf top
Samples: 61K of event 'cycles', Event count (approx.): 3908136933
Overhead Shared Object Symbol
1.42% firefox [.] 0x0000000000011e76
1.32% libpthread-2.17.so [.] pthread_mutex_lockIf you press key 'z' or run with zero option like '$ perf top --zero', it is as below.
After:
Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z]
Overhead Shared Object Symbol
1.42% firefox [.] 0x0000000000011e76
1.32% libpthread-2.17.so [.] pthread_mutex_lock--- tools/perf/ui/browsers/hists.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-)
tools/perf/ui/browsers/hists.c +22 -10
@@ -35,7 +35,9 @@ struct hist_browser {extern void hist_browser__init_hpp (void ); -static int hists__browser_title (struct hists *hists,char *bf,size_t size); +static int hists__browser_title (struct hists *hists, +struct hist_browser_timer *hbt, +char *bf,size_t size);static void hist_browser__update_nr_entries (struct hist_browser *hb); static struct rb_node *hists__filter_entries(struct rb_node *nd,
@@ -390,7 +392,7 @@ static int hist_browser__run(struct hist_browser *browser, browser->b.entries = &browser->hists->entries; browser->b.nr_entries =hist_browser__nr_entries (browser); -hists__browser_title (browser->hists, title,sizeof (title)); +hists__browser_title (browser->hists, hbt, title,sizeof (title));if (ui_browser__show (&browser->b, title,"Press '?' for help on key bindings" ) <0 )
@@ -417,7 +419,8 @@ static int hist_browser__run(struct hist_browser *browser,ui_browser__warn_lost_events (&browser->b); } -hists__browser_title (browser->hists, title,sizeof (title)); +hists__browser_title (browser->hists, + hbt, title,sizeof (title));ui_browser__show_title (&browser->b, title);continue ; }
@@ -1204,7 +1207,15 @@ static struct thread *hist_browser__selected_thread(struct hist_browser *browserreturn browser->he_selection->thread; } -static int hists__browser_title (struct hists *hists,char *bf,size_t size) +/* Check whether the browser is for 'top' or 'report' */ +static inline bool is_report_browser (void *timer) +{ +return timer ==NULL ; +} + +static int hists__browser_title (struct hists *hists, +struct hist_browser_timer *hbt, +char *bf,size_t size) {char unit;int printed;
@@ -1258,6 +1269,13 @@ static int hists__browser_title(struct hists *hists, char *bf, size_t size)if (dso) printed +=scnprintf (bf + printed, size - printed,", DSO: %s" , dso->short_name); +if (!is_report_browser (hbt)) { +struct perf_top *top = hbt->arg; + +if (top->zero) + printed +=scnprintf (bf + printed, size - printed," [z]" ); + } +return printed; }
@@ -1269,12 +1287,6 @@ static inline void free_popup_options(char **options, int n)zfree (&options[i]); } -/* Check whether the browser is for 'top' or 'report' */ -static inline bool is_report_browser (void *timer) -{ -return timer ==NULL ; -} -/* * Only runtime switching of perf data file will make "input_name" point * to a malloced buffer. So add "is_input_name_malloced" flag to decide