Skip to contentSkip to conversation

drm/i915: remove bogus intel_increase_pllclock

PATCH In review Mika Kuoppala 3 participants 3 messages Oct 7, 2014 – Oct 9, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: remove bogus intel_increase_pllclock

commit b680c37a4d145cf4d8f2b24e46b1163e5ceb1d35

Author: Daniel Vetter <[email protected]>
Date:   Fri Sep 19 18:27:27 2014 +0200

drm/i915: DocBook integration for frontbuffer tracking

Moved the code to intel_frontbuffer.c but this bit got stranded.

---
 drivers/gpu/drm/i915/intel_display.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -2
index 1363a93..cbe2a5d 100644
@@ -73,8 +73,6 @@ static const uint32_t intel_cursor_formats[] = {
 	DRM_FORMAT_ARGB8888,
 };
 
-static void intel_increase_pllclock(struct drm_device *dev,
-				    enum pipe pipe);
 static void intel_crtc_update_cursor(struct drm_crtc *crtc, bool on);
 
 static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw

2014-10-07 12:15 GMT-03:00 Mika Kuoppala <[email protected]>:

Quoted 10 lines

commit b680c37a4d145cf4d8f2b24e46b1163e5ceb1d35

Author: Daniel Vetter <[email protected]>
Date:   Fri Sep 19 18:27:27 2014 +0200

drm/i915: DocBook integration for frontbuffer tracking

Moved the code to intel_frontbuffer.c but this bit got stranded.

Fixes the following warning:
drivers/gpu/drm/i915/intel_display.c:76:13: warning:
‘intel_increase_pllclock’ declared ‘static’ but never defined [-Wunused-function]

I just noticed that intel_decrease_pllclock() is still on intel_display.c. It's kinda weird to have the increase() function in one file and the decrease() function in another. Maybe our layering/abstraction could be improved... Daniel?

Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_display.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -3
index 1363a93..cbe2a5d 100644
@@ -73,8 +73,6 @@ static const uint32_t intel_cursor_formats[] = {
        DRM_FORMAT_ARGB8888,
 };
 
-static void intel_increase_pllclock(struct drm_device *dev,
-                                   enum pipe pipe);
 static void intel_crtc_update_cursor(struct drm_crtc *crtc, bool on);
 
 static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
--

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 9 lines · Paulo Zanoni

2014-10-07 12:15 GMT-03:00 Mika Kuoppala <[email protected]>:

Quoted 8 lines

commit b680c37a4d145cf4d8f2b24e46b1163e5ceb1d35

Author: Daniel Vetter <[email protected]>
Date:   Fri Sep 19 18:27:27 2014 +0200

drm/i915: DocBook integration for frontbuffer tracking

Moved the code to intel_frontbuffer.c but this bit got stranded.

It's a borked merge that resurrected this function by accident, fixed. The commit itself is good.

Quoted 9 lines
Quoted 1 line

Fixes the following warning:
drivers/gpu/drm/i915/intel_display.c:76:13: warning:
‘intel_increase_pllclock’ declared ‘static’ but never defined [-Wunused-function]

Quoted 4 lines

I just noticed that intel_decrease_pllclock() is still on intel_display.c. It's kinda weird to have the increase() function in one file and the decrease() function in another. Maybe our layering/abstraction could be improved... Daniel?

My plan is to rework the old DRRS code on top of the new code, once that has landed. With that we should be able to ditch this confusion here. -Daniel

Quoted 30 lines
Quoted 21 lines
---
 drivers/gpu/drm/i915/intel_display.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -3
index 1363a93..cbe2a5d 100644
@@ -73,8 +73,6 @@ static const uint32_t intel_cursor_formats[] = {
        DRM_FORMAT_ARGB8888,
 };
 
-static void intel_increase_pllclock(struct drm_device *dev,
-                                   enum pipe pipe);
 static void intel_crtc_update_cursor(struct drm_crtc *crtc, bool on);
 
 static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
--

1.9.1

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx