tests/kms_force_connector: ensure igt_exit is called at exit
PATCH 1/2 tests/kms_force_connector: ensure igt_exit is called at exit
Since commit 5782eca (lib/igt_core.c: disable lowmemorykiller during tests), igt_exit needs to be called before the test exits.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771
--- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_force_connector.c +1 -1
@@ -116,5 +116,5 @@ main (int argc, char **argv)drmModeFreeConnector (connector); -igt_success (); +igt_exit (); }
Signature · 1 line
2.1.0
PATCH 2/2 tests/kms_force_connect: skip if a VGA connector is not available
--- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_force_connector.c +1 -1
@@ -54,7 +54,7 @@ main (int argc, char **argv) connector =NULL ; } -igt_assert (connector); +igt_require (connector);/* force the connector on and check the reported values */ kmstest_force_connector (drm_fd, connector,FORCE_CONNECTOR_ON );
Signature · 1 line
2.1.0
Re: [PATCH i-g-t 2/2] tests/kms_force_connect: skip if a VGA connector is not available
Quoted 10 lines · Thomas Wood
Signed-off-by Thomas Wood <[email protected]>--- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_force_connector.c +0
-0
tests/kms_force_connector.c main (int argc, char **argv) · line 57
Quoted 5 lines
tests/kms_force_connector.c +1
-1@@ -54,7 +54,7 @@ main (int argc, char **argv) connector =NULL ; } -igt_assert (connector); +igt_require (connector);
If you rename this vga_connector, the error message will be immediately understandable.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 8 lines
-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Thursday, October 09, 2014 4:51 PM
To: [email protected]
Cc: Gore, Tim
Subject: [PATCH i-g-t 1/2] tests/kms_force_connector: ensureigt_exitis called at exit
Quoted 6 lines
Since commit 5782eca (
lib/igt_core.c: disable lowmemorykiller during tests),igt_exitneeds to be called before the test exits.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771
Cc Tim Gore <[email protected]>Signed-off-by Thomas Wood <[email protected]>
Hi Thomas, did you see Paulo's suggestion about replacing igt_assert(connector) with igt_require(connector). Does this make sense. I'm not sure if any systems truly have no vga "connector", but certainly on my harris beach (ultrabook) there Is no externally accessible vga.
Or perhaps you would prefer that to be a separate commit.
Tim
Quoted 17 lines
--- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_force_connector.c +1
-2@@ -116,5 +116,5 @@ main (int argc, char **argv)drmModeFreeConnector (connector); -igt_success (); +igt_exit (); } --2.1.0
Quoted 15 lines · Tim
Quoted 8 lines
-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Thursday, October 09, 2014 4:51 PM
To: [email protected]
Cc: Gore, Tim
Subject: [PATCH i-g-t 1/2] tests/kms_force_connector: ensureigt_exitis called at exitQuoted 6 lines
Since commit 5782eca (
lib/igt_core.c: disable lowmemorykiller during tests),igt_exitneeds to be called before the test exits.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771
Cc Tim Gore <[email protected]>Signed-off-by Thomas Wood <[email protected]>
Quoted 5 lines
Hi Thomas, did you see Paulo's suggestion about replacing
igt_assert(connector)withigt_require(connector). Does this make sense. I'm not sure if any systems truly have no vga "connector", but certainly on my harris beach (ultrabook) there Is no externally accessible vga.
Or perhaps you would prefer that to be a separate commit.
Yes, it's addressed in patch 2 of this series.
Quoted 24 lines
Tim
Quoted 17 lines
--- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_force_connector.c +1
-2@@ -116,5 +116,5 @@ main (int argc, char **argv)drmModeFreeConnector (connector); -igt_success (); +igt_exit (); } --2.1.0
Quoted 26 lines
-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Thursday, October 09, 2014 5:10 PM
To: Gore, Tim
Cc: [email protected]
Subject: Re: [PATCH i-g-t 1/2] tests/kms_force_connector: ensureigt_exitis called at exitQuoted 15 lines · Tim
Quoted 14 lines
-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Thursday, October 09, 2014 4:51 PM
To: [email protected]
Cc: Gore, Tim
Subject: [PATCH i-g-t 1/2] tests/kms_force_connector: ensureigt_exitis called at exitSince commit 5782eca (
lib/igt_core.c: disable lowmemorykiller during tests),igt_exitneeds to be called before the test exits.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771
Cc Tim Gore <[email protected]>Signed-off-by Thomas Wood <[email protected]>
Quoted 9 lines
Quoted 4 lines
Hi Thomas, did you see Paulo's suggestion about replacing
igt_assert(connector)withigt_require(connector). Does this make sense. I'm not sure if any systems truly have no vga "connector", but certainly on my harris beach (ultrabook) there Is no externally accessiblevga.
Quoted 1 line
Or perhaps you would prefer that to be a separate commit.
Yes, it's addressed in patch 2 of this series.
OK, this patch looks fine to me
Quoted 24 lines
Quoted 24 lines
Tim
Quoted 17 lines
--- tests/kms_force_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/tests/kms_force_connector.cindex 5b19794..96881c7 100644tests/kms_force_connector.c +1
-2@@ -116,5 +116,5 @@ main (int argc, char **argv)drmModeFreeConnector (connector); -igt_success (); +igt_exit (); } --2.1.0