Skip to contentSkip to conversation

Kconfig: Add EXPERT option

PATCH New Tom Rini 3 participants 4 messages Oct 14, 2014 – Oct 18, 2014

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Kconfig: Add EXPERT option

For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.

---
 Kconfig |    8 ++++++++
 1 file changed, 8 insertions(+)
Kconfig +8 -0
index e0c8992..73785b00 100644
@@ -58,6 +58,14 @@ config CC_OPTIMIZE_FOR_SIZE
 
 endmenu		# General setup
 
+menuconfig EXPERT
+        bool "Configure standard U-Boot features (expert users)"
+        help
+          This option allows certain base U-Boot options and settings
+          to be disabled or tweaked. This is for specialized
+          environments which can tolerate a "non-standard" U-Boot.
+          Only use this if you really know what you are doing.
+
 menu "Boot images"
 
 config SPL_BUILD
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Kconfig: Add EXPERT option

Hi Tom,

Quoted 18 lines · Tom Rini

For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.

---
 Kconfig |    8 ++++++++
 1 file changed, 8 insertions(+)
Kconfig +1 -0
index e0c8992..73785b00 100644
@@ -58,6 +58,14 @@ config CC_OPTIMIZE_FOR_SIZE
 
 endmenu		# General setup
 
+menuconfig EXPERT

Kconfig config CC_OPTIMIZE_FOR_SIZE · line 71

Quoted 10 lines
Kconfig +7 -0
+        bool "Configure standard U-Boot features (expert users)"
+        help
+          This option allows certain base U-Boot options and settings
+          to be disabled or tweaked. This is for specialized
+          environments which can tolerate a "non-standard" U-Boot.
+          Only use this if you really know what you are doing.
+
 menu "Boot images"
 
 config SPL_BUILD

Half-OT: we have a policy of not adding dead code in U-Boot. Here, this Kconfig change introduces CONFIG_EXPERT, but nowhere in the code is it used. Should we consider this dead code as well (and thus, expect/accept it only in a patch series where the EXPERT config is used somewhere else in the code) or not?

Amicalement,

Signature · 1 line
Albert.
author
#2 lore raw

PATCH 1/1 Kconfig: Add EXPERT option

Quoted 31 lines · Albert ARIBAUD

Hi Tom,

Quoted 27 lines · Tom Rini

For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.

---
 Kconfig |    8 ++++++++
 1 file changed, 8 insertions(+)
Kconfig +8 -0
index e0c8992..73785b00 100644
@@ -58,6 +58,14 @@ config CC_OPTIMIZE_FOR_SIZE
 
 endmenu		# General setup
 
+menuconfig EXPERT
+        bool "Configure standard U-Boot features (expert users)"
+        help
+          This option allows certain base U-Boot options and settings
+          to be disabled or tweaked. This is for specialized
+          environments which can tolerate a "non-standard" U-Boot.
+          Only use this if you really know what you are doing.
+
 menu "Boot images"
 
Quoted 7 lines

Kconfig config CC_OPTIMIZE_FOR_SIZE · line 71

Quoted 1 line
Kconfig +0 -0
 config SPL_BUILD

Half-OT: we have a policy of not adding dead code in U-Boot. Here, this Kconfig change introduces CONFIG_EXPERT, but nowhere in the code is it used. Should we consider this dead code as well (and thus, expect/accept it only in a patch series where the EXPERT config is used somewhere else in the code) or not?

I told Michal Simek to wait until I posted this to follow up and post a
patch adding something else which will make use of this. And depending
on time, I may get there first and make use of this for other conersions as well.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141015/59604d67/attachment.pgp>
#3 lore raw

PATCH 1/1 Kconfig: Add EXPERT option

2014-10-15 15:08 GMT+09:00 Tom Rini <[email protected]>:

Quoted 10 lines · Albert ARIBAUD
Quoted 9 lines

Hi Tom,

Quoted 5 lines · Tom Rini

For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.

Signature · 2 lines
Best Regards
Masahiro Yamada