Skip to contentSkip to conversation

drm/i915: add runtime PM get/put call in i915_execlists

PATCH Applied Michel Thierry 2 participants 2 messages Oct 16, 2014 – Oct 21, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: add runtime PM get/put call in i915_execlists

Otherwise we will get WARNs when we read context status registers and the machine is suspended.

Testcase: igt/pm_rpm/debugfs-read

---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +3 -0
index df9084d..d1552d0 100644
@@ -1857,6 +1857,8 @@ static int i915_execlists(struct seq_file *m, void *data)
 	if (ret)
 		return ret;
 
+	intel_runtime_pm_get(dev_priv);
+
 	for_each_ring(ring, dev_priv, ring_id) {
 		struct intel_ctx_submit_request *head_req = NULL;
 		int count = 0;
@@ -1908,6 +1910,7 @@ static int i915_execlists(struct seq_file *m, void *data)
 		seq_putc(m, '\n');
 	}
 
+	intel_runtime_pm_put(dev_priv);
 	mutex_unlock(&dev->struct_mutex);
 
 	return 0;
Signature · 1 line
2.1.1
#1 lore raw
Quoted 5 lines · Michel Thierry

Otherwise we will get WARNs when we read context status registers and the machine is suspended.

Testcase: igt/pm_rpm/debugfs-read

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch