Skip to contentSkip to conversation

seq_file: Remove pointless assignment in seq_read()

PATCH New Jan Kara 1 participant 1 message Oct 21, 2014 VFS

lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH 1/1 seq_file: Remove pointless assignment in seq_read()

The value assigned to 'err' in seq_read() is overwritten by the result of copy_to_user(). This is correct because we know we have succeeded to generate at least one entry into user buffer so the error we got when generating further entries is irrelevant. Just remove the assignment.

Coverity-id: 1226981

---
 fs/seq_file.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/seq_file.c +1 -3
index 3857b720cb1b..cf53252e4784 100644
@@ -262,10 +262,8 @@ Fill:
 		size_t offs = m->count;
 		loff_t next = pos;
 		p = m->op->next(m, p, &next);
-		if (!p || IS_ERR(p)) {
-			err = PTR_ERR(p);
+		if (!p || IS_ERR(p))
 			break;
-		}
 		err = m->op->show(m, p);
 		if (seq_overflow(m) || err) {
 			m->count = offs;
Signature · 1 line
1.8.1.4