perf/urgent fix
Arnaldo Carvalho de Melo
maintainerHi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 3b10ea7f922b538ba5dcb3d979a6b6b4d07daae2:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-10-18 09:04:02 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to 9ab1f50876dbb8b962db058259be7aae920d4c25:
perf diff: Add missing hists__init() call at tool start (2014-10-22 16:31:06 -0300)
----------------------------------------------------------------
perf/urgent fix:
* Fix 'perf diff' initialization, calling the recently added hists__init() function so that extra space is allocated per perf_evsel for the hists storage that it also uses, just like report and top. (Kan Liang)
----------------------------------------------------------------
Kan Liang (1):
perf diff: Add missing hists__init() call at tool start
tools/perf/builtin-diff.c | 5 +++++ 1 file changed, 5 insertions(+)
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf diff: Add missing hists__init() call at tool start
From: Kan Liang <[email protected]>
It also uses hists/hist_entries, hists__init() should be called before creating any evsels.
Otherwise no extra space will be allocated per perf_evsel nor this space will be initialized when allocating a new perf_evsel instance, resulting in reads/writes to non allocated space, oops. Fix it.
--- tools/perf/builtin-diff.c | 5 +++++ 1 file changed, 5 insertions(+)
tools/perf/builtin-diff.c +5 -0
@@ -1142,6 +1142,11 @@ static int data_init(int argc, const char **argv)int cmd_diff (int argc,const char **argv,const char *prefix__maybe_unused ) { +int ret =hists__init (); + +if (ret <0 ) +return ret; +perf_config (perf_default_config,NULL ); argc =parse_options (argc, argv, options, diff_usage,0 );
Signature · 1 line
1.9.3
Quoted 26 lines · Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit
3b10ea7f922b538ba5dcb3d979a6b6b4d07daae2:Merge tag 'perf-core-for-mingo' of
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linuxinto perf/urgent (2014-10-18 09:04:02 +0200)are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.gittags/perf-urgent-for-mingofor you to fetch changes up to
9ab1f50876dbb8b962db058259be7aae920d4c25:perf diff: Add missing
hists__init()call at tool start (2014-10-22 16:31:06 -0300)----------------------------------------------------------------
perf/urgent fix:* Fix 'perf diff' initialization, calling the recently added
hists__init()function so that extra space is allocated perperf_evselfor the hists storage that it also uses, just like report and top. (Kan Liang)
Quoted 8 lines
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>----------------------------------------------------------------
Kan Liang (1):
perf diff: Add missinghists__init()call at tool starttools/perf/builtin-diff.c | 5 +++++ 1 file changed, 5 insertions(+)
Pulled, thanks a lot Arnaldo!
Ingo