drm/panel: ld9040: Update calls to gpiod_get*()
Subsystems (3)
PATCH 1/1 drm/panel: ld9040: Update calls to gpiod_get*()
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
--- drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/gpu/drm/panel/panel-ld9040.c +1 -6
@@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi)if (ret <0 )return ret; - ctx->reset_gpio =devm_gpiod_get (dev,"reset" ); + ctx->reset_gpio =devm_gpiod_get (dev,"reset" ,GPIOD_OUT_HIGH );if (IS_ERR (ctx->reset_gpio)) {dev_err (dev,"cannot get reset-gpios %ld\n" ,PTR_ERR (ctx->reset_gpio));return PTR_ERR (ctx->reset_gpio); } - ret =gpiod_direction_output (ctx->reset_gpio,1 ); -if (ret <0 ) { -dev_err (dev,"cannot configure reset-gpios %d\n" , ret); -return ret; - } spi->bits_per_word =9 ; ret =spi_setup (spi);
Signature · 1 line
2.1.2
Quoted 10 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.Signed-off-by Alexandre Courbot <[email protected]>
It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this:
--
Regards
Andrzej
Quoted 28 lines
--- drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)drivers/gpu/drm/panel/panel-ld9040.c +1
-6@@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi)if (ret <0 )return ret; - ctx->reset_gpio =devm_gpiod_get (dev,"reset" ); + ctx->reset_gpio =devm_gpiod_get (dev,"reset" ,GPIOD_OUT_HIGH );if (IS_ERR (ctx->reset_gpio)) {dev_err (dev,"cannot get reset-gpios %ld\n" ,PTR_ERR (ctx->reset_gpio));return PTR_ERR (ctx->reset_gpio); } - ret =gpiod_direction_output (ctx->reset_gpio,1 ); -if (ret <0 ) { -dev_err (dev,"cannot configure reset-gpios %d\n" , ret); -return ret; - } spi->bits_per_word =9 ; ret =spi_setup (spi);
Quoted 10 lines · Andrzej Hajda
Quoted 9 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
Quoted 6 lines
Quoted 1 line
Signed-off-by Alexandre Courbot <[email protected]>It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this:
Acked-by Andrzej Hajda <[email protected]>
The required patch is now merged, can we go on with this patch?
Quoted 11 lines · Alexandre Courbot
Quoted 10 lines · Andrzej Hajda
Quoted 9 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Alexandre Courbot <[email protected]>It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this:
Acked-by Andrzej Hajda <[email protected]>The required patch is now merged, can we go on with this patch?
Yes, for both panels. Thanks.
Regards
Andrzej
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Thierry Reding
AppliedQuoted 9 lines · Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards.
Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <
linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary.
Quoted 4 lines
Signed-off-by Alexandre Courbot <[email protected]>--- drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel