checkpatch: Try to avoid mask and shift errors

PATCH New Joe Perches 1 participant 1 message Oct 27, 2014 Checkpatch

Share & tools

Joe Perches

author maintainer

2014-10-27 05:33 UTC #0 lore raw

PATCH 1/1 checkpatch: Try to avoid mask and shift errors

Shift has a higher precedence that mask so warn when a mask then shift operation is done without parentheses around the mask.

This test works well for a right shift, but the left shift is pretty commonly done correctly so only warn on the right shift.

Signed-off-by Joe Perches <[email protected]>

---
 scripts/checkpatch.pl | 8 ++++++++
 1 file changed, 8 insertions(+)

scripts/checkpatch.pl +8 -0

index d94f5d8..9b474d5 100755
@@ -4478,6 +4478,14 @@ sub process {
 			}
 		}
 
+# check for mask then right shift without a parentheses
+		if ($^V && $^V ge 5.10.0 &&
+		    $line =~ /$LvalOrFunc\s*\&\s*($LvalOrFunc)\s*>>/ &&
+		    $4 !~ /^\&/) { # $LvalOrFunc may be &foo, ignore if so
+			WARN("MASK_THEN_SHIFT",
+			     "Possible precedence defect with mask then right shift - may need parentheses\n" . $herecurr);
+		}
+
 # check for bad placement of section $InitAttribute (e.g.: __initdata)
 		if ($line =~ /(\b$InitAttribute\b)/) {
 			my $attr = $1;