Skip to contentSkip to conversation

arm: mvebu: maxbcm: Fix compilation warning and add Spansion SPI NOR support

PATCH New Stefan Roese 2 participants 2 messages Oct 27, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: maxbcm: Fix compilation warning and add Spansion SPI NOR support

This patch fixes the following compilation warning for maxbcm:

Building maxbcm board...
text data bss dec hex filename
160075 6596 38240 204911 3206f ./u-boot
board/maxbcm/maxbcm.c: In function 'reset_phy':
board/maxbcm/maxbcm.c:68:6: warning: unused variable 'reg' [-Wunused-variable]

  u16 reg;
      ^
board/maxbcm/maxbcm.c:66:6: warning: unused variable 'devadr' [-Wunused-variable]
  u16 devadr = CONFIG_PHY_BASE_ADDR;
      ^

Additionally support Spansion SPI NOR flash is added. With larger SPI device support via the CONFIG_SPI_FLASH_BAR define.

---
 board/maxbcm/maxbcm.c    | 2 --
 include/configs/maxbcm.h | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)
board/maxbcm/maxbcm.c +0 -2
index 7fc83ee..94c688f 100644
@@ -63,9 +63,7 @@ int checkboard(void)
 /* Configure and enable MV88E6185 switch */
 void reset_phy(void)
 {
-	u16 devadr = CONFIG_PHY_BASE_ADDR;
 	char *name = "neta0";
-	u16 reg;
 
 	if (miiphy_set_current_dev(name))
 		return;
include/configs/maxbcm.h +2 -0
index 72217bd..005e136 100644
@@ -43,6 +43,8 @@
 #define CONFIG_SF_DEFAULT_SPEED		1000000
 #define CONFIG_SF_DEFAULT_MODE		SPI_MODE_3
 #define CONFIG_SPI_FLASH_STMICRO
+#define CONFIG_SPI_FLASH_SPANSION
+#define CONFIG_SPI_FLASH_BAR
 
 /* Environment in SPI NOR flash */
 #define CONFIG_ENV_IS_IN_SPI_FLASH
Signature · 1 line
2.1.2
#1 lore raw

PATCH 1/1 arm: mvebu: maxbcm: Fix compilation warning and add Spansion SPI NOR support

Quoted 41 lines · Stefan Roese

This patch fixes the following compilation warning for maxbcm:

Building maxbcm board...
text data bss dec hex filename
160075 6596 38240 204911 3206f ./u-boot
board/maxbcm/maxbcm.c: In function 'reset_phy':
board/maxbcm/maxbcm.c:68:6: warning: unused variable 'reg' [-Wunused-variable]

  u16 reg;
      ^
board/maxbcm/maxbcm.c:66:6: warning: unused variable 'devadr' [-Wunused-variable]
  u16 devadr = CONFIG_PHY_BASE_ADDR;
      ^

Additionally support Spansion SPI NOR flash is added. With larger SPI device support via the CONFIG_SPI_FLASH_BAR define.

---
 board/maxbcm/maxbcm.c    | 2 --
 include/configs/maxbcm.h | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)
board/maxbcm/maxbcm.c +0 -2
index 7fc83ee..94c688f 100644
@@ -63,9 +63,7 @@ int checkboard(void)
 /* Configure and enable MV88E6185 switch */
 void reset_phy(void)
 {
-       u16 devadr = CONFIG_PHY_BASE_ADDR;
        char *name = "neta0";
-       u16 reg;
 
        if (miiphy_set_current_dev(name))
                return;
include/configs/maxbcm.h +0 -0
index 72217bd..005e136 100644

include/configs/maxbcm.h line 50

Quoted 8 lines
include/configs/maxbcm.h +2 -0
@@ -43,6 +43,8 @@
 #define CONFIG_SF_DEFAULT_SPEED                1000000
 #define CONFIG_SF_DEFAULT_MODE         SPI_MODE_3
 #define CONFIG_SPI_FLASH_STMICRO
+#define CONFIG_SPI_FLASH_SPANSION
+#define CONFIG_SPI_FLASH_BAR
 
 /* Environment in SPI NOR flash */
 #define CONFIG_ENV_IS_IN_SPI_FLASH

thanks!

Signature · 1 line
Jagan.