Skip to contentSkip to conversation

iser: fix local conn params being reset to default

PATCH Applied Roi Dayan 3 participants 5 messages Oct 28, 2014 – Oct 29, 2014 Kbuild

lore
Share & tools
lore

Roi Dayan

author
#0 lore raw

PATCH 1/1 iser: fix local conn params being reset to default

Instead of reseting the params to default if they pass it we should reset to max if they pass it.

---
 usr/iscsi/iser_text.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
usr/iscsi/iser_text.c +2 -2
index 8180dbc..b8c5136 100644
@@ -342,8 +342,8 @@ static int iser_login_check_params(struct iscsi_connection *iscsi_conn,
 		if (p[i].state == KEY_STATE_START && p[i].val != session_keys[i].def) {
 			if (iscsi_conn->state == STATE_LOGIN) {
 				if (i >= ISCSI_PARAM_FIRST_LOCAL) {
-					if (p[i].val > session_keys[i].def)
-						p[i].val = session_keys[i].def;
+					if (p[i].val > session_keys[i].max)
+						p[i].val = session_keys[i].max;
 					p[i].state = KEY_STATE_DONE;
 					continue;
 				}
Signature · 1 line
1.8.4.3
#1 lore raw
Quoted 7 lines · On Tue, 28 Oct 2014 17:41:06 +0200 Roi Dayan <[email protected]> wrote:

Instead of reseting the params to default if they pass it we should reset to max if they pass it.

---
 usr/iscsi/iser_text.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks!

#2 lore raw
In reply to Roi Dayan
Quoted 2 lines · Roi Dayan

Instead of reseting the params to default if they pass it we should reset to max if they pass it.

who are they? can you remind me what are the local params?

Or.

Quoted 21 lines
---
  usr/iscsi/iser_text.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
usr/iscsi/iser_text.c +2 -2
index 8180dbc..b8c5136 100644
@@ -342,8 +342,8 @@ static int iser_login_check_params(struct iscsi_connection *iscsi_conn,
  		if (p[i].state == KEY_STATE_START && p[i].val != session_keys[i].def) {
  			if (iscsi_conn->state == STATE_LOGIN) {
  				if (i >= ISCSI_PARAM_FIRST_LOCAL) {
-					if (p[i].val > session_keys[i].def)
-						p[i].val = session_keys[i].def;
+					if (p[i].val > session_keys[i].max)
+						p[i].val = session_keys[i].max;
  					p[i].state = KEY_STATE_DONE;
  					continue;
  				}
author
#3 lore raw

Local params:

MaxXmitDataSegmentLength
MaxQueueCmd

-----Original Message-----
From: Or Gerlitz
Sent: Wednesday, October 29, 2014 7:52 AM
To: Roi Dayan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] iser: fix local conn params being reset to default

Quoted 2 lines · Roi Dayan

Instead of reseting the params to default if they pass it we should reset to max if they pass it.

who are they? can you remind me what are the local params?

Or.

Quoted 21 lines
---
  usr/iscsi/iser_text.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
usr/iscsi/iser_text.c index renamed from usr/iscsi/iser_text.c +0 -0

8180dbc..b8c5136 100644

usr/iscsi/iser_text.c +2 -2
@@ -342,8 +342,8 @@ static int iser_login_check_params(struct iscsi_connection *iscsi_conn,
  		if (p[i].state == KEY_STATE_START && p[i].val != session_keys[i].def) {
  			if (iscsi_conn->state == STATE_LOGIN) {
  				if (i >= ISCSI_PARAM_FIRST_LOCAL) {
-					if (p[i].val > session_keys[i].def)
-						p[i].val = session_keys[i].def;
+					if (p[i].val > session_keys[i].max)
+						p[i].val = session_keys[i].max;
  					p[i].state = KEY_STATE_DONE;
  					continue;
  				}
author
#4 lore raw
In reply to Or Gerlitz

"they" is referred to the user. I'll make it more informative next time.

-----Original Message-----
From: Roi Dayan
Sent: Wednesday, October 29, 2014 8:37 AM
To: Or Gerlitz
Cc: [email protected]; [email protected]
Subject: RE: [PATCH] iser: fix local conn params being reset to default

Local params:

MaxXmitDataSegmentLength
MaxQueueCmd

-----Original Message-----
From: Or Gerlitz
Sent: Wednesday, October 29, 2014 7:52 AM
To: Roi Dayan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] iser: fix local conn params being reset to default

Quoted 2 lines · Roi Dayan

Instead of reseting the params to default if they pass it we should reset to max if they pass it.

who are they? can you remind me what are the local params?

Or.

Quoted 21 lines
---
  usr/iscsi/iser_text.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
usr/iscsi/iser_text.c index renamed from usr/iscsi/iser_text.c +0 -0

8180dbc..b8c5136 100644

usr/iscsi/iser_text.c +2 -2
@@ -342,8 +342,8 @@ static int iser_login_check_params(struct iscsi_connection *iscsi_conn,
  		if (p[i].state == KEY_STATE_START && p[i].val != session_keys[i].def) {
  			if (iscsi_conn->state == STATE_LOGIN) {
  				if (i >= ISCSI_PARAM_FIRST_LOCAL) {
-					if (p[i].val > session_keys[i].def)
-						p[i].val = session_keys[i].def;
+					if (p[i].val > session_keys[i].max)
+						p[i].val = session_keys[i].max;
  					p[i].state = KEY_STATE_DONE;
  					continue;
  				}