drm/i915/dp: only use training pattern 3 on platforms that support it
Subsystems (2)
PATCH 1/1 drm/i915/dp: only use training pattern 3 on platforms that support it
Ivybridge + 30" monitor prints a drm error on every modeset, since IVB doesn't support DP3 we should even bother trying to use it.
This regression has been introduced in
commit 06ea66b6bb445043dc25a9626254d5c130093199
Author: Todd Previte <[email protected]> Date: Mon Jan 20 10:19:39 2014 -0700
drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable
devices
Reference: http://mid.gmane.org/[email protected]
--- drivers/gpu/drm/i915/intel_dp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +3 -2
@@ -3945,9 +3945,10 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp) } } -/* Training Pattern 3 support */ +/* Training Pattern 3 support, both source and sink */ if (intel_dp->dpcd[DP_DPCD_REV ] >=0x12 && - intel_dp->dpcd[DP_MAX_LANE_COUNT ] &DP_TPS3_SUPPORTED ) { + intel_dp->dpcd[DP_MAX_LANE_COUNT ] &DP_TPS3_SUPPORTED && + (IS_HASWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=8 )) { intel_dp->use_tps3 = true;DRM_DEBUG_KMS ("Displayport TPS3 supported\n" ); }else
Signature · 6 lines
2.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 26 lines · Jani Nikula
Ivybridge + 30" monitor prints a drm error on every modeset, since IVB doesn't support DP3 we should even bother trying to use it.
This regression has been introduced in
commit
06ea66b6bb445043dc25a9626254d5c130093199Author: Todd Previte <[email protected]> Date: Mon Jan 20 10:19:39 2014 -0700drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable
devicesReported-by Dave Airlie <[email protected]>Reference: http://mid.gmane.org/[email protected]
Cc Todd Previte <[email protected]>Cc [email protected] (3.15+)Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0
drivers/gpu/drm/i915/intel_dp.c intel_dp_get_dpcd(struct intel_dp *intel_dp) · line 3951
Quoted 9 lines
drivers/gpu/drm/i915/intel_dp.c +3
-2@@ -3945,9 +3945,10 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp) } } -/* Training Pattern 3 support */ +/* Training Pattern 3 support, both source and sink */ if (intel_dp->dpcd[DP_DPCD_REV ] >=0x12 && - intel_dp->dpcd[DP_MAX_LANE_COUNT ] &DP_TPS3_SUPPORTED ) { + intel_dp->dpcd[DP_MAX_LANE_COUNT ] &DP_TPS3_SUPPORTED && + (IS_HASWELL (dev_priv) ||INTEL_INFO (dev_priv)->gen >=8 )) {
Yep that looks better. Additonally we could drop the 'link_bw == DP_LINK_BW_5_4' check from intel_dp_complete_link_train() and just rely on use_tps3 since pattern 3 is mandatory for HBR2 capable sinks, and so they really should advertise DP_TPS3_SUPPORTED. But on the other hand I don't see any harm in keeping the current logic there.
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0intel_dp->use_tps3 = true;DRM_DEBUG_KMS ("Displayport TPS3 supported\n" ); }else Signature · 1 line
2.1.1
Signature · 2 lines
Ville Syrjälä Intel OTC