Skip to contentSkip to conversation

iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

PATCH Applied Axel Lin 3 participants 3 messages Nov 1, 2014 – Nov 4, 2014 IOMMU

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

Signed-off-by Axel Lin <[email protected]>
---
 drivers/iommu/ipmmu-vmsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/ipmmu-vmsa.c +1 -1
index 7dab5cb..d25fa12 100644
@@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
 			       dev_name(&pdev->dev), mmu);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
-		return irq;
+		return ret;
 	}
 
 	ipmmu_device_reset(mmu);
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Axel,

Thank you for the patch.

Quoted 1 line · On Saturday 01 November 2014 11:45:32 Axel Lin wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/[email protected]>

Joerg, could you please pick this patch up ?

Quoted 17 lines
---
 drivers/iommu/ipmmu-vmsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/ipmmu-vmsa.c +1 -1
index 7dab5cb..d25fa12 100644
@@ -1184,7 +1184,7 @@ static int ipmmu_probe(struct platform_device *pdev)
 			       dev_name(&pdev->dev), mmu);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to request IRQ %d\n", irq);
-		return irq;
+		return ret;
 	}
 
 	ipmmu_device_reset(mmu);
Signature · 3 lines
Regards,

Laurent Pinchart