Skip to contentSkip to conversation

mei: nfc: clean nfc internal struct on host exit

PATCH Superseded Tomas Winkler 2 participants 3 messages Nov 4, 2014

Subsystems (2)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 mei: nfc: clean nfc internal struct on host exit

NFC internal structure cleaning was dropped by commit

commit 5ad1550a15cd5b75ed8aa3009e162822f720375e

Author: Tomas Winkler <[email protected]>
Date:   Sun Jan 26 11:53:06 2014 +0200

mei: Remove all bus devices from the mei_dev list when stopping the MEI

We allocate nfc_dev and free it across the reset so we do not keep it in dirty state

---
V2: allocate mei_nfc_dev dynamically
V3: Drop the stable request as manual rebase is required,
a sperate request will be sent

 drivers/misc/mei/bus.c     |  4 ++--
 drivers/misc/mei/mei_dev.h |  1 +
 drivers/misc/mei/nfc.c     | 42 ++++++++++++++++++++++++++++++++----------
 3 files changed, 35 insertions(+), 12 deletions(-)
drivers/misc/mei/bus.c +2 -2
index 4d20d60ca38d..b3a72bca5242 100644
@@ -140,7 +140,7 @@ static struct device_type mei_cl_device_type = {
 	.release	= mei_cl_dev_release,
 };
 
-static struct mei_cl *mei_bus_find_mei_cl_by_uuid(struct mei_device *dev,
+struct mei_cl *mei_cl_bus_find_cl_by_uuid(struct mei_device *dev,
 						uuid_le uuid)
 {
 	struct mei_cl *cl;
@@ -160,7 +160,7 @@ struct mei_cl_device *mei_cl_add_device(struct mei_device *dev,
 	struct mei_cl *cl;
 	int status;
 
-	cl = mei_bus_find_mei_cl_by_uuid(dev, uuid);
+	cl = mei_cl_bus_find_cl_by_uuid(dev, uuid);
 	if (cl == NULL)
 		return NULL;
 
drivers/misc/mei/mei_dev.h +1 -0
index 71744b16cc8c..1288a5cf60b9 100644
@@ -349,6 +349,7 @@ void mei_cl_bus_rx_event(struct mei_cl *cl);
 void mei_cl_bus_remove_devices(struct mei_device *dev);
 int mei_cl_bus_init(void);
 void mei_cl_bus_exit(void);
+struct mei_cl *mei_cl_bus_find_cl_by_uuid(struct mei_device *dev, uuid_le uuid);
 
 
 /**
drivers/misc/mei/nfc.c +32 -10

85 lines not on this page · raw message

Signature · 1 line
1.9.3
maintainer
#1 lore raw
Quoted 5 lines · Tomas Winkler

NFC internal structure cleaning was dropped by commit

commit 5ad1550a15cd5b75ed8aa3009e162822f720375e

Author: Tomas Winkler <[email protected]>
Date:   Sun Jan 26 11:53:06 2014 +0200

Where is this commit id from? I don't see it in Linus's tree.

thanks,

greg k-h

#2 lore raw
Quoted 9 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Tuesday, November 04, 2014 18:32
To: Winkler, Tomas
Cc: [email protected]; [email protected]; Usyskin, Alexander
Subject: Re: [char-misc V3 3.18] mei: nfc: clean nfc internal struct on host exit

Quoted 8 lines
Quoted 5 lines · Tomas Winkler

NFC internal structure cleaning was dropped by commit

commit 5ad1550a15cd5b75ed8aa3009e162822f720375e

Author: Tomas Winkler <[email protected]>
Date:   Sun Jan 26 11:53:06 2014 +0200

Where is this commit id from? I don't see it in Linus's tree.

This is the correct one 487056932d372cc4f6c636f21a928d6667b151d7 Will resend.
Tomas